Skip to content

Conversation

@kishan-dhankecha
Copy link
Contributor

  • added language for all code blocks
  • replaced bash or shell with sh for consistency.
  • added sh and console in the GitHub template link generator.
  • updated test for GitHub template.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Apr 28, 2024
@kishan-dhankecha kishan-dhankecha force-pushed the add_missing_code_block_language branch 2 times, most recently from baccc66 to f771c29 Compare April 28, 2024 09:54
- added language for all code blocks
- replaced `bash` or `shell` to `sh` for consistency.
- added `sh` and `console` in github template link generator.
- updated test for github templete.
@kishan-dhankecha kishan-dhankecha force-pushed the add_missing_code_block_language branch from f771c29 to 35b7291 Compare April 29, 2024 05:05
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your contribution!

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 30, 2024
@auto-submit auto-submit bot merged commit 2867ac7 into flutter:master May 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 1, 2024
flutter/flutter@b597dd2...d33bb8f

2024-05-01 sokolovskyi.konstantin@gmail.com Add tests for single_activator.0.dart API example. (flutter/flutter#147426)
2024-05-01 Dhankechakishan@gmail.com Added missing code block language in docs (flutter/flutter#147481)
2024-05-01 zanderso@users.noreply.github.com Move docs_test and docs_publish to bringup (flutter/flutter#147645)
2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix memory leak in `TabPageSelector`  (#147403)" (flutter/flutter#147622)
2024-04-30 47866232+chunhtai@users.noreply.github.com Revert "add a new PopScope.onPopWithResultInvoke widget to replace Po� (flutter/flutter#147597)
2024-04-30 andrewrkolos@gmail.com include exception details in tool exit displayed when adb call fails (flutter/flutter#147498)
2024-04-30 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in `TabPageSelector`  (flutter/flutter#147403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@kishan-dhankecha kishan-dhankecha deleted the add_missing_code_block_language branch May 15, 2024 04:31
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@b597dd2...d33bb8f

2024-05-01 sokolovskyi.konstantin@gmail.com Add tests for single_activator.0.dart API example. (flutter/flutter#147426)
2024-05-01 Dhankechakishan@gmail.com Added missing code block language in docs (flutter/flutter#147481)
2024-05-01 zanderso@users.noreply.github.com Move docs_test and docs_publish to bringup (flutter/flutter#147645)
2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix memory leak in `TabPageSelector`  (#147403)" (flutter/flutter#147622)
2024-04-30 47866232+chunhtai@users.noreply.github.com Revert "add a new PopScope.onPopWithResultInvoke widget to replace Po� (flutter/flutter#147597)
2024-04-30 andrewrkolos@gmail.com include exception details in tool exit displayed when adb call fails (flutter/flutter#147498)
2024-04-30 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in `TabPageSelector`  (flutter/flutter#147403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants