Do not shorten native assets framework names #144568

knopp · 2024-03-04T21:48:59Z

Previously the name was shortened to 15 characters, which doesn't seem to be necessary. CFBundleName documentation mentions 15 character length, but that does not seem to be relevant to framework bundles.

Flutter plugins already have framework bundles with names longer than 15 characters and it is not causing any issues.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

knopp · 2024-03-05T11:08:13Z

@dcharkes

dcharkes

lgtm! Thanks @knopp! 🚀

…#144568)

flutter/flutter@65cd84b...3b5a2ec 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 17a4b66e0729 to 8916bb32b7b8 (1 revision) (flutter/flutter#144615) 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from d514a302cdff to 17a4b66e0729 (8 revisions) (flutter/flutter#144607) 2024-03-05 matej.knopp@gmail.com Do not shorten native assets framework names (flutter/flutter#144568) 2024-03-05 leroux_bruno@yahoo.fr Restorable CupertinoTextFormFieldRow (flutter/flutter#144541) 2024-03-05 hans.muller@gmail.com Updated the TextButton image button example artwork (flutter/flutter#144583) 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 728aa4ef05d4 to d514a302cdff (2 revisions) (flutter/flutter#144581) 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 62cf93be60b2 to 728aa4ef05d4 (3 revisions) (flutter/flutter#144578) 2024-03-05 jonahwilliams@google.com Disable super flakey impeller test. (flutter/flutter#144573) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40018811ec0e to 62cf93be60b2 (1 revision) (flutter/flutter#144572) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0d8588b1de7a to 40018811ec0e (6 revisions) (flutter/flutter#144570) 2024-03-04 magder@google.com Print warning and exit when iOS device is unpaired (flutter/flutter#144551) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revision) (flutter/flutter#144558) 2024-03-04 31859944+LongCatIsLooong@users.noreply.github.com Remove unnecessary (and the only) `RenderObject.markParentNeedsLayout` override (flutter/flutter#144466) 2024-03-04 leroux_bruno@yahoo.fr Fix text color for default CupertinoContextMenuAction (flutter/flutter#144542) 2024-03-04 nate.w5687@gmail.com Add missing parameter to `TableBorder.symmetric`, and improve class constructors (flutter/flutter#144279) 2024-03-04 matej.knopp@gmail.com Fix build mode not propagated in android native asset build (flutter/flutter#144550) 2024-03-04 engine-flutter-autoroll@skia.org Roll Packages from a9c68b8 to 0625827 (3 revisions) (flutter/flutter#144556) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from afd2d9f9421d to a31209171949 (1 revision) (flutter/flutter#144554) 2024-03-04 36861262+QuncCccccc@users.noreply.github.com Doc fix for `DropdownButtonFormField.value` (flutter/flutter#144427) 2024-03-04 pateltirth454@gmail.com Fix Small Typo in Skia_Client Doc Comment (flutter/flutter#144490) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2338a557e018 to afd2d9f9421d (1 revision) (flutter/flutter#144549) 2024-03-04 737941+loic-sharma@users.noreply.github.com [Windows] Update keyboard modifiers link (flutter/flutter#144426) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9cbca80e2196 to 2338a557e018 (2 revisions) (flutter/flutter#144545) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from c52b3033eca6 to 9cbca80e2196 (1 revision) (flutter/flutter#144523) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 024ea680ceed to c52b3033eca6 (1 revision) (flutter/flutter#144522) 2024-03-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2706c732b22a to 024ea680ceed (1 revision) (flutter/flutter#144519) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…#144568)

Do not shorten native assets framework names

db33c85

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels Mar 4, 2024

Fix tests

f42fd74

knopp force-pushed the do_not_trim_filename branch from 0cbfbf4 to f42fd74 Compare March 5, 2024 10:17

dcharkes requested a review from jmagman March 5, 2024 12:49

dcharkes approved these changes Mar 5, 2024

View reviewed changes

knopp merged commit df2b360 into flutter:master Mar 5, 2024

knopp deleted the do_not_trim_filename branch March 5, 2024 13:58

engine-flutter-autoroll mentioned this pull request Mar 5, 2024

Roll Flutter from 65cd84b58885 to df2b36045302 (24 revisions) flutter/packages#6266

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2024

df2b360 Do not shorten native assets framework names (flutter/flutter…

cd98fda

…#144568)

engine-flutter-autoroll mentioned this pull request Mar 5, 2024

Roll Flutter from 65cd84b58885 to a47af8911920 (25 revisions) flutter/packages#6268

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2024

df2b360 Do not shorten native assets framework names (flutter/flutter…

4119717

…#144568)

engine-flutter-autoroll mentioned this pull request Mar 5, 2024

Roll Flutter from 65cd84b58885 to 3b5a2ecf992d (26 revisions) flutter/packages#6269

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2024

df2b360 Do not shorten native assets framework names (flutter/flutter…

4fca6e4

…#144568)

dcharkes mentioned this pull request May 9, 2024

[native_assets] There's two errors thrown by Xcode 15.3 when submitting Flutter apps built with native_assets to the App Store. #148044

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

df2b360 Do not shorten native assets framework names (flutter/flutter…

ab37638

…#144568)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Do not shorten native assets framework names #144568

Do not shorten native assets framework names #144568

Uh oh!

knopp commented Mar 4, 2024

Uh oh!

knopp commented Mar 5, 2024

Uh oh!

dcharkes left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Do not shorten native assets framework names #144568

Do not shorten native assets framework names #144568

Uh oh!

Conversation

knopp commented Mar 4, 2024

Pre-launch Checklist

Uh oh!

knopp commented Mar 5, 2024

Uh oh!

dcharkes left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants