Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revision) #144558

engine-flutter-autoroll · 2024-03-04T19:04:41Z

flutter/engine@a312091...0d8588b

2024-03-04 30870216+gaaclarke@users.noreply.github.com [Impeller] implements blur styles inner and outer (flutter/engine#51018)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…gine#51018)

flutter-dashboard · 2024-03-04T19:45:12Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #144558 at sha 0518811

gaaclarke · 2024-03-04T22:12:45Z

Notes from chat:

gaaclarke: painting.boxShadow.boxStyle.inner.0.0 and painting.boxShadow.boxStyle.outer.0.0 look correct to me, the previous goldens were incorrect. The second 2 look odd. I'll have to look at the code to know if it was a regression. It's likely the old goldens were wrong too considering that's the case for the other 2 (and there is no way they could be correct since the feature wasn't implemented)

gaaclarke: man skia gold isn't letting me zoom on those pictures, are they supposed to be teeny tiny

gaaclarke: actually, the second ones look good too. It's a weird output but that makes sense. The old golden images look good, because they were falling back to normal blur. These look off, just because it's a weird thing to do (mask blur styles with a shadow)

…sion) (flutter/flutter#144558)

flutter/flutter@65cd84b...3b5a2ec 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 17a4b66e0729 to 8916bb32b7b8 (1 revision) (flutter/flutter#144615) 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from d514a302cdff to 17a4b66e0729 (8 revisions) (flutter/flutter#144607) 2024-03-05 matej.knopp@gmail.com Do not shorten native assets framework names (flutter/flutter#144568) 2024-03-05 leroux_bruno@yahoo.fr Restorable CupertinoTextFormFieldRow (flutter/flutter#144541) 2024-03-05 hans.muller@gmail.com Updated the TextButton image button example artwork (flutter/flutter#144583) 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 728aa4ef05d4 to d514a302cdff (2 revisions) (flutter/flutter#144581) 2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 62cf93be60b2 to 728aa4ef05d4 (3 revisions) (flutter/flutter#144578) 2024-03-05 jonahwilliams@google.com Disable super flakey impeller test. (flutter/flutter#144573) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40018811ec0e to 62cf93be60b2 (1 revision) (flutter/flutter#144572) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0d8588b1de7a to 40018811ec0e (6 revisions) (flutter/flutter#144570) 2024-03-04 magder@google.com Print warning and exit when iOS device is unpaired (flutter/flutter#144551) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revision) (flutter/flutter#144558) 2024-03-04 31859944+LongCatIsLooong@users.noreply.github.com Remove unnecessary (and the only) `RenderObject.markParentNeedsLayout` override (flutter/flutter#144466) 2024-03-04 leroux_bruno@yahoo.fr Fix text color for default CupertinoContextMenuAction (flutter/flutter#144542) 2024-03-04 nate.w5687@gmail.com Add missing parameter to `TableBorder.symmetric`, and improve class constructors (flutter/flutter#144279) 2024-03-04 matej.knopp@gmail.com Fix build mode not propagated in android native asset build (flutter/flutter#144550) 2024-03-04 engine-flutter-autoroll@skia.org Roll Packages from a9c68b8 to 0625827 (3 revisions) (flutter/flutter#144556) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from afd2d9f9421d to a31209171949 (1 revision) (flutter/flutter#144554) 2024-03-04 36861262+QuncCccccc@users.noreply.github.com Doc fix for `DropdownButtonFormField.value` (flutter/flutter#144427) 2024-03-04 pateltirth454@gmail.com Fix Small Typo in Skia_Client Doc Comment (flutter/flutter#144490) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2338a557e018 to afd2d9f9421d (1 revision) (flutter/flutter#144549) 2024-03-04 737941+loic-sharma@users.noreply.github.com [Windows] Update keyboard modifiers link (flutter/flutter#144426) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9cbca80e2196 to 2338a557e018 (2 revisions) (flutter/flutter#144545) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from c52b3033eca6 to 9cbca80e2196 (1 revision) (flutter/flutter#144523) 2024-03-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 024ea680ceed to c52b3033eca6 (1 revision) (flutter/flutter#144522) 2024-03-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2706c732b22a to 024ea680ceed (1 revision) (flutter/flutter#144519) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…sion) (flutter/flutter#144558)

0d8588b [Impeller] implements blur styles inner and outer (flutter/en…

0518811

…gine#51018)

engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2024

github-actions bot added the engine flutter/engine related. See also e: labels. label Mar 4, 2024

fluttergithubbot approved these changes Mar 4, 2024

View reviewed changes

flutter-dashboard bot added the will affect goldens Changes to golden files label Mar 4, 2024

auto-submit bot merged commit d9eea79 into flutter:master Mar 4, 2024

engine-flutter-autoroll mentioned this pull request Mar 5, 2024

Roll Flutter from 65cd84b58885 to df2b36045302 (24 revisions) flutter/packages#6266

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2024

d9eea79 Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revi…

cc5e760

…sion) (flutter/flutter#144558)

engine-flutter-autoroll mentioned this pull request Mar 5, 2024

Roll Flutter from 65cd84b58885 to a47af8911920 (25 revisions) flutter/packages#6268

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2024

d9eea79 Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revi…

8539f02

…sion) (flutter/flutter#144558)

engine-flutter-autoroll mentioned this pull request Mar 5, 2024

Roll Flutter from 65cd84b58885 to 3b5a2ecf992d (26 revisions) flutter/packages#6269

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2024

d9eea79 Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revi…

b04b051

…sion) (flutter/flutter#144558)

engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-23e5f189-3b13-4425-a2b8-a091491cbc23-1709579078 branch March 12, 2024 17:02

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

d9eea79 Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revi…

1899fc0

…sion) (flutter/flutter#144558)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revision) #144558

Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revision) #144558

Uh oh!

engine-flutter-autoroll commented Mar 4, 2024

Uh oh!

flutter-dashboard bot commented Mar 4, 2024

Uh oh!

gaaclarke commented Mar 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revision) #144558

Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revision) #144558

Uh oh!

Conversation

engine-flutter-autoroll commented Mar 4, 2024

Uh oh!

flutter-dashboard bot commented Mar 4, 2024

Uh oh!

gaaclarke commented Mar 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants