Fix implementation imports outside of lib #143594

goderbauer · 2024-02-16T18:25:52Z

There are libraries outside a lib/ directory, which violate implementation_imports.

Supersedes #143560.

goderbauer · 2024-02-16T18:28:19Z

packages/flutter_tools/test/general.shard/resident_runner_test.dart

 import 'package:flutter_tools/src/version.dart';
 import 'package:flutter_tools/src/vmservice.dart';
-import 'package:unified_analytics/src/enums.dart';
+import 'package:unified_analytics/src/enums.dart' show DashEvent; // ignore: implementation_imports


@eliasyishak (or maybe @christopherfujino): Is it an oversight that unified_analytics doesn't export DashEvent and DevicePlatform (see below) even though it is used by the flutter_tool? Or is there a reason for this that I could leave as a comment on this ignore?

That was by design, it was so that clients of the package didn't have to deal with DashEvent but instead work with the data class Event.

And outside of tests, DevicePlatform didn't have any use in production code so didn't want it to cause any confusion

I see. Should this code be refactored to not rely on DashEvent then and somehow use the Event class?

It is kinda strange that the DashEvent type is used in the public API of the package, but isn't exported: https://github.com/dart-lang/tools/blob/8323b217373091d258e124ea80e50b4ad52c919d/pkgs/unified_analytics/lib/src/event.dart#L11

IMO, if it is part of the public API, it should be exported. I'll file an issue for this and link it here for now.

ah good call, yeah i would agree that it makes sense to export it then, that's not the case for DevicePlatform though is it?

If DevicePlatform is expected to be used in tests, I would expect that it is also exported. I don't think anyone should be doing src imports from other packages even in tests.

dart-lang/tools#234

got it, thanks for filing!

You could export it via a separate testing.dart library if it really is only expected to be used in tests.

christopherfujino · 2024-02-16T20:13:50Z

dev/bots/prepare_package/archive_publisher.dart

    });
    sink.close();
-    return digestSink.value.toString();
+    return digestSink.events.single.toString();


Is it safe to call events.single here? From reading the code, it looks like we're adding multiple chunks to it.

My understanding was that all those chunks get turned into a single Digest though.

I'm requesting changes while I play with this to confirm--will get back to you after testing...

FWIW, this is also what is suggested in the readme of the crypto package: https://pub.dev/packages/crypto#digest-on-chunked-input

yep you're right. I missed that sink is not digestSink, LGTM

christopherfujino

Thanks, LGTM!

christopherfujino

requesting changes while I verify digestSink will batch all chunks to a single digest

christopherfujino

LGTM

…3594)

Roll Flutter from d7867ca to 064c340 (33 revisions) flutter/flutter@d7867ca...064c340 2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from f71b7eee2266 to 714215d42e57 (1 revision) (flutter/flutter#143708) 2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 07c73b0c8413 to f71b7eee2266 (2 revisions) (flutter/flutter#143694) 2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 80d6745c6fd6 to 07c73b0c8413 (1 revision) (flutter/flutter#143682) 2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 67abf6eb36a1 to 80d6745c6fd6 (1 revision) (flutter/flutter#143676) 2024-02-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8ae232196fc9 to 67abf6eb36a1 (1 revision) (flutter/flutter#143673) 2024-02-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from f636f9635438 to 8ae232196fc9 (1 revision) (flutter/flutter#143659) 2024-02-18 ybz975218925@gmail.com Fixed the issue of incorrect item position when prototypeItem is set in SliverReorderableList. (flutter/flutter#142880) 2024-02-18 ybz975218925@gmail.com ShowCaretOnScreen is correctly scheduled within a SliverMainAxisGroup (flutter/flutter#141671) 2024-02-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0ebd580cb8a7 to f636f9635438 (1 revision) (flutter/flutter#143657) 2024-02-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from c807aeaab89c to 0ebd580cb8a7 (1 revision) (flutter/flutter#143655) 2024-02-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from e51d4f1e285a to c807aeaab89c (4 revisions) (flutter/flutter#143652) 2024-02-17 jason-simmons@users.noreply.github.com Manual roll Packages from c56c12d to 0af905d (flutter/flutter#143651) 2024-02-17 jason-simmons@users.noreply.github.com Add an override annotation to the lineTerminator setter in the MemoryStdout fake class (flutter/flutter#143646) 2024-02-17 leroux_bruno@yahoo.fr InputDecorator M3 tests migration - Step3 (flutter/flutter#143520) 2024-02-17 leroux_bruno@yahoo.fr Update InputDecoration.contentPadding documentation (flutter/flutter#143519) 2024-02-17 jonahwilliams@google.com [Impeller] skip selectable text goldens for instability. (flutter/flutter#143627) 2024-02-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2ed159a786ef to e51d4f1e285a (2 revisions) (flutter/flutter#143624) 2024-02-17 jonahwilliams@google.com [Impeller] skip perspective transformed text goldens. (flutter/flutter#143623) 2024-02-17 jonahwilliams@google.com [framework] Skip 5 failing framework tests. (flutter/flutter#143618) 2024-02-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from afb270929a6c to 2ed159a786ef (1 revision) (flutter/flutter#143622) 2024-02-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from c4fe6f01e0f5 to afb270929a6c (1 revision) (flutter/flutter#143619) 2024-02-16 bquinlan@google.com Implement `lineTerminator` in `MemoryStdout` Fake (flutter/flutter#143608) 2024-02-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2eed3fbb293a to c4fe6f01e0f5 (3 revisions) (flutter/flutter#143615) 2024-02-16 31859944+LongCatIsLooong@users.noreply.github.com Don't paint the cursor for an invalid selection (flutter/flutter#143533) 2024-02-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 13dc857bf2ef to 2eed3fbb293a (2 revisions) (flutter/flutter#143609) 2024-02-16 goderbauer@google.com Fix implementation imports outside of lib (flutter/flutter#143594) 2024-02-16 andrewrkolos@gmail.com add parsing of assets transformer declarations in pubspec.yaml (flutter/flutter#143557) 2024-02-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5fd5ccf32d08 to 13dc857bf2ef (6 revisions) (flutter/flutter#143607) 2024-02-16 goderbauer@google.com Fix SemanticsFinder for multi-view (flutter/flutter#143485) 2024-02-16 andrewrkolos@gmail.com rebuild the asset bundle if a file has been modified between `flutter test` runs (flutter/flutter#143569) 2024-02-16 pateltirth454@gmail.com Added Missing Field Name in Doc Comment in SnackBarThemeData (flutter/flutter#143588) 2024-02-16 nate.w5687@gmail.com Implementing `switch` expressions [refactoring `flutter/lib/src/`] (flutter/flutter#143496) 2024-02-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd530f1556df to 5fd5ccf32d08 (3 revisions) (flutter/flutter#143593) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

…3594)

Fix implementation imports outside of lib

28d3d09

github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. labels Feb 16, 2024

goderbauer commented Feb 16, 2024

View reviewed changes

goderbauer mentioned this pull request Feb 16, 2024

Ignore implementation_imports in non-lib files #143560

Closed

8 tasks

goderbauer requested review from christopherfujino, eliasyishak and srawlins February 16, 2024 18:30

goderbauer mentioned this pull request Feb 16, 2024

unified_analytics should export DashEvent and DevicePlatform dart-lang/tools#234

Closed

add comments

77cfe77

srawlins approved these changes Feb 16, 2024

View reviewed changes

christopherfujino reviewed Feb 16, 2024

View reviewed changes

christopherfujino approved these changes Feb 16, 2024

View reviewed changes

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 16, 2024

christopherfujino suggested changes Feb 16, 2024

View reviewed changes

goderbauer removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 16, 2024

christopherfujino approved these changes Feb 16, 2024

View reviewed changes

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 16, 2024

auto-submit bot merged commit 546bdec into flutter:master Feb 16, 2024

engine-flutter-autoroll mentioned this pull request Feb 17, 2024

Roll Flutter from d7867ca7d635 to 8a5efa53d8cf (20 revisions) flutter/packages#6151

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2024

546bdec Fix implementation imports outside of lib (flutter/flutter#14…

b04c2f0

…3594)

engine-flutter-autoroll mentioned this pull request Feb 17, 2024

Roll Flutter from d7867ca7d635 to 80364887762d (21 revisions) flutter/packages#6153

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2024

546bdec Fix implementation imports outside of lib (flutter/flutter#14…

676f3bd

…3594)

engine-flutter-autoroll mentioned this pull request Feb 18, 2024

Roll Flutter from d7867ca7d635 to 3578e75ef246 (28 revisions) flutter/packages#6155

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2024

546bdec Fix implementation imports outside of lib (flutter/flutter#14…

2495572

…3594)

engine-flutter-autoroll mentioned this pull request Feb 18, 2024

Roll Flutter from d7867ca7d635 to 3578e75ef246 (28 revisions) flutter/packages#6156

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2024

546bdec Fix implementation imports outside of lib (flutter/flutter#14…

aa6d9d2

…3594)

engine-flutter-autoroll mentioned this pull request Feb 19, 2024

Roll Flutter from d7867ca7d635 to d2e7414a926d (32 revisions) flutter/packages#6160

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2024

546bdec Fix implementation imports outside of lib (flutter/flutter#14…

785b5ff

…3594)

engine-flutter-autoroll mentioned this pull request Feb 19, 2024

Roll Flutter from d7867ca7d635 to 064c340baf0e (33 revisions) flutter/packages#6161

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2024

546bdec Fix implementation imports outside of lib (flutter/flutter#14…

0744298

…3594)

goderbauer deleted the fixImplImports branch March 8, 2024 22:17

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

546bdec Fix implementation imports outside of lib (flutter/flutter#14…

6c42613

…3594)

Fix implementation imports outside of lib #143594

Fix implementation imports outside of lib #143594

Uh oh!

Conversation

goderbauer commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

goderbauer commented Feb 16, 2024 •

edited

Loading