Don't paint the cursor for an invalid selection #143533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The internal golden test changes are expected (cursor disappears from text fields with invalid selections). |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 19, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 19, 2024
Roll Flutter from d7867ca to 064c340 (33 revisions) flutter/flutter@d7867ca...064c340 2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from f71b7eee2266 to 714215d42e57 (1 revision) (flutter/flutter#143708) 2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 07c73b0c8413 to f71b7eee2266 (2 revisions) (flutter/flutter#143694) 2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 80d6745c6fd6 to 07c73b0c8413 (1 revision) (flutter/flutter#143682) 2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 67abf6eb36a1 to 80d6745c6fd6 (1 revision) (flutter/flutter#143676) 2024-02-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8ae232196fc9 to 67abf6eb36a1 (1 revision) (flutter/flutter#143673) 2024-02-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from f636f9635438 to 8ae232196fc9 (1 revision) (flutter/flutter#143659) 2024-02-18 ybz975218925@gmail.com Fixed the issue of incorrect item position when prototypeItem is set in SliverReorderableList. (flutter/flutter#142880) 2024-02-18 ybz975218925@gmail.com ShowCaretOnScreen is correctly scheduled within a SliverMainAxisGroup (flutter/flutter#141671) 2024-02-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0ebd580cb8a7 to f636f9635438 (1 revision) (flutter/flutter#143657) 2024-02-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from c807aeaab89c to 0ebd580cb8a7 (1 revision) (flutter/flutter#143655) 2024-02-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from e51d4f1e285a to c807aeaab89c (4 revisions) (flutter/flutter#143652) 2024-02-17 jason-simmons@users.noreply.github.com Manual roll Packages from c56c12d to 0af905d (flutter/flutter#143651) 2024-02-17 jason-simmons@users.noreply.github.com Add an override annotation to the lineTerminator setter in the MemoryStdout fake class (flutter/flutter#143646) 2024-02-17 leroux_bruno@yahoo.fr InputDecorator M3 tests migration - Step3 (flutter/flutter#143520) 2024-02-17 leroux_bruno@yahoo.fr Update InputDecoration.contentPadding documentation (flutter/flutter#143519) 2024-02-17 jonahwilliams@google.com [Impeller] skip selectable text goldens for instability. (flutter/flutter#143627) 2024-02-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2ed159a786ef to e51d4f1e285a (2 revisions) (flutter/flutter#143624) 2024-02-17 jonahwilliams@google.com [Impeller] skip perspective transformed text goldens. (flutter/flutter#143623) 2024-02-17 jonahwilliams@google.com [framework] Skip 5 failing framework tests. (flutter/flutter#143618) 2024-02-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from afb270929a6c to 2ed159a786ef (1 revision) (flutter/flutter#143622) 2024-02-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from c4fe6f01e0f5 to afb270929a6c (1 revision) (flutter/flutter#143619) 2024-02-16 bquinlan@google.com Implement `lineTerminator` in `MemoryStdout` Fake (flutter/flutter#143608) 2024-02-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2eed3fbb293a to c4fe6f01e0f5 (3 revisions) (flutter/flutter#143615) 2024-02-16 31859944+LongCatIsLooong@users.noreply.github.com Don't paint the cursor for an invalid selection (flutter/flutter#143533) 2024-02-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 13dc857bf2ef to 2eed3fbb293a (2 revisions) (flutter/flutter#143609) 2024-02-16 goderbauer@google.com Fix implementation imports outside of lib (flutter/flutter#143594) 2024-02-16 andrewrkolos@gmail.com add parsing of assets transformer declarations in pubspec.yaml (flutter/flutter#143557) 2024-02-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5fd5ccf32d08 to 13dc857bf2ef (6 revisions) (flutter/flutter#143607) 2024-02-16 goderbauer@google.com Fix SemanticsFinder for multi-view (flutter/flutter#143485) 2024-02-16 andrewrkolos@gmail.com rebuild the asset bundle if a file has been modified between `flutter test` runs (flutter/flutter#143569) 2024-02-16 pateltirth454@gmail.com Added Missing Field Name in Doc Comment in SnackBarThemeData (flutter/flutter#143588) 2024-02-16 nate.w5687@gmail.com Implementing `switch` expressions [refactoring `flutter/lib/src/`] (flutter/flutter#143496) 2024-02-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd530f1556df to 5fd5ccf32d08 (3 revisions) (flutter/flutter#143593) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79495
This is basically a reland of #79607.
Currently when the cursor is invalid, arrow key navigation / typing / backspacing doesn't work since the cursor position is unknown.
Showing the cursor when the selection is invalid gives the user the wrong information about the current insert point in the text.
This is going to break internal golden tests.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.