Skip to content

Instrument CurvedAnimation. #143007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Feb 7, 2024
Merged

Instrument CurvedAnimation. #143007

auto-submit merged 3 commits into from
Feb 7, 2024

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Feb 6, 2024

No description provided.

@polina-c polina-c requested a review from dnfield February 6, 2024 20:35
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs labels Feb 6, 2024
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2024
p-mazhnik
p-mazhnik reviewed Feb 6, 2024
View reviewed changes
packages/flutter/test/animation/animation_controller_test.dart Outdated
});

test('AnimationController dispatches memory events', () async {
test('CurvedAnimation dispatches memory events', () async {
Copy link
Contributor

@p-mazhnik p-mazhnik Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @polina-c I was just passing by and noticed that you edited this test in the wrong file. I think this test should be in animations_test.dart file instead. And test from animations_test.dart should be here

Copy link
Contributor Author

@polina-c polina-c Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Fixed.

@polina-c polina-c removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2024
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Feb 6, 2024
@polina-c polina-c requested a review from p-mazhnik February 6, 2024 23:28
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2024
@auto-submit auto-submit bot merged commit ac5c3de into flutter:master Feb 7, 2024
@polina-c polina-c deleted the instrument branch February 7, 2024 03:28
dumazy added a commit to dumazy/flutter that referenced this pull request Feb 7, 2024
@dumazy
Merge branch 'master' into fix/form_autovalidatemode_always
adde609 
* master: (32 commits)
  [reland] Add `AnimationStyle` to `showSnackBar` (flutter#143052)
  Run Mac x64 build tests in postsubmit only (flutter#142334)
  Copy the flutter version JSON file into the simulated Flutter SDK used by update_packages (flutter#143035)
  Mark `Windows_android hot_mode_dev_cycle_win__benchmark` as no longer flaky (flutter#143016)
  Dispose precached image info (flutter#143017)
  Instrument CurvedAnimation. (flutter#143007)
  Update _goldens_io.dart to generate failure images during a size mism… (flutter#142177)
  Reverts "Activate InkSparkle on CanvasKit" (flutter#143036)
  Activate InkSparkle on CanvasKit (flutter#138545)
  [Windows] Fix signed/unsigned int comparison (flutter#142341)
  Reverts "Move native assets to `isolated/` directory" (flutter#143027)
  Reverts "Roll Flutter Engine from 8088863 to 07cdaab (18 revisions)" (flutter#143025)
  Make destructiveRed a CupertinoDynamicColor (flutter#141364)
  Move native assets to `isolated/` directory (flutter#142709)
  Roll Flutter Engine from 8088863 to 07cdaab (18 revisions) (flutter#143005)
  Fix CupertinoPageScaffold resizeToAvoidBottomInset (flutter#142776)
  Reverts "Add `AnimationStyle` to `showSnackBar`" (flutter#143001)
  Material 3 - Tab indicator stretch animation (flutter#141954)
  Add `AnimationStyle` to `showSnackBar` (flutter#142825)
  Roll Packages from ae3494d to 1a5a7ce (2 revisions) (flutter#142985)
  ...
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2024
@engine-flutter-autoroll
ac5c3de Instrument CurvedAnimation. (flutter/flutter#143007)
e0e2a23
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2024
@engine-flutter-autoroll
ac5c3de Instrument CurvedAnimation. (flutter/flutter#143007)
504f562
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2024
@engine-flutter-autoroll
ac5c3de Instrument CurvedAnimation. (flutter/flutter#143007)
acd09b7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2024
@engine-flutter-autoroll
ac5c3de Instrument CurvedAnimation. (flutter/flutter#143007)
908a448
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 7, 2024
@engine-flutter-autoroll
Roll Flutter from e6ba809 to 8431cae (23 revisions) (#6075)
cd621aa 
flutter/flutter@e6ba809...8431cae

2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ac6beb8a3c2 to 6807342305e4 (6 revisions) (flutter/flutter#143082)
2024-02-07 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 808886312e2b to 1ac6beb8a3c2 (22 revisions) (flutter/flutter#143039)
2024-02-07 engine-flutter-autoroll@skia.org Roll Packages from 1a5a7ce to e4ea6bf (4 revisions) (flutter/flutter#143076)
2024-02-07 leroux_bruno@yahoo.fr Fix M3 text field height + initial step for input decorator M3 test migration (flutter/flutter#142981)
2024-02-07 tessertaha@gmail.com [reland] Add `AnimationStyle` to `showSnackBar` (flutter/flutter#143052)
2024-02-07 magder@google.com Run Mac x64 build tests in postsubmit only (flutter/flutter#142334)
2024-02-07 jason-simmons@users.noreply.github.com Copy the flutter version JSON file into the simulated Flutter SDK used by update_packages (flutter/flutter#143035)
2024-02-07 andrewrkolos@gmail.com Mark `Windows_android hot_mode_dev_cycle_win__benchmark` as no longer flaky (flutter/flutter#143016)
2024-02-07 dnfield@google.com Dispose precached image info (flutter/flutter#143017)
2024-02-07 polinach@google.com Instrument CurvedAnimation. (flutter/flutter#143007)
2024-02-07 github@bramp.net Update _goldens_io.dart to generate failure images during a size mism� (flutter/flutter#142177)
2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Activate InkSparkle on CanvasKit" (flutter/flutter#143036)
2024-02-07 leroux_bruno@yahoo.fr Activate InkSparkle on CanvasKit (flutter/flutter#138545)
2024-02-07 chris@bracken.jp [Windows] Fix signed/unsigned int comparison (flutter/flutter#142341)
2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Move native assets to `isolated/` directory" (flutter/flutter#143027)
2024-02-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 808886312e2b to 07cdaab7f531 (18 revisions)" (flutter/flutter#143025)
2024-02-06 simonfv@gmail.com Make destructiveRed a CupertinoDynamicColor (flutter/flutter#141364)
2024-02-06 dacoharkes@google.com Move native assets to `isolated/` directory (flutter/flutter#142709)
2024-02-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 808886312e2b to 07cdaab7f531 (18 revisions) (flutter/flutter#143005)
2024-02-06 smartercallum@gmail.com Fix CupertinoPageScaffold resizeToAvoidBottomInset (flutter/flutter#142776)
2024-02-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `AnimationStyle` to `showSnackBar`" (flutter/flutter#143001)
2024-02-06 davidmartos96@gmail.com Material 3 - Tab indicator stretch animation (flutter/flutter#141954)
2024-02-06 tessertaha@gmail.com Add `AnimationStyle` to `showSnackBar` (flutter/flutter#142825)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
ac5c3de Instrument CurvedAnimation. (flutter/flutter#143007)
f0affa9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-mazhnik p-mazhnik Awaiting requested review from p-mazhnik

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: animation Animation APIs a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@polina-c @dnfield @p-mazhnik