Add AnimationStyle to showSnackBar
#142825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
HansMuller
reviewed
Feb 2, 2024
examples/api/lib/material/scaffold/scaffold_messenger_state.show_snack_bar.2.dart
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
If snackBarAnimationStyle.duration is null we will not get the appropriate default here. Might be better to add a nullable AnimationStyle keyword parameter to Snackbar.createAnimationController and DTRT there.
Member
Author
There was a problem hiding this comment.
If snackBarAnimationStyle.duration is null we will not get the appropriate default here.
Excellent catch. I added a new test for this scenario to make sure this will work as expected in the future
Member
|
Reason for revert: Analysis failure closing the engine tree https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8756815302197889649/+/u/Framework_analyze/Framework_analyze/stdout?format=raw |
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
This reverts commit 0cc381d.
8 tasks
auto-submit bot
added a commit
that referenced
this pull request
Feb 6, 2024
Reverts #142825 Initiated by: zanderso Reason for reverting: Analysis failure closing the engine tree https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8756815302197889649/+/u/Framework_analyze/Framework_analyze/stdout?format=raw Original PR Author: TahaTesser Reviewed By: {HansMuller} This change reverts the following previous change: Original Description: fixes [`showSnackBar` is always replacing `animation` parameter of `SnackBar`](#141646) ### Code sample preview 
Member
Author
Interesting. I would expect such analysis failure in the PR checks and it should prevent |
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
[Original was reverted due to uncaught analysis failure ](#142825 (comment)) --- fixes [`showSnackBar` is always replacing `animation` parameter of `SnackBar`](#141646) ### Code sample preview 
dumazy
added a commit
to dumazy/flutter
that referenced
this pull request
Feb 7, 2024
* master: (32 commits) [reland] Add `AnimationStyle` to `showSnackBar` (flutter#143052) Run Mac x64 build tests in postsubmit only (flutter#142334) Copy the flutter version JSON file into the simulated Flutter SDK used by update_packages (flutter#143035) Mark `Windows_android hot_mode_dev_cycle_win__benchmark` as no longer flaky (flutter#143016) Dispose precached image info (flutter#143017) Instrument CurvedAnimation. (flutter#143007) Update _goldens_io.dart to generate failure images during a size mism… (flutter#142177) Reverts "Activate InkSparkle on CanvasKit" (flutter#143036) Activate InkSparkle on CanvasKit (flutter#138545) [Windows] Fix signed/unsigned int comparison (flutter#142341) Reverts "Move native assets to `isolated/` directory" (flutter#143027) Reverts "Roll Flutter Engine from 8088863 to 07cdaab (18 revisions)" (flutter#143025) Make destructiveRed a CupertinoDynamicColor (flutter#141364) Move native assets to `isolated/` directory (flutter#142709) Roll Flutter Engine from 8088863 to 07cdaab (18 revisions) (flutter#143005) Fix CupertinoPageScaffold resizeToAvoidBottomInset (flutter#142776) Reverts "Add `AnimationStyle` to `showSnackBar`" (flutter#143001) Material 3 - Tab indicator stretch animation (flutter#141954) Add `AnimationStyle` to `showSnackBar` (flutter#142825) Roll Packages from ae3494d to 1a5a7ce (2 revisions) (flutter#142985) ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 7, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 7, 2024
Member
There was an infra issue yesterday that caused check failures to not be reported properly. It should be fixed now. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 7, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 7, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 7, 2024
flutter/flutter@e6ba809...8431cae 2024-02-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ac6beb8a3c2 to 6807342305e4 (6 revisions) (flutter/flutter#143082) 2024-02-07 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 808886312e2b to 1ac6beb8a3c2 (22 revisions) (flutter/flutter#143039) 2024-02-07 engine-flutter-autoroll@skia.org Roll Packages from 1a5a7ce to e4ea6bf (4 revisions) (flutter/flutter#143076) 2024-02-07 leroux_bruno@yahoo.fr Fix M3 text field height + initial step for input decorator M3 test migration (flutter/flutter#142981) 2024-02-07 tessertaha@gmail.com [reland] Add `AnimationStyle` to `showSnackBar` (flutter/flutter#143052) 2024-02-07 magder@google.com Run Mac x64 build tests in postsubmit only (flutter/flutter#142334) 2024-02-07 jason-simmons@users.noreply.github.com Copy the flutter version JSON file into the simulated Flutter SDK used by update_packages (flutter/flutter#143035) 2024-02-07 andrewrkolos@gmail.com Mark `Windows_android hot_mode_dev_cycle_win__benchmark` as no longer flaky (flutter/flutter#143016) 2024-02-07 dnfield@google.com Dispose precached image info (flutter/flutter#143017) 2024-02-07 polinach@google.com Instrument CurvedAnimation. (flutter/flutter#143007) 2024-02-07 github@bramp.net Update _goldens_io.dart to generate failure images during a size mism� (flutter/flutter#142177) 2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Activate InkSparkle on CanvasKit" (flutter/flutter#143036) 2024-02-07 leroux_bruno@yahoo.fr Activate InkSparkle on CanvasKit (flutter/flutter#138545) 2024-02-07 chris@bracken.jp [Windows] Fix signed/unsigned int comparison (flutter/flutter#142341) 2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Move native assets to `isolated/` directory" (flutter/flutter#143027) 2024-02-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 808886312e2b to 07cdaab7f531 (18 revisions)" (flutter/flutter#143025) 2024-02-06 simonfv@gmail.com Make destructiveRed a CupertinoDynamicColor (flutter/flutter#141364) 2024-02-06 dacoharkes@google.com Move native assets to `isolated/` directory (flutter/flutter#142709) 2024-02-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 808886312e2b to 07cdaab7f531 (18 revisions) (flutter/flutter#143005) 2024-02-06 smartercallum@gmail.com Fix CupertinoPageScaffold resizeToAvoidBottomInset (flutter/flutter#142776) 2024-02-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `AnimationStyle` to `showSnackBar`" (flutter/flutter#143001) 2024-02-06 davidmartos96@gmail.com Material 3 - Tab indicator stretch animation (flutter/flutter#141954) 2024-02-06 tessertaha@gmail.com Add `AnimationStyle` to `showSnackBar` (flutter/flutter#142825) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
showSnackBaris always replacinganimationparameter ofSnackBarCode sample preview
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.