Implement switch expressions in lib/src/material/
#142634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
loic-sharma
reviewed
Feb 1, 2024
loic-sharma
reviewed
Feb 1, 2024
loic-sharma
approved these changes
Feb 1, 2024
Member
loic-sharma
left a comment
There was a problem hiding this comment.
Thanks for doing this wonderful improvement!
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 5, 2024
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 5, 2024
Manual roll Flutter from e02e207 to 0b5cd50 (46 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@e02e207...0b5cd50 2024-02-05 124896814+BiskupMaik@users.noreply.github.com fix AppBar docs for backgroundColor & foregroundColor (flutter/flutter#142430) 2024-02-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update gradle lockfiles template" (flutter/flutter#142889) 2024-02-04 barpac02@gmail.com Update gradle lockfiles template (flutter/flutter#140115) 2024-02-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20742e37e54e to f34c658b9600 (1 revision) (flutter/flutter#142876) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23763db72272 to 20742e37e54e (1 revision) (flutter/flutter#142850) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from fee02145da8c to 23763db72272 (3 revisions) (flutter/flutter#142848) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9869d47a2736 to fee02145da8c (2 revisions) (flutter/flutter#142847) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 78c63d3c2c68 to 9869d47a2736 (1 revision) (flutter/flutter#142842) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 266d5d0b5588 to 78c63d3c2c68 (1 revision) (flutter/flutter#142836) 2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.2 to 3.24.0 (flutter/flutter#142839) 2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.6 to 4.0.1 (flutter/flutter#142838) 2024-02-02 jmccandless@google.com Update TextSelectionOverlay (flutter/flutter#142463) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from e29263212bfd to 266d5d0b5588 (5 revisions) (flutter/flutter#142832) 2024-02-02 luccas.clezar@gmail.com Fix CupertinoTextSelectionToolbar clipping (flutter/flutter#138195) 2024-02-02 barpac02@gmail.com Reland "Add support for Gradle Kotlin DSL (#140744)" (flutter/flutter#142752) 2024-02-02 jmccandless@google.com Support navigation during a Cupertino back gesture (flutter/flutter#142248) 2024-02-02 chingjun@google.com Avoid depending on files from build_system/targets other than from top level entrypoints in flutter_tools. (flutter/flutter#142760) 2024-02-02 engine-flutter-autoroll@skia.org Roll Packages from 5b48c44 to d37fb0a (14 revisions) (flutter/flutter#142812) 2024-02-02 32242716+ricardoamador@users.noreply.github.com Add a link the different possible Android virtual device configs (flutter/flutter#142765) 2024-02-02 15619084+vashworth@users.noreply.github.com Allow all iOS tests to use either iOS 16 or 17 (flutter/flutter#142714) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from b35153d00b2e to e29263212bfd (2 revisions) (flutter/flutter#142799) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd4c79a6c864 to b35153d00b2e (10 revisions) (flutter/flutter#142783) 2024-02-02 jacksongardner@google.com Wasm/JS Dual Compile with the flutter tool (flutter/flutter#141396) 2024-02-02 hans.muller@gmail.com Reland: Added ButtonStyle.foregroundBuilder and ButtonStyle.backgroundBuilder (flutter/flutter#142762) 2024-02-01 32242716+ricardoamador@users.noreply.github.com Use proto name for emulator version and show cipd package version (flutter/flutter#142262) 2024-02-01 xilaizhang@google.com [github actions] ping actor of workflow on cherry pick pr creation (flutter/flutter#142676) 2024-02-01 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#142590) 2024-02-01 nathan.wilson1232@gmail.com Implement `switch` expressions in `lib/src/material/` (flutter/flutter#142634) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9beb7e82e081 to dd4c79a6c864 (1 revision) (flutter/flutter#142749) 2024-02-01 pateltirth454@gmail.com Write Tests for API Example of `form.0.dart` (flutter/flutter#142635) 2024-02-01 polinach@google.com Make leak_tracking bots sticked to the left even if bot thinks they are non-flacky. (flutter/flutter#142744) 2024-02-01 15619084+vashworth@users.noreply.github.com Upload DerivedData logs in CI (flutter/flutter#142643) 2024-02-01 magder@google.com Test codesigning xcframeworks in artifacts (flutter/flutter#142666) 2024-02-01 davidmartos96@gmail.com Fix gen_defaults test randomness (flutter/flutter#142743) 2024-02-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Added ButtonStyle.foregroundBuilder and ButtonStyle.backgroundBuilder" (flutter/flutter#142748) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39415c3eed42 to 9beb7e82e081 (5 revisions) (flutter/flutter#142745) 2024-02-01 magder@google.com Remove unused deprecated autoroll mirror-remote flag (flutter/flutter#142738) 2024-02-01 polinach@google.com Fix leaks in tests. (flutter/flutter#142677) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8c43332c6ffc to 39415c3eed42 (1 revision) (flutter/flutter#142740) 2024-02-01 magder@google.com Remove verbose-system-logs on iOS perf tests (flutter/flutter#142739) 2024-02-01 magder@google.com Remove outdated arm64_armv7 check (flutter/flutter#142737) 2024-02-01 62812903+sstasi95@users.noreply.github.com fix CupertinoTabView's Android back button handling with PopScope (flutter/flutter#141604) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68943afd62d1 to 8c43332c6ffc (8 revisions) (flutter/flutter#142726) 2024-02-01 christopherfujino@gmail.com Unpin test (flutter/flutter#141427) ...
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
This PR is the 6�ʰ step in the journey to solve issue #136139 and make the entire Flutter repo more readable. (previous pull requests: #139048, #139882, #141591, #142279, #142634) The current focus is on `packages/flutter/lib/src/material/`. The previous 2 PRs covered files in this directory starting with letters `a-m`; this one takes care of everything else.
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
This PR is the 7�ʰ step in the journey to solve issue #136139 and make the entire Flutter repo more readable. (previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793) This pull request covers everything in `packages/flutter/lib/src/widgets/`. Most of it should be really straightforward, but there was some refactoring in the `getOffsetToReveal()` function in `two_dimensional_viewport.dart`. I'll add some comments to describe those changes.
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
…143496) This PR is the 8áµ�Ê° step in the journey to solve issue #136139 and make the entire Flutter repo more readable. (previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793, #143293) I did a pass through all of `packages/flutter/lib/src/` and found a whole bunch of `switch` statements to improve: most of them were really simple, but many involved some thorough refactoring. This pull request is just the complicated stuff. ð��� I'll make comments to describe the changes, and then in the future there will be another PR (and it'll be much easier to review than this one).
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
…143634) This PR is the 9áµ�Ê° step in the journey to solve issue #136139 and make the entire Flutter repo more readable. (previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793, #143293, #143496) I did a pass through all of `packages/flutter/lib/src/` and found an abundance of `switch` statements to improve. Whereas #143496 focused on in-depth refactoring, this PR is full of simple, straightforward changes. (I ended up making some more complicated changes in `rendering/` and will file those separately after this PR is done.)
9 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is step 5 in the journey to solve issue #136139 and make the entire Flutter repo more readable.
(previous pull requests: #139048, #139882, #141591, #142279)
The current focus is on
packages/flutter/lib/src/material/.The previous PR covered files in this directory starting with
a,b, andc; this pull request is fordthroughm.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.