Unpin test #141427

christopherfujino · 2024-01-12T01:04:15Z

christopherfujino · 2024-01-12T18:35:25Z

@DanTup @bkonyi @derekxu16 I think this is unblocked now, right?

-  test_api: 0.6.1
-  test_core: 0.5.9
+  test_api: 0.7.0
+  test_core: 0.6.0

-  vm_service: 13.0.0
+  vm_service: 14.0.0

derekxu16 · 2024-01-12T18:40:34Z

@DanTup @bkonyi @derekxu16 I think this is unblocked now, right?

Yes, it is safe to update package:vm_service.

christopherfujino · 2024-01-12T23:01:23Z

Maybe we'll need to roll devtools in flutter/tests?

| Because every version of integration_test from sdk depends on vm_service 14.0.0 and devtools_app depends on vm_service ^13.0.0, integration_test from sdk is forbidden.
| So, because devtools_app depends on integration_test from sdk, version solving failed.
ERROR: Could not run "flutter pub get" in packages/devtools_app, which was specified as an update directory.

https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20customer_testing/68365/overview

I'll look to update flutter/tests....

christopherfujino · 2024-01-12T23:17:25Z

Maybe we'll need to roll devtools in flutter/tests?
| Because every version of integration_test from sdk depends on vm_service 14.0.0 and devtools_app depends on vm_service ^13.0.0, integration_test from sdk is forbidden.
| So, because devtools_app depends on integration_test from sdk, version solving failed.
ERROR: Could not run "flutter pub get" in packages/devtools_app, which was specified as an update directory.
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20customer_testing/68365/overview

I'll look to update flutter/tests....

Oh actually, devtools hasn't been updated yet. @derekxu16 would you be able to update vm_service in devtools_app, since I think you are also blocked on this?

derekxu16 · 2024-01-15T14:30:30Z

Oh actually, devtools hasn't been updated yet. @derekxu16 would you be able to update vm_service in devtools_app, since I think you are also blocked on this?

Unfortunately, there's a cycle here. package:devtools_app cannot be updated to accept package:vm_service 14.0.0 until package:integration_test accepts it.

From https://github.com/flutter/devtools/actions/runs/7450073310/job/20268216240:

Because devtools_test depends on integration_test from sdk which depends on vm_service 13.0.0, vm_service 13.0.0 is required.
So, because devtools_test depends on vm_service ^14.0.0, version solving failed.

DanTup · 2024-01-15T15:26:09Z

package:devtools_app cannot be updated to accept package:vm_service 14.0.0 until package:integration_test accepts it.

Could DevTools be updated to support 13 + 14? (I don't know how breaking the changes are, so I don't know if that'll work). Otherwise, could DevTools be excluded from customer tests to land this, then updated, then re-added?

derekxu16 · 2024-01-15T15:59:24Z

Could DevTools be updated to support 13 + 14? (I don't know how breaking the changes are, so I don't know if that'll work). Otherwise, could DevTools be excluded from customer tests to land this, then updated, then re-added?

Following the second suggestion would be ideal. A lot of special checks would have to be added to convert between ints and DateTimes to make DevTools support both package:vm_service v13 and v14. Would it be possible to follow the second suggestion, @christopherfujino?

christopherfujino · 2024-01-16T19:42:52Z

Could DevTools be updated to support 13 + 14? (I don't know how breaking the changes are, so I don't know if that'll work). Otherwise, could DevTools be excluded from customer tests to land this, then updated, then re-added?

Following the second suggestion would be ideal. A lot of special checks would have to be added to convert between ints and DateTimes to make DevTools support both package:vm_service v13 and v14. Would it be possible to follow the second suggestion, @christopherfujino?

This is fine with me, as long as it's good with @kenzieschmoll. I just want to make sure we don't end up trying to roll an incompatible version of devtools into flutter/flutter.

kenzieschmoll · 2024-01-16T21:04:31Z

@derekxu16 has a draft PR to update DevTools to vm_service 14: flutter/devtools#6953. Derek can you give an update on this? If we disable the customer tests, then the DevTools CI will start failing shortly after this PR lands. So we will need to migrate DevTools to 14 either way.

derekxu16 · 2024-01-16T21:11:55Z

@derekxu16 has a draft PR to update DevTools to vm_service 14: flutter/devtools#6953. Derek can you give an update on this?

That PR is ready for review.

kenzieschmoll · 2024-01-16T21:25:45Z

I reviewed @derekxu16's DevTools PR to bump to vm_service 14. Let's follow the plan suggested above:

disable the DevTools flutter customer tests for now
land this PR
once the DevTools CI picks up this version of Flutter and the build goes red, Derek can land his DevTools PR to bump to vm_service 14 and fix the build
re-enable the DevTools flutter customer tests with the hash of Derek's DevTools PR

…flutter_goldens for extensive technical debt removal (#140101)" (#141814) Reverts #140101 That PR somehow made non-matching gold tests not fail at HEAD. Fixes #141880 - Blocked by #140169 - #141427

derekxu16 · 2024-01-25T15:29:59Z

Just wondering, what is the status of this?

christopherfujino · 2024-01-25T23:14:09Z

Just wondering, what is the status of this?

I'm gonna pick this up again next week--I'm pretty swamped right now.

Manual roll Flutter from e02e207 to 0b5cd50 (46 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@e02e207...0b5cd50 2024-02-05 124896814+BiskupMaik@users.noreply.github.com fix AppBar docs for backgroundColor & foregroundColor (flutter/flutter#142430) 2024-02-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update gradle lockfiles template" (flutter/flutter#142889) 2024-02-04 barpac02@gmail.com Update gradle lockfiles template (flutter/flutter#140115) 2024-02-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20742e37e54e to f34c658b9600 (1 revision) (flutter/flutter#142876) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23763db72272 to 20742e37e54e (1 revision) (flutter/flutter#142850) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from fee02145da8c to 23763db72272 (3 revisions) (flutter/flutter#142848) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9869d47a2736 to fee02145da8c (2 revisions) (flutter/flutter#142847) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 78c63d3c2c68 to 9869d47a2736 (1 revision) (flutter/flutter#142842) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 266d5d0b5588 to 78c63d3c2c68 (1 revision) (flutter/flutter#142836) 2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.2 to 3.24.0 (flutter/flutter#142839) 2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.6 to 4.0.1 (flutter/flutter#142838) 2024-02-02 jmccandless@google.com Update TextSelectionOverlay (flutter/flutter#142463) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from e29263212bfd to 266d5d0b5588 (5 revisions) (flutter/flutter#142832) 2024-02-02 luccas.clezar@gmail.com Fix CupertinoTextSelectionToolbar clipping (flutter/flutter#138195) 2024-02-02 barpac02@gmail.com Reland "Add support for Gradle Kotlin DSL (#140744)" (flutter/flutter#142752) 2024-02-02 jmccandless@google.com Support navigation during a Cupertino back gesture (flutter/flutter#142248) 2024-02-02 chingjun@google.com Avoid depending on files from build_system/targets other than from top level entrypoints in flutter_tools. (flutter/flutter#142760) 2024-02-02 engine-flutter-autoroll@skia.org Roll Packages from 5b48c44 to d37fb0a (14 revisions) (flutter/flutter#142812) 2024-02-02 32242716+ricardoamador@users.noreply.github.com Add a link the different possible Android virtual device configs (flutter/flutter#142765) 2024-02-02 15619084+vashworth@users.noreply.github.com Allow all iOS tests to use either iOS 16 or 17 (flutter/flutter#142714) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from b35153d00b2e to e29263212bfd (2 revisions) (flutter/flutter#142799) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd4c79a6c864 to b35153d00b2e (10 revisions) (flutter/flutter#142783) 2024-02-02 jacksongardner@google.com Wasm/JS Dual Compile with the flutter tool (flutter/flutter#141396) 2024-02-02 hans.muller@gmail.com Reland: Added ButtonStyle.foregroundBuilder and ButtonStyle.backgroundBuilder (flutter/flutter#142762) 2024-02-01 32242716+ricardoamador@users.noreply.github.com Use proto name for emulator version and show cipd package version (flutter/flutter#142262) 2024-02-01 xilaizhang@google.com [github actions] ping actor of workflow on cherry pick pr creation (flutter/flutter#142676) 2024-02-01 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#142590) 2024-02-01 nathan.wilson1232@gmail.com Implement `switch` expressions in `lib/src/material/` (flutter/flutter#142634) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9beb7e82e081 to dd4c79a6c864 (1 revision) (flutter/flutter#142749) 2024-02-01 pateltirth454@gmail.com Write Tests for API Example of `form.0.dart` (flutter/flutter#142635) 2024-02-01 polinach@google.com Make leak_tracking bots sticked to the left even if bot thinks they are non-flacky. (flutter/flutter#142744) 2024-02-01 15619084+vashworth@users.noreply.github.com Upload DerivedData logs in CI (flutter/flutter#142643) 2024-02-01 magder@google.com Test codesigning xcframeworks in artifacts (flutter/flutter#142666) 2024-02-01 davidmartos96@gmail.com Fix gen_defaults test randomness (flutter/flutter#142743) 2024-02-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Added ButtonStyle.foregroundBuilder and ButtonStyle.backgroundBuilder" (flutter/flutter#142748) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39415c3eed42 to 9beb7e82e081 (5 revisions) (flutter/flutter#142745) 2024-02-01 magder@google.com Remove unused deprecated autoroll mirror-remote flag (flutter/flutter#142738) 2024-02-01 polinach@google.com Fix leaks in tests. (flutter/flutter#142677) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8c43332c6ffc to 39415c3eed42 (1 revision) (flutter/flutter#142740) 2024-02-01 magder@google.com Remove verbose-system-logs on iOS perf tests (flutter/flutter#142739) 2024-02-01 magder@google.com Remove outdated arm64_armv7 check (flutter/flutter#142737) 2024-02-01 62812903+sstasi95@users.noreply.github.com fix CupertinoTabView's Android back button handling with PopScope (flutter/flutter#141604) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68943afd62d1 to 8c43332c6ffc (8 revisions) (flutter/flutter#142726) 2024-02-01 christopherfujino@gmail.com Unpin test (flutter/flutter#141427) ...

DanTup · 2024-02-13T11:51:12Z

@christopherfujino @bkonyi what's the current status of VM service 13/14? I was just trying to use DDS as a path dependency in Flutter and noticed that Flutter's vm_service dependency has been bumped to v14 here, but DDS in the SDK repo was put back to down to 13.

Was it an error that Flutter went up to 14? If not, when will DDS also use 14?

derekxu16 · 2024-02-13T17:38:34Z

The vm_service constraint of DDS in the SDK was accidentally set back to ^13.0.0. I'm working on publishing a new version of DDS that accepts vm_service: ^14.0.0.

derekxu16 · 2024-02-13T18:25:11Z

Published.

https://pub.dev/packages/dds/versions/3.2.0

christopherfujino force-pushed the unpin-test branch from 7785ea8 to c534c3d Compare January 12, 2024 18:35

christopherfujino marked this pull request as ready for review January 12, 2024 18:37

christopherfujino force-pushed the unpin-test branch from c534c3d to 6a284fc Compare January 12, 2024 22:51

christopherfujino requested review from bkonyi and derekxu16 January 12, 2024 22:52

This was referenced Jan 19, 2024

Golden file testing for flutter/flutter is unreliable #141880

Closed

Revert "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#140101)" #141814

Merged

christopherfujino mentioned this pull request Jan 31, 2024

Unpin test, test_api and test_core in flutter. #140169

Closed

christopherfujino force-pushed the unpin-test branch from 6a284fc to 2552bb6 Compare February 1, 2024 02:30

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

a803333 Unpin test (flutter/flutter#141427)

c6ad31d

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Flutter from e02e2079bea7 to b209125d11af (29 revisions) flutter/packages#6040

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

a803333 Unpin test (flutter/flutter#141427)

4591a98

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Flutter from e02e2079bea7 to ac7879e2aa6d (30 revisions) flutter/packages#6041

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

a803333 Unpin test (flutter/flutter#141427)

7c844be

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Manual roll Flutter from e02e2079bea7 to ac7879e2aa6d (30 revisions) flutter/packages#6042

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

a803333 Unpin test (flutter/flutter#141427)

dc395d9

engine-flutter-autoroll mentioned this pull request Feb 3, 2024

Roll Flutter from e02e2079bea7 to f6fb563b15be (42 revisions) flutter/packages#6045

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2024

a803333 Unpin test (flutter/flutter#141427)

6897112

engine-flutter-autoroll mentioned this pull request Feb 3, 2024

Roll Flutter from e02e2079bea7 to f6fb563b15be (42 revisions) flutter/packages#6046

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2024

a803333 Unpin test (flutter/flutter#141427)

68fa599

engine-flutter-autoroll mentioned this pull request Feb 4, 2024

Roll Flutter from e02e2079bea7 to f8a77225f360 (45 revisions) flutter/packages#6047

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2024

a803333 Unpin test (flutter/flutter#141427)

a637b83

engine-flutter-autoroll mentioned this pull request Feb 4, 2024

Roll Flutter from e02e2079bea7 to f8a77225f360 (45 revisions) flutter/packages#6048

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2024

a803333 Unpin test (flutter/flutter#141427)

be1d17a

engine-flutter-autoroll mentioned this pull request Feb 5, 2024

Roll Flutter from e02e2079bea7 to 0b5cd5073a3b (46 revisions) flutter/packages#6052

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024

a803333 Unpin test (flutter/flutter#141427)

04342fa

engine-flutter-autoroll mentioned this pull request Feb 5, 2024

Manual roll Flutter from e02e2079bea7 to 0b5cd5073a3b (46 revisions) flutter/packages#6053

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024

a803333 Unpin test (flutter/flutter#141427)

423cd20

engine-flutter-autoroll mentioned this pull request Feb 5, 2024

Roll Flutter from e02e2079bea7 to 0b5cd5073a3b (46 revisions) flutter/packages#6054

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024

a803333 Unpin test (flutter/flutter#141427)

25d0d70

engine-flutter-autoroll mentioned this pull request Feb 5, 2024

Roll Flutter from e02e2079bea7 to cbc18b2c51ca (47 revisions) flutter/packages#6055

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024

a803333 Unpin test (flutter/flutter#141427)

8675e54

darshankawar mentioned this pull request Mar 7, 2024

Outdated test_api in sdk package integration_test is incompatible with test package from dart #144694

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

a803333 Unpin test (flutter/flutter#141427)

b13d05c

Unpin test #141427

Unpin test #141427

Uh oh!

Conversation

christopherfujino commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christopherfujino commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

derekxu16 commented Jan 12, 2024

Uh oh!

christopherfujino commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christopherfujino commented Jan 12, 2024

Uh oh!

derekxu16 commented Jan 15, 2024

Uh oh!

DanTup commented Jan 15, 2024

Uh oh!

derekxu16 commented Jan 15, 2024

Uh oh!

christopherfujino commented Jan 16, 2024

Uh oh!

kenzieschmoll commented Jan 16, 2024

Uh oh!

derekxu16 commented Jan 16, 2024

Uh oh!

kenzieschmoll commented Jan 16, 2024

Uh oh!

derekxu16 commented Jan 25, 2024

Uh oh!

christopherfujino commented Jan 25, 2024

Uh oh!

DanTup commented Feb 13, 2024

Uh oh!

derekxu16 commented Feb 13, 2024

Uh oh!

derekxu16 commented Feb 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

christopherfujino commented Jan 12, 2024 •

edited

Loading

christopherfujino commented Jan 12, 2024 •

edited

Loading

christopherfujino commented Jan 12, 2024 •

edited

Loading