-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Update ToggleButtons, ExpansionPanel, and ExpandIcon tests for Material 3
#141868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
…sts for Material 3 (flutter/flutter#141868)
…sts for Material 3 (flutter/flutter#141868)
…sts for Material 3 (flutter/flutter#141868)
flutter/flutter@5dea6b9...3ee8ff2 2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40c5e9ce6596 to c49989292fc1 (1 revision) (flutter/flutter#141966) 2024-01-22 engine-flutter-autoroll@skia.org Roll Packages from 129e08c to e4cbf23 (11 revisions) (flutter/flutter#141962) 2024-01-22 sstrickl@google.com Mark defaultTargetPlatform as constant for non-debug non-web builds. (flutter/flutter#141105) 2024-01-22 tessertaha@gmail.com Fix `shape` and `collapsedShape` isn't applied to `ExpansionTile`'s splash ink (flutter/flutter#141777) 2024-01-22 dacoharkes@google.com Reapply "Native assets: roll deps" (#141748) (flutter/flutter#141864) 2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11c585f48b77 to 40c5e9ce6596 (1 revision) (flutter/flutter#141956) 2024-01-22 tessertaha@gmail.com Update `ToggleButtons`, `ExpansionPanel`, and `ExpandIcon` tests for Material 3 (flutter/flutter#141868) 2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from c485c574fb1d to 11c585f48b77 (1 revision) (flutter/flutter#141952) 2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7b207d5a1fe to c485c574fb1d (1 revision) (flutter/flutter#141951) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Updated unit tests for
ToggleButtons,ExpansionPanel, andExpandIconto have M2 and M3 versions.More info in #139076
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.