Fix `shape` and `collapsedShape` isn't applied to `ExpansionTile`'s splash ink #141777

TahaTesser · 2024-01-18T14:56:18Z

This updates the previous attempt #135855 and removes the complications when testing M3 ink sparkle effect.
Thanks to this PR by @Piinks

fixes ExpansionTile InkSplash doesn't respect Shape's borderRadius
fixes ExpansionTile.backgroundColor & ExpansionTile.collapsedBackgroundColor removes splash effect

Code sample

expand to view the code sample

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return const Scaffold(
      body: Center(
          child: Padding(
        padding: EdgeInsets.symmetric(horizontal: 24.0),
        child: ExpansionTile(
          collapsedBackgroundColor: Color(0x25ff0000),
          backgroundColor: Color(0x250000ff),
          collapsedShape: RoundedRectangleBorder(
            borderRadius: BorderRadius.all(Radius.circular(30.0)),
            side: BorderSide(color: Colors.black, width: 2.0),
          ),
          shape: RoundedRectangleBorder(
            borderRadius: BorderRadius.all(Radius.circular(30.0)),
            side: BorderSide(color: Colors.black, width: 2.0),
          ),
          clipBehavior: Clip.hardEdge,
          title: Text('Expansion Tile'),
          children: <Widget>[
            FlutterLogo(size: 50),
            FlutterLogo(size: 50),
            FlutterLogo(size: 50),
            FlutterLogo(size: 50),

          ],
        ),
      )),
    );
  }
}

Before

After

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-01-18T16:25:13Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #141777 at sha 8f86887c4ba5fb31aa70c828e4590bf2dfb58a87

packages/flutter/lib/src/material/expansion_tile.dart

flutter-dashboard · 2024-01-19T11:53:17Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #141777 at sha 0c2c8cac0bfc8d1b7f6d3fdaeecb33418caa584b

packages/flutter/lib/src/material/expansion_tile.dart

HansMuller

LGTM

LucasMatheusDev

good job

…plash ink

flutter-dashboard · 2024-01-22T10:35:36Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #141777 at sha 3996f23

…ile`'s splash ink (flutter/flutter#141777)

flutter/flutter@5dea6b9...3ee8ff2 2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40c5e9ce6596 to c49989292fc1 (1 revision) (flutter/flutter#141966) 2024-01-22 engine-flutter-autoroll@skia.org Roll Packages from 129e08c to e4cbf23 (11 revisions) (flutter/flutter#141962) 2024-01-22 sstrickl@google.com Mark defaultTargetPlatform as constant for non-debug non-web builds. (flutter/flutter#141105) 2024-01-22 tessertaha@gmail.com Fix `shape` and `collapsedShape` isn't applied to `ExpansionTile`'s splash ink (flutter/flutter#141777) 2024-01-22 dacoharkes@google.com Reapply "Native assets: roll deps" (#141748) (flutter/flutter#141864) 2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11c585f48b77 to 40c5e9ce6596 (1 revision) (flutter/flutter#141956) 2024-01-22 tessertaha@gmail.com Update `ToggleButtons`, `ExpansionPanel`, and `ExpandIcon` tests for Material 3 (flutter/flutter#141868) 2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from c485c574fb1d to 11c585f48b77 (1 revision) (flutter/flutter#141952) 2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7b207d5a1fe to c485c574fb1d (1 revision) (flutter/flutter#141951) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jan 18, 2024

TahaTesser marked this pull request as ready for review January 18, 2024 16:24

TahaTesser requested review from HansMuller and Piinks January 18, 2024 16:24

flutter-dashboard bot added the will affect goldens Changes to golden files label Jan 18, 2024

HansMuller reviewed Jan 18, 2024

View reviewed changes

packages/flutter/lib/src/material/expansion_tile.dart Outdated Show resolved Hide resolved

TahaTesser requested a review from HansMuller January 19, 2024 11:49

HansMuller reviewed Jan 19, 2024

View reviewed changes

packages/flutter/lib/src/material/expansion_tile.dart Outdated Show resolved Hide resolved

HansMuller approved these changes Jan 19, 2024

View reviewed changes

LucasMatheusDev reviewed Jan 21, 2024

View reviewed changes

TahaTesser added 2 commits January 22, 2024 12:04

Fix shape and collapsedShape isn't applied to ExpansionTile's s…

9690255

…plash ink

Update default clip behavior and add tests

3996f23

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2024

auto-submit bot merged commit 9574d58 into flutter:master Jan 22, 2024

TahaTesser deleted the expansion_tile_shape branch January 22, 2024 11:15

engine-flutter-autoroll mentioned this pull request Jan 22, 2024

Roll Flutter from 5dea6b994e8f to 7ca4b7b86b9d (7 revisions) flutter/packages#5953

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2024

9574d58 Fix shape and collapsedShape isn't applied to `ExpansionT…

0f9fc56

…ile`'s splash ink (flutter/flutter#141777)

engine-flutter-autoroll mentioned this pull request Jan 22, 2024

Roll Flutter from 5dea6b994e8f to bfa245fa3485 (8 revisions) flutter/packages#5954

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2024

9574d58 Fix shape and collapsedShape isn't applied to `ExpansionT…

dc71778

…ile`'s splash ink (flutter/flutter#141777)

engine-flutter-autoroll mentioned this pull request Jan 22, 2024

Roll Flutter from 5dea6b994e8f to 3ee8ff287a6e (9 revisions) flutter/packages#5955

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2024

9574d58 Fix shape and collapsedShape isn't applied to `ExpansionT…

717f706

…ile`'s splash ink (flutter/flutter#141777)

HansMuller mentioned this pull request Jan 26, 2024

Flutter Framework Team: Notable Commits #121415

Closed

TahaTesser mentioned this pull request Feb 23, 2024

Add the ability to clip shapes other than RoundedRectangle in ExpansionTile #136621

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix `shape` and `collapsedShape` isn't applied to `ExpansionTile`'s splash ink #141777

Fix `shape` and `collapsedShape` isn't applied to `ExpansionTile`'s splash ink #141777

Uh oh!

TahaTesser commented Jan 18, 2024 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Jan 18, 2024

Uh oh!

Uh oh!

flutter-dashboard bot commented Jan 19, 2024

Uh oh!

Uh oh!

HansMuller left a comment

Uh oh!

LucasMatheusDev left a comment

Uh oh!

flutter-dashboard bot commented Jan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix shape and collapsedShape isn't applied to ExpansionTile's splash ink #141777

Fix shape and collapsedShape isn't applied to ExpansionTile's splash ink #141777

Uh oh!

Conversation

TahaTesser commented Jan 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code sample

Before

After

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jan 18, 2024

Uh oh!

Uh oh!

flutter-dashboard bot commented Jan 19, 2024

Uh oh!

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

LucasMatheusDev left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Jan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix `shape` and `collapsedShape` isn't applied to `ExpansionTile`'s splash ink #141777

Fix `shape` and `collapsedShape` isn't applied to `ExpansionTile`'s splash ink #141777

TahaTesser commented Jan 18, 2024 •

edited

Loading