Fix mechanism to pass flag for leak tracking. #141226

polina-c · 2024-01-10T00:40:48Z

No description provided.

flutter-dashboard · 2024-01-10T18:54:48Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

keyonghan · 2024-01-10T19:07:30Z

packages/flutter/test/flutter_test_config.dart

+    // to provide a way to detect if the env variable is passed as expected on bots, that is not obvious.
+    // Sometimes the bot's environment contains `LEAK_TRACKING=true` but the value is not passed to the test.
+    // https://github.com/dart-lang/sdk/issues/54568
+    debugPrint('Leak tracking is enabled.');


Could you validate this by export LEAK_TRACKING=true, and run the test locally? If validated, then no need to add this print.

Nope, it does not work locally:

polinach-macbookpro3:flutter polinach$ echo $LEAK_TRACKING true polinach-macbookpro3:flutter polinach$ flutter test /Users/polinach/_/flutter_dev/packages/flutter/test/widgets/page_view_test.dart 00:03 +33: All tests passed! polinach-macbookpro3:flutter polinach$ flutter test --dart-define LEAK_TRACKING=true /Users/polinach/_/flutter_dev/packages/flutter/test/widgets/page_view_test.dart 00:01 +0: loading /Users/polinach/_/flutter_dev/packages/flutter/test/widgets/page_view_test.dart Leak tracking is enabled.

But it works on bots

That's why I filed a bug: dart-lang/sdk#54568

Refiled to flutter: #141299

Hum, weird, it works for me locally with your patch const bool.fromEnvironment('LEAK_TRACKING') || (bool.tryParse(Platform.environment['LEAK_TRACKING'] ?? '') ?? false);:

keyonghan-macbookpro2:test keyonghan$ echo $LEAK_TRACKING true keyonghan-macbookpro2:test keyonghan$ flutter test /Users/keyonghan/Documents/work/flutter/packages/flutter/test/widgets/page_view_test.dart Changing current working directory to: /Users/keyonghan/Documents/work/flutter/packages/flutter 00:01 +0: loading /Users/keyonghan/Documents/work/flutter/packages/flutter/test/widgets/page_view_test.dart Leak tracking is enabled.

Weird

Added version information to the bug.

Nit: add a TODO to remove after the reference issue is fixed.

@stuartmorgan found what is wrong: #141299

Removed print.

keyonghan

LGTM with nit.

keyonghan · 2024-01-10T21:08:32Z

packages/flutter/test/flutter_test_config.dart

+    // to provide a way to detect if the env variable is passed as expected on bots, that is not obvious.
+    // Sometimes the bot's environment contains `LEAK_TRACKING=true` but the value is not passed to the test.
+    // https://github.com/dart-lang/sdk/issues/54568
+    debugPrint('Leak tracking is enabled.');


Nit: add a TODO to remove after the reference issue is fixed.

…r#141226)

flutter/flutter@b840a60...9f2e681 2024-01-11 dnfield@google.com [Tool][Impeller] Make impellerc produce Vulkan and GLES shaders for Android. (flutter/flutter#140976) 2024-01-11 engine-flutter-autoroll@skia.org Roll Packages from 378e700 to 0744fe6 (6 revisions) (flutter/flutter#141378) 2024-01-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from efd0eb62f4aa to ecdaed76f284 (1 revision) (flutter/flutter#141359) 2024-01-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from ade9f18fa008 to efd0eb62f4aa (2 revisions) (flutter/flutter#141356) 2024-01-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 42e3e0236112 to ade9f18fa008 (2 revisions) (flutter/flutter#141337) 2024-01-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from f39f5ca18328 to 42e3e0236112 (2 revisions) (flutter/flutter#141327) 2024-01-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 431d64dbb4b8 to f39f5ca18328 (1 revision) (flutter/flutter#141322) 2024-01-11 katelovett@google.com Add dart fix support to flutter_driver (flutter/flutter#141300) 2024-01-11 polinach@google.com Fix a leak. (flutter/flutter#141312) 2024-01-10 katelovett@google.com Add covariants to reduce subclass casts in 2D APIs (flutter/flutter#141318) 2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from a045134c910d to 431d64dbb4b8 (2 revisions) (flutter/flutter#141316) 2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6810c9a57460 to a045134c910d (2 revisions) (flutter/flutter#141313) 2024-01-10 jmccandless@google.com Call onPopInvoked when pages API is used (flutter/flutter#141221) 2024-01-10 polinach@google.com Fix mechanism to pass flag for leak tracking. (flutter/flutter#141226) 2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5d252831e62c to 6810c9a57460 (2 revisions) (flutter/flutter#141308) 2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6cb256fc4985 to 5d252831e62c (1 revision) (flutter/flutter#141302) 2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 52aedc6c9153 to 6cb256fc4985 (1 revision) (flutter/flutter#141297) 2024-01-10 polinach@google.com Improve testing for leak tracking. (flutter/flutter#140553) 2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from d1a2007a28b4 to 52aedc6c9153 (2 revisions) (flutter/flutter#141291) 2024-01-10 christopherfujino@gmail.com [flutter_tools] fix flutter create -t skeleton (flutter/flutter#141233) 2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from b361a60ae224 to d1a2007a28b4 (1 revision) (flutter/flutter#141285) 2024-01-10 derekx@google.com Unpin package:vm_service (flutter/flutter#141279) 2024-01-10 stuartmorgan@google.com Collapse pubspec.lock by default (flutter/flutter#141282) 2024-01-10 engine-flutter-autoroll@skia.org Roll Packages from 09205ca to 378e700 (2 revisions) (flutter/flutter#141275) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

polina-c added 2 commits January 9, 2024 16:38

Update flutter_test_config.dart

763141c

Update .ci.yaml

f087b12

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 10, 2024

polina-c and others added 12 commits January 9, 2024 17:35

Update flutter_test_config.dart

b0bd233

Update flutter_test_config.dart

cb967bb

Merge branch 'master' of https://github.com/flutter/flutter into debug

798da52

Update flutter_test_config.dart

6e73c0c

Update flutter_test_config.dart

243b57e

Update flutter_test_config.dart

c93f37f

Update flutter_test_config.dart

cf23c6a

Merge branch 'master' into debug

1fb8245

Update flutter_test_config.dart

e4a1bf1

Merge branch 'debug' of github.com:polina-c/flutter into debug

d0a8c12

Update .ci.yaml

5317b97

Update flutter_test_config.dart

05e0115

polina-c marked this pull request as ready for review January 10, 2024 18:52

polina-c changed the title ~~[Not for merge] Debug leak tracking~~ Fix mechanism to pass flag for leak tracking. Jan 10, 2024

polina-c requested review from goderbauer and keyonghan January 10, 2024 18:59

keyonghan reviewed Jan 10, 2024

View reviewed changes

polina-c added 2 commits January 10, 2024 11:37

Update flutter_test_config.dart

af0443d

Merge branch 'master' of https://github.com/flutter/flutter into debug

5347de3

polina-c requested a review from keyonghan January 10, 2024 19:44

keyonghan approved these changes Jan 10, 2024

View reviewed changes

polina-c and others added 2 commits January 10, 2024 13:13

Update flutter_test_config.dart

3df6917

Merge branch 'master' into debug

5e6f7ff

polina-c added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jan 10, 2024

Update flutter_test_config.dart

ee8dde5

Merge branch 'debug' of github.com:polina-c/flutter into debug

1bf03ea

polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 10, 2024

auto-submit bot merged commit 420b15a into flutter:master Jan 10, 2024

polina-c deleted the debug branch January 10, 2024 22:09

engine-flutter-autoroll mentioned this pull request Jan 11, 2024

Roll Flutter from b840a60d7d3f to 2216a78095fc (22 revisions) flutter/packages#5866

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 11, 2024

420b15a Fix mechanism to pass flag for leak tracking. (flutter/flutte…

3f065d1

…r#141226)

engine-flutter-autoroll mentioned this pull request Jan 11, 2024

Roll Flutter from b840a60d7d3f to f5fb61b953a6 (23 revisions) flutter/packages#5868

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 11, 2024

420b15a Fix mechanism to pass flag for leak tracking. (flutter/flutte…

4a86bd0

…r#141226)

engine-flutter-autoroll mentioned this pull request Jan 11, 2024

Roll Flutter from b840a60d7d3f to 9f2e681e7be6 (24 revisions) flutter/packages#5871

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 11, 2024

420b15a Fix mechanism to pass flag for leak tracking. (flutter/flutte…

47d45f5

…r#141226)

Fix mechanism to pass flag for leak tracking. #141226

Fix mechanism to pass flag for leak tracking. #141226

Uh oh!

Conversation

polina-c commented Jan 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Jan 10, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keyonghan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

polina-c commented Jan 10, 2024 •

edited

Loading