Skip to content

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Dec 23, 2023

Also this PR updates settings to track all not disposed if leak tracking is on.

@polina-c polina-c changed the title Add testing for ignored test helpers. Improve testing for leak trracking. Jan 7, 2024
@polina-c polina-c changed the title Improve testing for leak trracking. Improve testing for leak tracking. Jan 7, 2024
@polina-c polina-c marked this pull request as ready for review January 9, 2024 22:13
@polina-c polina-c requested a review from kenzieschmoll January 9, 2024 22:14
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 10, 2024
@polina-c polina-c merged commit 34f1f5f into flutter:master Jan 10, 2024
@polina-c polina-c deleted the testHelpers branch January 10, 2024 19:04
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 11, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 11, 2024
flutter/flutter@b840a60...9f2e681

2024-01-11 dnfield@google.com [Tool][Impeller] Make impellerc produce Vulkan and GLES shaders for Android. (flutter/flutter#140976)
2024-01-11 engine-flutter-autoroll@skia.org Roll Packages from 378e700 to 0744fe6 (6 revisions) (flutter/flutter#141378)
2024-01-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from efd0eb62f4aa to ecdaed76f284 (1 revision) (flutter/flutter#141359)
2024-01-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from ade9f18fa008 to efd0eb62f4aa (2 revisions) (flutter/flutter#141356)
2024-01-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 42e3e0236112 to ade9f18fa008 (2 revisions) (flutter/flutter#141337)
2024-01-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from f39f5ca18328 to 42e3e0236112 (2 revisions) (flutter/flutter#141327)
2024-01-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 431d64dbb4b8 to f39f5ca18328 (1 revision) (flutter/flutter#141322)
2024-01-11 katelovett@google.com Add dart fix support to flutter_driver (flutter/flutter#141300)
2024-01-11 polinach@google.com Fix a leak. (flutter/flutter#141312)
2024-01-10 katelovett@google.com Add covariants to reduce subclass casts in 2D APIs (flutter/flutter#141318)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from a045134c910d to 431d64dbb4b8 (2 revisions) (flutter/flutter#141316)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6810c9a57460 to a045134c910d (2 revisions) (flutter/flutter#141313)
2024-01-10 jmccandless@google.com Call onPopInvoked when pages API is used (flutter/flutter#141221)
2024-01-10 polinach@google.com Fix mechanism to pass flag for leak tracking. (flutter/flutter#141226)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5d252831e62c to 6810c9a57460 (2 revisions) (flutter/flutter#141308)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6cb256fc4985 to 5d252831e62c (1 revision) (flutter/flutter#141302)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 52aedc6c9153 to 6cb256fc4985 (1 revision) (flutter/flutter#141297)
2024-01-10 polinach@google.com Improve testing for leak tracking. (flutter/flutter#140553)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from d1a2007a28b4 to 52aedc6c9153 (2 revisions) (flutter/flutter#141291)
2024-01-10 christopherfujino@gmail.com [flutter_tools] fix flutter create -t skeleton (flutter/flutter#141233)
2024-01-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from b361a60ae224 to d1a2007a28b4 (1 revision) (flutter/flutter#141285)
2024-01-10 derekx@google.com Unpin package:vm_service (flutter/flutter#141279)
2024-01-10 stuartmorgan@google.com Collapse pubspec.lock by default (flutter/flutter#141282)
2024-01-10 engine-flutter-autoroll@skia.org Roll Packages from 09205ca to 378e700 (2 revisions) (flutter/flutter#141275)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants