Prepare for dynamically sized views - pt. 2 #139079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 27, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 28, 2023
Manual roll requested by tarrinneal@google.com flutter/flutter@b5f163a...6bf3ccd 2023-11-27 christopherfujino@gmail.com [flutter_tools] fix instructions to disable CLI animations (flutter/flutter#139094) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9fe149249957 to 900ce09b08b2 (3 revisions) (flutter/flutter#139095) 2023-11-27 jonahwilliams@google.com Wide gamut and platform view integration test. (flutter/flutter#138837) 2023-11-27 tessertaha@gmail.com Add ability to customize `NavigationBar` indicator overlay and fix indicator shape for the overlay (flutter/flutter#138901) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc57ace8e2e7 to 9fe149249957 (1 revision) (flutter/flutter#139077) 2023-11-27 andrewrkolos@gmail.com Add type validation to non-template .arb file parsing logic (flutter/flutter#139035) 2023-11-27 barpac02@gmail.com Update Android app project template to apply Kotlin Gradle plugin declaratively (flutter/flutter#139006) 2023-11-27 goderbauer@google.com Prepare for dynamically sized views - pt. 2 (flutter/flutter#139079) 2023-11-27 goderbauer@google.com Prepare for dynamically sized views (flutter/flutter#138565) 2023-11-27 JaspervanRiet@users.noreply.github.com Write tests for API examples of BottomNavigationBar and IconButton (flutter/flutter#138188) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9b610ecda771 to cc57ace8e2e7 (2 revisions) (flutter/flutter#139072) 2023-11-27 stuartmorgan@google.com Give an actionable error message when a Pod requires a higher minimum OS version (flutter/flutter#138097) 2023-11-27 reidbaker@google.com Edge case on flutter/flutter/issues/135402 with test (flutter/flutter#138814) 2023-11-27 engine-flutter-autoroll@skia.org Roll Packages from 97f0a40 to e774e88 (4 revisions) (flutter/flutter#139066) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f499ecea657 to 9b610ecda771 (1 revision) (flutter/flutter#139063) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 61233cde4bb3 to 6f499ecea657 (2 revisions) (flutter/flutter#139051) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 292a92166a94 to 61233cde4bb3 (1 revision) (flutter/flutter#139041) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from ebebb25aaa46 to 292a92166a94 (3 revisions) (flutter/flutter#139037) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from eb18add9ebc5 to ebebb25aaa46 (2 revisions) (flutter/flutter#139034) 2023-11-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 77432202f766 to eb18add9ebc5 (1 revision) (flutter/flutter#139007) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
Towards flutter#134501. Required to roll flutter/engine#48090 into the framework. Two new subclasses of FlutterView were added recently for testing (in flutter#138849) that I missed in my previous PR (flutter#138565).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #134501.
Required to roll flutter/engine#48090 into the framework.
Two new subclasses of FlutterView were added recently for testing (in #138849) that I missed in my previous PR (#138565).