Wide gamut and platform view integration test. #138837

jonahwilliams · 2023-11-21T19:23:02Z

In flutter/engine#48190 I discovered that overlay surfaces were not constructed with wide gamut settings. This adds a test that will fail until this is fixed.

dev/devicelab/lib/tasks/integration_tests.dart

jonahwilliams · 2023-11-21T19:30:17Z

Running at ToT you will get a validation error:

gaaclarke

Nice, thanks for the quick followup. Here are a couple of questions/comments.

gaaclarke · 2023-11-21T19:26:58Z

dev/integration_tests/flutter_gallery/ios/Runner.xcodeproj/project.pbxproj

 			baseConfigurationReference = 9740EEB21CF90195004384FC /* Debug.xcconfig */;
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
+				DEVELOPMENT_TEAM = S8QB4VV633;


I'd just revert this file. You don't want to check this in and the other stuff is just formatting.

gaaclarke · 2023-11-21T19:28:48Z

dev/integration_tests/wide_gamut_test/ios/Flutter/AppFrameworkInfo.plist

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>


I don't think you need to add all these files. flutter create --no-overwrite is used.

gaaclarke · 2023-11-21T19:29:50Z

dev/integration_tests/wide_gamut_test/ios/Runner/DummyPlatformView.swift

+//
+//  DummyPlatformView.swift
+//  Runner
+//
+//  Created by Jonah Williams on 11/21/23.
+//


Fix copyright

gaaclarke · 2023-11-21T19:32:57Z

dev/integration_tests/wide_gamut_test/ios/Runner/DummyPlatformView.swift

+}
+
+class SolidColorView: UIView {
+  private var _started: Bool = false;


Above you don't use the underscore prefix. I don't think its required in the swift style.

dev/integration_tests/wide_gamut_test/ios/Runner/DummyPlatformView.swift

…ng-Header.h

gaaclarke

LGTM modulo 2 swift notes

gaaclarke · 2023-11-21T21:13:22Z

dev/integration_tests/wide_gamut_test/ios/Runner/AppDelegate.swift

+  ) -> Bool {
+    GeneratedPluginRegistrant.register(with: self)
+
+      weak var registrar = self.registrar(forPlugin: "plugin-name")


I don't think you need weak here.

gaaclarke · 2023-11-21T21:17:37Z

dev/integration_tests/wide_gamut_test/ios/Runner/DummyPlatformView.swift

+
+
+class FLNativeView: NSObject, FlutterPlatformView {
+    private var _view: UIView


Same note here about the underscore.

…er#138837)

jonahwilliams · 2023-11-27T22:23:18Z

It looks like I reverted too many files

This reverts commit 389ebd4.

Reverts #138837 Initiated by: jonahwilliams This change reverts the following previous change: Original Description: In flutter/engine#48190 I discovered that overlay surfaces were not constructed with wide gamut settings. This adds a test that will fail until this is fixed.

Reland of #138837 I reverted too many config files, the app needed the pbx project file in order to find the new class I added. Instead, just put the new platform view in the app delegate so it builds.

Manual roll requested by tarrinneal@google.com flutter/flutter@b5f163a...6bf3ccd 2023-11-27 christopherfujino@gmail.com [flutter_tools] fix instructions to disable CLI animations (flutter/flutter#139094) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9fe149249957 to 900ce09b08b2 (3 revisions) (flutter/flutter#139095) 2023-11-27 jonahwilliams@google.com Wide gamut and platform view integration test. (flutter/flutter#138837) 2023-11-27 tessertaha@gmail.com Add ability to customize `NavigationBar` indicator overlay and fix indicator shape for the overlay (flutter/flutter#138901) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc57ace8e2e7 to 9fe149249957 (1 revision) (flutter/flutter#139077) 2023-11-27 andrewrkolos@gmail.com Add type validation to non-template .arb file parsing logic (flutter/flutter#139035) 2023-11-27 barpac02@gmail.com Update Android app project template to apply Kotlin Gradle plugin declaratively (flutter/flutter#139006) 2023-11-27 goderbauer@google.com Prepare for dynamically sized views - pt. 2 (flutter/flutter#139079) 2023-11-27 goderbauer@google.com Prepare for dynamically sized views (flutter/flutter#138565) 2023-11-27 JaspervanRiet@users.noreply.github.com Write tests for API examples of BottomNavigationBar and IconButton (flutter/flutter#138188) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9b610ecda771 to cc57ace8e2e7 (2 revisions) (flutter/flutter#139072) 2023-11-27 stuartmorgan@google.com Give an actionable error message when a Pod requires a higher minimum OS version (flutter/flutter#138097) 2023-11-27 reidbaker@google.com Edge case on flutter/flutter/issues/135402 with test (flutter/flutter#138814) 2023-11-27 engine-flutter-autoroll@skia.org Roll Packages from 97f0a40 to e774e88 (4 revisions) (flutter/flutter#139066) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f499ecea657 to 9b610ecda771 (1 revision) (flutter/flutter#139063) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 61233cde4bb3 to 6f499ecea657 (2 revisions) (flutter/flutter#139051) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 292a92166a94 to 61233cde4bb3 (1 revision) (flutter/flutter#139041) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from ebebb25aaa46 to 292a92166a94 (3 revisions) (flutter/flutter#139037) 2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from eb18add9ebc5 to ebebb25aaa46 (2 revisions) (flutter/flutter#139034) 2023-11-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 77432202f766 to eb18add9ebc5 (1 revision) (flutter/flutter#139007) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Reverts #139101 Initiated by: jonahwilliams This change reverts the following previous change: Original Description: Reland of #138837 I reverted too many config files, the app needed the pbx project file in order to find the new class I added. Instead, just put the new platform view in the app delegate so it builds.

In flutter/engine#48190 I discovered that overlay surfaces were not constructed with wide gamut settings. This adds a test that will fail until this is fixed.

) Reverts flutter#138837 Initiated by: jonahwilliams This change reverts the following previous change: Original Description: In flutter/engine#48190 I discovered that overlay surfaces were not constructed with wide gamut settings. This adds a test that will fail until this is fixed.

Reland of flutter#138837 I reverted too many config files, the app needed the pbx project file in order to find the new class I added. Instead, just put the new platform view in the app delegate so it builds.

Reverts flutter#139101 Initiated by: jonahwilliams This change reverts the following previous change: Original Description: Reland of flutter#138837 I reverted too many config files, the app needed the pbx project file in order to find the new class I added. Instead, just put the new platform view in the app delegate so it builds.

…er#138837)

Wide gamut and platform view integration test.

539ad60

jonahwilliams commented Nov 21, 2023

View reviewed changes

dev/devicelab/lib/tasks/integration_tests.dart Show resolved Hide resolved

++

e7b40dc

jonahwilliams requested a review from gaaclarke November 21, 2023 19:23

jonahwilliams mentioned this pull request Nov 21, 2023

[Impeller] Ensure that overlay surfaces are constructed with wide gamut settings. flutter/engine#48190

Merged

gaaclarke reviewed Nov 21, 2023

View reviewed changes

jonahwilliams added 4 commits November 21, 2023 12:23

delete unused files, fix copyright.

fc48844

Delete dev/integration_tests/wide_gamut_test/ios/Runner/Runner-Bridgi…

2aeda35

…ng-Header.h

revert

8253bce

++

06c507c

gaaclarke approved these changes Nov 21, 2023

View reviewed changes

Jonah Williams added 4 commits November 21, 2023 18:09

Merge branch 'master' into add_platform_view_wide_gamut_test

fbd365a

Update DummyPlatformView.swift

0367698

Update AppDelegate.swift

a9e8eb3

Merge branch 'master' into add_platform_view_wide_gamut_test

48d769c

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 27, 2023

auto-submit bot merged commit 389ebd4 into flutter:master Nov 27, 2023

engine-flutter-autoroll mentioned this pull request Nov 27, 2023

Manual roll Flutter from b5f163a6f276 to 6bf3ccd47d5d (20 revisions) flutter/packages#5495

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 27, 2023

389ebd4 Wide gamut and platform view integration test. (flutter/flutt…

5fed113

…er#138837)

jonahwilliams added the revert Autorevert PR (with "Reason for revert:" comment) label Nov 27, 2023

auto-submit bot mentioned this pull request Nov 27, 2023

Reverts "Wide gamut and platform view integration test." #139100

Merged

auto-submit bot pushed a commit that referenced this pull request Nov 27, 2023

Revert "Wide gamut and platform view integration test. (#138837)"

996c722

This reverts commit 389ebd4.

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Nov 27, 2023

jonahwilliams mentioned this pull request Nov 27, 2023

Reland Add platform view wide gamut test #139101

Merged

auto-submit bot mentioned this pull request Nov 29, 2023

Reverts "Reland Add platform view wide gamut test" #139189

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

389ebd4 Wide gamut and platform view integration test. (flutter/flutt…

537d94f

…er#138837)



		class FLNativeView: NSObject, FlutterPlatformView {
		private var _view: UIView

Wide gamut and platform view integration test. #138837

Wide gamut and platform view integration test. #138837

Uh oh!

Conversation

jonahwilliams commented Nov 21, 2023

Uh oh!

Uh oh!

jonahwilliams commented Nov 21, 2023

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonahwilliams commented Nov 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants