Skip to content

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Sep 29, 2023

Fixes: #135716
leak_tracker is left pinned because future updates are going to be breaking.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Sep 29, 2023
@polina-c polina-c marked this pull request as ready for review September 29, 2023 18:28
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2023
@auto-submit auto-submit bot merged commit 9d9f213 into flutter:master Sep 29, 2023
@polina-c polina-c deleted the upgrade branch September 29, 2023 19:12
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 30, 2023
flutter/flutter@57b5c3c...d3df8f6

2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68fc1a567195 to 01fc3c6624ce (1 revision) (flutter/flutter#135808)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ed733d99cd5 to 68fc1a567195 (1 revision) (flutter/flutter#135807)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d814c69abe26 to 4ed733d99cd5 (1 revision) (flutter/flutter#135801)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from f726438d4d65 to d814c69abe26 (1 revision) (flutter/flutter#135799)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0b96a82cc874 to f726438d4d65 (1 revision) (flutter/flutter#135796)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3a4cab69962 to 0b96a82cc874 (1 revision) (flutter/flutter#135793)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from e719b7957763 to f3a4cab69962 (2 revisions) (flutter/flutter#135792)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8939f9c1f4e4 to e719b7957763 (2 revisions) (flutter/flutter#135789)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6a13607008ed to 8939f9c1f4e4 (1 revision) (flutter/flutter#135788)
2023-09-30 32242716+ricardoamador@users.noreply.github.com Add device ready check (flutter/flutter#135526)
2023-09-30 32242716+ricardoamador@users.noreply.github.com Temporarily disable NexusLowRes, version=29 (flutter/flutter#135785)
2023-09-30 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking #12. (flutter/flutter#135385)
2023-09-30 sokolovskyi.konstantin@gmail.com DraggableScrollableController should dispatch creation in constructor. (flutter/flutter#135423)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d203e349781c to 6a13607008ed (2 revisions) (flutter/flutter#135780)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48973d7f9beb to d203e349781c (5 revisions) (flutter/flutter#135776)
2023-09-29 sokolovskyi.konstantin@gmail.com ViewportOffset should dispatch creation in constructor. (flutter/flutter#135420)
2023-09-29 jacksongardner@google.com Use platform dill from the engine when compiling with dart2wasm. (flutter/flutter#134970)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5fcd78a879b to 48973d7f9beb (5 revisions) (flutter/flutter#135765)
2023-09-29 polinach@google.com Upgrade leak_tracker to fix flackiness. (flutter/flutter#135760)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from c52251a8b2d0 to d5fcd78a879b (2 revisions) (flutter/flutter#135755)
2023-09-29 tessertaha@gmail.com Update `Drawer` tests for M2/M3 (flutter/flutter#135752)
2023-09-29 katelovett@google.com Expose onAttach and onDetach in ScrollController subclasses (flutter/flutter#135721)
2023-09-29 jacksongardner@google.com Update the wasm bootstrap to allow access to the emscripten wrapper to skwasm. (flutter/flutter#135723)
2023-09-29 42216813+eliasyishak@users.noreply.github.com Update logic for getting `Analytics` instance from package:unified_analytics (flutter/flutter#134756)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
Fixes: flutter#135716
leak_tracker is left pinned because future updates are going to be breaking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix flakiness in leak_tracker.

2 participants