Update the wasm bootstrap to allow access to the emscripten wrapper to skwasm. #135723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
yjbanov
approved these changes
Sep 28, 2023
Contributor
Author
|
I went ahead and ran the skwasm benchmarks in presubmit on this change to ensure that the wasm bootstrapper still works properly. I also ran the skwasm benchmarks against the presubmit build of the engine change that this is anticipating (flutter/engine#46388), that way we make sure that everything is still working both before and after the incoming engine change. |
Contributor
|
auto label is removed for flutter/flutter/135723, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 30, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 30, 2023
flutter/flutter@57b5c3c...d3df8f6 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68fc1a567195 to 01fc3c6624ce (1 revision) (flutter/flutter#135808) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ed733d99cd5 to 68fc1a567195 (1 revision) (flutter/flutter#135807) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d814c69abe26 to 4ed733d99cd5 (1 revision) (flutter/flutter#135801) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from f726438d4d65 to d814c69abe26 (1 revision) (flutter/flutter#135799) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0b96a82cc874 to f726438d4d65 (1 revision) (flutter/flutter#135796) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3a4cab69962 to 0b96a82cc874 (1 revision) (flutter/flutter#135793) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from e719b7957763 to f3a4cab69962 (2 revisions) (flutter/flutter#135792) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8939f9c1f4e4 to e719b7957763 (2 revisions) (flutter/flutter#135789) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6a13607008ed to 8939f9c1f4e4 (1 revision) (flutter/flutter#135788) 2023-09-30 32242716+ricardoamador@users.noreply.github.com Add device ready check (flutter/flutter#135526) 2023-09-30 32242716+ricardoamador@users.noreply.github.com Temporarily disable NexusLowRes, version=29 (flutter/flutter#135785) 2023-09-30 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking #12. (flutter/flutter#135385) 2023-09-30 sokolovskyi.konstantin@gmail.com DraggableScrollableController should dispatch creation in constructor. (flutter/flutter#135423) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d203e349781c to 6a13607008ed (2 revisions) (flutter/flutter#135780) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48973d7f9beb to d203e349781c (5 revisions) (flutter/flutter#135776) 2023-09-29 sokolovskyi.konstantin@gmail.com ViewportOffset should dispatch creation in constructor. (flutter/flutter#135420) 2023-09-29 jacksongardner@google.com Use platform dill from the engine when compiling with dart2wasm. (flutter/flutter#134970) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5fcd78a879b to 48973d7f9beb (5 revisions) (flutter/flutter#135765) 2023-09-29 polinach@google.com Upgrade leak_tracker to fix flackiness. (flutter/flutter#135760) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from c52251a8b2d0 to d5fcd78a879b (2 revisions) (flutter/flutter#135755) 2023-09-29 tessertaha@gmail.com Update `Drawer` tests for M2/M3 (flutter/flutter#135752) 2023-09-29 katelovett@google.com Expose onAttach and onDetach in ScrollController subclasses (flutter/flutter#135721) 2023-09-29 jacksongardner@google.com Update the wasm bootstrap to allow access to the emscripten wrapper to skwasm. (flutter/flutter#135723) 2023-09-29 42216813+eliasyishak@users.noreply.github.com Update logic for getting `Analytics` instance from package:unified_analytics (flutter/flutter#134756) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…o skwasm. (flutter#135723) Some upcoming engine changes will bind to a function provided by the emscripten JS wrapper around skwasm, rather than just the wasm module itself. This will make sure not to break the benchmarks when those engine changes land. See flutter/engine#46388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some upcoming engine changes will bind to a function provided by the emscripten JS wrapper around skwasm, rather than just the wasm module itself. This will make sure not to break the benchmarks when those engine changes land. See flutter/engine#46388