Skip to content

Update the infrastructure issue template #133519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 10 commits into from
Aug 30, 2023
Merged

Update the infrastructure issue template #133519

auto-submit merged 10 commits into from
Aug 30, 2023

Conversation

@ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented Aug 29, 2023 •
edited
Loading

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

keyonghan
keyonghan reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows some errors:
https://github.com/flutter/flutter/blob/b23ba6164b4c41d6a07d311856e37ba1844cf346/.github/ISSUE_TEMPLATE/6_infrastructure.yml
Screenshot 2023-08-28 at 7 12 43 PM

@ricardoamador
Copy link
Contributor Author

ricardoamador commented Aug 29, 2023

I believe I have fixed the errors though I could not find a way to render the page to test it. For some reason the github preview just shows me the yml file again and not the rendered form.

@keyonghan
Copy link
Contributor

keyonghan commented Aug 29, 2023

I believe I have fixed the errors though I could not find a way to render the page to test it. For some reason the github preview just shows me the yml file again and not the rendered form.

You can view the rendered form here: https://github.com/flutter/flutter/blob/f862d7ec34753f9047105b0d43a22e9d91a15f71/.github/ISSUE_TEMPLATE/6_infrastructure.yml

keyonghan
keyonghan reviewed Aug 29, 2023
View reviewed changes
@ricardoamador
Copy link
Contributor Author

ricardoamador commented Aug 29, 2023

Eww! That does not look good. Okay let me update it.

@keyonghan
Copy link
Contributor

keyonghan commented Aug 29, 2023

Seems another error with the latest commit:
https://github.com/flutter/flutter/blob/c161de21bf2250e7177848ed3fd12e7604f7ca37/.github/ISSUE_TEMPLATE/6_infrastructure.yml

Screenshot 2023-08-29 at 1 22 17 PM

@ricardoamador ricardoamador marked this pull request as ready for review August 29, 2023 23:13
keyonghan
keyonghan approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoamador ricardoamador changed the title Add an update infra template. Update the infrastructure issue template Aug 30, 2023
@ricardoamador ricardoamador added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 30, 2023
@auto-submit auto-submit bot merged commit 15048a6 into flutter:master Aug 30, 2023
@ricardoamador ricardoamador mentioned this pull request Aug 30, 2023
Closed
1 task
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2023
@engine-flutter-autoroll
15048a6 Update the infrastructure issue template (flutter/flutter#133519
ebe7fad 
)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 31, 2023
@engine-flutter-autoroll
Roll Flutter from 1fe2495 to c175cf8 (30 revisions) (#4825)
17406a3 
flutter/flutter@1fe2495...c175cf8

2023-08-31 15619084+vashworth@users.noreply.github.com Ignore macOS Cocoapods linting failure on DT_TOOLCHAIN_DIR error (flutter/flutter#133588)
2023-08-31 84124091+opxdelwin@users.noreply.github.com `InputDecorationTheme.isCollapsed` doesn't work if `InputDecoration.isCollapsed` is not provided. (flutter/flutter#133189)
2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5156c03344eb to 772d5e996af8 (1 revision) (flutter/flutter#133752)
2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1917fa95ea55 to 5156c03344eb (2 revisions) (flutter/flutter#133745)
2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1f1071d3f5ba to 1917fa95ea55 (2 revisions) (flutter/flutter#133739)
2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from e88b21b6d4e8 to 1f1071d3f5ba (1 revision) (flutter/flutter#133737)
2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0559a733c888 to e88b21b6d4e8 (1 revision) (flutter/flutter#133735)
2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3b75e3de7ef3 to 0559a733c888 (1 revision) (flutter/flutter#133734)
2023-08-31 jonahwilliams@google.com [framework] use ImageFilter for stretch overscroll. (flutter/flutter#133613)
2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73e86369614d to 3b75e3de7ef3 (2 revisions) (flutter/flutter#133724)
2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8f1b77b1ac69 to 73e86369614d (1 revision) (flutter/flutter#133720)
2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from d37cef84d40d to 8f1b77b1ac69 (1 revision) (flutter/flutter#133714)
2023-08-31 polinach@google.com Mark leak in _DraggableScrollableSheetState. (flutter/flutter#133693)
2023-08-30 polinach@google.com Mark routing test as leaking. (flutter/flutter#133697)
2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from b63eee2e31cc to d37cef84d40d (3 revisions) (flutter/flutter#133706)
2023-08-30 polinach@google.com _RawAutocompleteState should dispose _highlightedOptionIndex. (flutter/flutter#133700)
2023-08-30 matanlurey@users.noreply.github.com Forward-fix a test that will break with an engine roll. (flutter/flutter#133619)
2023-08-30 tessertaha@gmail.com Fix `cancelButtonStyle` & `confirmButtonStyle` properties  from `TimePickerTheme`  aren't working (flutter/flutter#132843)
2023-08-30 hans.muller@gmail.com Updated DropdownMenu example and added a test (flutter/flutter#133592)
2023-08-30 tessertaha@gmail.com Add `cancelButtonStyle` & `confirmButtonStyle` to the `DatePickerThemeData` (flutter/flutter#132847)
2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 31d5662dcb53 to b63eee2e31cc (1 revision) (flutter/flutter#133692)
2023-08-30 rmolivares@renzo-olivares.dev Fixing memory leak in EditableTextState (flutter/flutter#131377)
2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69f04bdfe952 to 31d5662dcb53 (14 revisions) (flutter/flutter#133683)
2023-08-30 leroux_bruno@yahoo.fr Expose barrierDismissible in PageRoute constructor (flutter/flutter#133659)
2023-08-30 32242716+ricardoamador@users.noreply.github.com Update the infrastructure issue template (flutter/flutter#133519)
2023-08-30 31859944+LongCatIsLooong@users.noreply.github.com Reland "Remove ImageProvider.load, DecoderCallback and `PaintingBinding.instantiateImageCodec` (#132679) (reverted in #133482) (flutter/flutter#133605)
2023-08-30 engine-flutter-autoroll@skia.org Roll Packages from d7d3150 to 64af59e (4 revisions) (flutter/flutter#133675)
2023-08-30 tessertaha@gmail.com Update & improve `TabBar.labelColor` tests (flutter/flutter#133668)
2023-08-30 zanderso@users.noreply.github.com Bump gradle heap size limits in templates (flutter/flutter#133671)
2023-08-30 fluttergithubbot@gmail.com Marks Windows module_test to be flaky (flutter/flutter#133640)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
15048a6 Update the infrastructure issue template (flutter/flutter#133519
365d800 
)
@ricardoamador ricardoamador deleted the infra_template_remodel branch February 5, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@godofredoc godofredoc Awaiting requested review from godofredoc

@yusuf-goog yusuf-goog Awaiting requested review from yusuf-goog

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ricardoamador @keyonghan