Fixing memory leak in EditableTextState #131377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polina-c
reviewed
Jul 27, 2023
Contributor
There was a problem hiding this comment.
This can be removed completely.
polina-c
reviewed
Jul 27, 2023
Contributor
There was a problem hiding this comment.
Nulling out in dispose, as a fix for leak, smells.
Here is why: https://github.com/dart-lang/leak_tracker/blob/main/doc/TROUBLESHOOT.md#1-static-or-global-object-causes-notgced-leaks
May be some field on retaining path should be converted to WeakReference?
See other fix for notGCed, that converts a field, not owned by parent, to WeakReference: #130842
2e5a4c5 to
36e2cbb
Compare
polina-c
approved these changes
Aug 29, 2023
Contributor
|
auto label is removed for flutter/flutter/131377, due to - The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
36e2cbb to
e511f22
Compare
e511f22 to
99f460f
Compare
Contributor
|
auto label is removed for flutter/flutter/131377, due to - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label. |
99f460f to
a9559c5
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 31, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 31, 2023
flutter/flutter@1fe2495...c175cf8 2023-08-31 15619084+vashworth@users.noreply.github.com Ignore macOS Cocoapods linting failure on DT_TOOLCHAIN_DIR error (flutter/flutter#133588) 2023-08-31 84124091+opxdelwin@users.noreply.github.com `InputDecorationTheme.isCollapsed` doesn't work if `InputDecoration.isCollapsed` is not provided. (flutter/flutter#133189) 2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5156c03344eb to 772d5e996af8 (1 revision) (flutter/flutter#133752) 2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1917fa95ea55 to 5156c03344eb (2 revisions) (flutter/flutter#133745) 2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1f1071d3f5ba to 1917fa95ea55 (2 revisions) (flutter/flutter#133739) 2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from e88b21b6d4e8 to 1f1071d3f5ba (1 revision) (flutter/flutter#133737) 2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0559a733c888 to e88b21b6d4e8 (1 revision) (flutter/flutter#133735) 2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3b75e3de7ef3 to 0559a733c888 (1 revision) (flutter/flutter#133734) 2023-08-31 jonahwilliams@google.com [framework] use ImageFilter for stretch overscroll. (flutter/flutter#133613) 2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73e86369614d to 3b75e3de7ef3 (2 revisions) (flutter/flutter#133724) 2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8f1b77b1ac69 to 73e86369614d (1 revision) (flutter/flutter#133720) 2023-08-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from d37cef84d40d to 8f1b77b1ac69 (1 revision) (flutter/flutter#133714) 2023-08-31 polinach@google.com Mark leak in _DraggableScrollableSheetState. (flutter/flutter#133693) 2023-08-30 polinach@google.com Mark routing test as leaking. (flutter/flutter#133697) 2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from b63eee2e31cc to d37cef84d40d (3 revisions) (flutter/flutter#133706) 2023-08-30 polinach@google.com _RawAutocompleteState should dispose _highlightedOptionIndex. (flutter/flutter#133700) 2023-08-30 matanlurey@users.noreply.github.com Forward-fix a test that will break with an engine roll. (flutter/flutter#133619) 2023-08-30 tessertaha@gmail.com Fix `cancelButtonStyle` & `confirmButtonStyle` properties from `TimePickerTheme` aren't working (flutter/flutter#132843) 2023-08-30 hans.muller@gmail.com Updated DropdownMenu example and added a test (flutter/flutter#133592) 2023-08-30 tessertaha@gmail.com Add `cancelButtonStyle` & `confirmButtonStyle` to the `DatePickerThemeData` (flutter/flutter#132847) 2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 31d5662dcb53 to b63eee2e31cc (1 revision) (flutter/flutter#133692) 2023-08-30 rmolivares@renzo-olivares.dev Fixing memory leak in EditableTextState (flutter/flutter#131377) 2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69f04bdfe952 to 31d5662dcb53 (14 revisions) (flutter/flutter#133683) 2023-08-30 leroux_bruno@yahoo.fr Expose barrierDismissible in PageRoute constructor (flutter/flutter#133659) 2023-08-30 32242716+ricardoamador@users.noreply.github.com Update the infrastructure issue template (flutter/flutter#133519) 2023-08-30 31859944+LongCatIsLooong@users.noreply.github.com Reland "Remove ImageProvider.load, DecoderCallback and `PaintingBinding.instantiateImageCodec` (#132679) (reverted in #133482) (flutter/flutter#133605) 2023-08-30 engine-flutter-autoroll@skia.org Roll Packages from d7d3150 to 64af59e (4 revisions) (flutter/flutter#133675) 2023-08-30 tessertaha@gmail.com Update & improve `TabBar.labelColor` tests (flutter/flutter#133668) 2023-08-30 zanderso@users.noreply.github.com Bump gradle heap size limits in templates (flutter/flutter#133671) 2023-08-30 fluttergithubbot@gmail.com Marks Windows module_test to be flaky (flutter/flutter#133640) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Renzo-Olivares
added a commit
that referenced
this pull request
Aug 31, 2023
This reverts commit 4b89fce.
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
Reverts #131377 reverting because of internal google testing failures b/298310760
8 tasks
Merged
Jasguerrero
added a commit
that referenced
this pull request
Sep 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130469
Pre-launch Checklist
///).