Add support for Future<List<int>?> to MatchesGoldenFile
#132965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise when tests use `expectLater(getBytesOrNull(), matchesGoldenFile(...))`, they may fail in sound null safety mode and pass in weak null safety mode.
882ac5d to
2e0d280
Compare
Piinks
approved these changes
Aug 21, 2023
Contributor
Piinks
left a comment
There was a problem hiding this comment.
Thank you for contributing a fix!
Contributor
|
auto label is removed for flutter/flutter/132965, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 23, 2023
flutter/flutter@54c98d7...bd836cc 2023-08-23 engine-flutter-autoroll@skia.org Roll Packages from c730a90 to 3060b1a (4 revisions) (flutter/flutter#133149) 2023-08-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7d56840865d2 to 72a06427bd37 (8 revisions) (flutter/flutter#133139) 2023-08-23 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from b190f9015049 to 7d56840865d2 (15 revisions) (flutter/flutter#133106) 2023-08-23 ian@hixie.ch Reference AppLifecycleListener from widgets library (flutter/flutter#132995) 2023-08-23 ian@hixie.ch Support disabling animations in the CLI (flutter/flutter#132239) 2023-08-23 zanderso@users.noreply.github.com Don't run on Samsung S10, shift to Pixel 7 Pro (flutter/flutter#133085) 2023-08-23 polinach@google.com Add test to mark recording as leaking. (flutter/flutter#133073) 2023-08-22 jonahwilliams@google.com Revert "[gallery] roll gallery to ecfb9e5352bd12032301b12b30d5853d83d89bda" (flutter/flutter#133095) 2023-08-22 jonahwilliams@google.com [gallery] roll gallery to ecfb9e5352bd12032301b12b30d5853d83d89bda (flutter/flutter#133083) 2023-08-22 tessertaha@gmail.com Update default menu text styles for Material 3 (flutter/flutter#131930) 2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 28b8bd5d5d91 to b190f9015049 (3 revisions) (flutter/flutter#133078) 2023-08-22 tessertaha@gmail.com Fix `FlexibleSpaceBar.title` doesn't respect the leading widget (flutter/flutter#132573) 2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 21437d384b56 to 28b8bd5d5d91 (1 revision) (flutter/flutter#133075) 2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 090754879679 to 21437d384b56 (1 revision) (flutter/flutter#133072) 2023-08-22 ivan.inozemtsev@gmail.com Add support for `Future<List<int>?>` to `MatchesGoldenFile` (flutter/flutter#132965) 2023-08-22 engine-flutter-autoroll@skia.org Roll Packages from e26f3b9 to c730a90 (3 revisions) (flutter/flutter#133067) 2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from ff375bf5d8eb to 090754879679 (1 revision) (flutter/flutter#133066) 2023-08-22 zanderso@users.noreply.github.com Increase heap size for examples/flutter_view gradle build (flutter/flutter#133064) 2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from c5e0152b01f4 to ff375bf5d8eb (4 revisions) (flutter/flutter#133062) 2023-08-22 jmccandless@google.com Fix memory leak in Form (flutter/flutter#132987) 2023-08-22 15619084+vashworth@users.noreply.github.com Re-enable Xcode Debug tests (flutter/flutter#132523) 2023-08-22 zanderso@users.noreply.github.com Increase heap for gradle in examples/platform_view (flutter/flutter#133052) 2023-08-22 polinach@google.com Cover more tests with leak tracking. (flutter/flutter#132806) 2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from f5f099a4a5e3 to c5e0152b01f4 (4 revisions) (flutter/flutter#133049) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise when tests use
expectLater(getBytesOrNull(), matchesGoldenFile(...)), they may fail in sound null safety mode and pass in weak null safety mode.Fixes #132964
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.