Skip to content

Cover more tests with leak tracking. #132806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Aug 22, 2023
Merged

Cover more tests with leak tracking. #132806

auto-submit merged 4 commits into from
Aug 22, 2023

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Aug 17, 2023 •
edited
Loading

This PR replaces some testWidgets with testWidgestsWithLeakTracking.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 17, 2023
@polina-c polina-c requested a review from goderbauer August 17, 2023 21:54
goderbauer
goderbauer approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 17, 2023

auto label is removed for flutter/flutter/132806, due to - The status or check suite Linux web_tests_7_last has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2023
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2023
@auto-submit auto-submit bot merged commit 4e6da2d into flutter:master Aug 22, 2023
@polina-c polina-c deleted the cover branch August 22, 2023 15:52
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2023
@engine-flutter-autoroll
4e6da2d Cover more tests with leak tracking. (flutter/flutter#132806)
b32d310
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2023
@engine-flutter-autoroll
4e6da2d Cover more tests with leak tracking. (flutter/flutter#132806)
68f7ffd
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 23, 2023
@engine-flutter-autoroll
Roll Flutter from 54c98d7 to bd836cc (24 revisions) (#4760)
c0136f9 
flutter/flutter@54c98d7...bd836cc

2023-08-23 engine-flutter-autoroll@skia.org Roll Packages from c730a90 to 3060b1a (4 revisions) (flutter/flutter#133149)
2023-08-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7d56840865d2 to 72a06427bd37 (8 revisions) (flutter/flutter#133139)
2023-08-23 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from b190f9015049 to 7d56840865d2 (15 revisions) (flutter/flutter#133106)
2023-08-23 ian@hixie.ch Reference AppLifecycleListener from widgets library (flutter/flutter#132995)
2023-08-23 ian@hixie.ch Support disabling animations in the CLI (flutter/flutter#132239)
2023-08-23 zanderso@users.noreply.github.com Don't run on Samsung S10, shift to Pixel 7 Pro (flutter/flutter#133085)
2023-08-23 polinach@google.com Add test to mark recording as leaking. (flutter/flutter#133073)
2023-08-22 jonahwilliams@google.com Revert "[gallery] roll gallery to  ecfb9e5352bd12032301b12b30d5853d83d89bda" (flutter/flutter#133095)
2023-08-22 jonahwilliams@google.com [gallery] roll gallery to  ecfb9e5352bd12032301b12b30d5853d83d89bda (flutter/flutter#133083)
2023-08-22 tessertaha@gmail.com Update default menu text styles for Material 3 (flutter/flutter#131930)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 28b8bd5d5d91 to b190f9015049 (3 revisions) (flutter/flutter#133078)
2023-08-22 tessertaha@gmail.com Fix `FlexibleSpaceBar.title` doesn't respect the leading widget (flutter/flutter#132573)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 21437d384b56 to 28b8bd5d5d91 (1 revision) (flutter/flutter#133075)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 090754879679 to 21437d384b56 (1 revision) (flutter/flutter#133072)
2023-08-22 ivan.inozemtsev@gmail.com Add support for `Future<List<int>?>` to `MatchesGoldenFile` (flutter/flutter#132965)
2023-08-22 engine-flutter-autoroll@skia.org Roll Packages from e26f3b9 to c730a90 (3 revisions) (flutter/flutter#133067)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from ff375bf5d8eb to 090754879679 (1 revision) (flutter/flutter#133066)
2023-08-22 zanderso@users.noreply.github.com Increase heap size for examples/flutter_view gradle build (flutter/flutter#133064)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from c5e0152b01f4 to ff375bf5d8eb (4 revisions) (flutter/flutter#133062)
2023-08-22 jmccandless@google.com Fix memory leak in Form (flutter/flutter#132987)
2023-08-22 15619084+vashworth@users.noreply.github.com Re-enable Xcode Debug tests (flutter/flutter#132523)
2023-08-22 zanderso@users.noreply.github.com Increase heap for gradle in examples/platform_view (flutter/flutter#133052)
2023-08-22 polinach@google.com Cover more tests with leak tracking. (flutter/flutter#132806)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from f5f099a4a5e3 to c5e0152b01f4 (4 revisions) (flutter/flutter#133049)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@polina-c polina-c mentioned this pull request Aug 28, 2023
Closed
@polina-c polina-c mentioned this pull request Oct 26, 2023
Closed
28 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
4e6da2d Cover more tests with leak tracking. (flutter/flutter#132806)
5e5eecb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polina-c @goderbauer