Update dev/devicelab/** to provide --local-engine-host.
#132342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
gaaclarke
reviewed
Aug 10, 2023
Member
gaaclarke
left a comment
There was a problem hiding this comment.
The code change looks good to me. I'm not certain how good the test coverage is for this code in pre-submit checks. You may have to launch your own post-submit instances of a devicelab test to get a sanity check before landing. The instructions for running these tests locally uses the devicelab/bin/test_runner.dart, not devicelab/bin/run.dart so I don't think you can verify it locally. @zanderso may know better.
7dcce3f to
cca72e3
Compare
gaaclarke
approved these changes
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 11, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 11, 2023
flutter/flutter@685141b...9b6945b 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 93e8901490e7 to 77dfeea40e10 (1 revision) (flutter/flutter#132389) 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4e532b957225 to 93e8901490e7 (1 revision) (flutter/flutter#132381) 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 25afdb9b696d to 4e532b957225 (4 revisions) (flutter/flutter#132376) 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from da23fb0d9a1d to 25afdb9b696d (1 revision) (flutter/flutter#132370) 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from acd1bc5536ef to da23fb0d9a1d (2 revisions) (flutter/flutter#132367) 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 578a8e8aabf6 to acd1bc5536ef (1 revision) (flutter/flutter#132365) 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 18a71c031f5f to 578a8e8aabf6 (1 revision) (flutter/flutter#132364) 2023-08-11 matanlurey@users.noreply.github.com Update `dev/devicelab/**` to provide `--local-engine-host`. (flutter/flutter#132342) 2023-08-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from b019ac62f21f to 18a71c031f5f (2 revisions) (flutter/flutter#132347) 2023-08-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 16b01b98af20 to b019ac62f21f (1 revision) (flutter/flutter#132341) 2023-08-10 matanlurey@users.noreply.github.com Update `flutter_tools/bin/*.(dart|sh)` to provide, if set, --local-engine-host. (flutter/flutter#132336) 2023-08-10 47866232+chunhtai@users.noreply.github.com Update application id and bundle id of a11y assessment app (flutter/flutter#132334) 2023-08-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from a9be77e6f475 to 16b01b98af20 (6 revisions) (flutter/flutter#132332) 2023-08-10 ian@hixie.ch Remove the fast reassemble / single widget reload feature (flutter/flutter#132255) 2023-08-10 goderbauer@google.com Analyze code snippets in integration_test docs (flutter/flutter#132314) 2023-08-10 109253501+pdblasi-google@users.noreply.github.com Adds SemanticsNode Finders for searching the semantics tree (flutter/flutter#127137) 2023-08-10 rmolivares@renzo-olivares.dev TextField should correctly resolve provided style for material states (flutter/flutter#132330) 2023-08-10 ian@hixie.ch setState documentation (flutter/flutter#132090) 2023-08-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from ea7730c16301 to a9be77e6f475 (6 revisions) (flutter/flutter#132328) 2023-08-10 75845003+deldering-momo@users.noreply.github.com Fix: use --web-launch-url and --web-hostname arguments in flutter drive (flutter/flutter#131763) 2023-08-10 ian@hixie.ch GridView sample code (flutter/flutter#131900) 2023-08-10 polinach@google.com Upgrade flutter packages. (flutter/flutter#132326) 2023-08-10 31859944+LongCatIsLooong@users.noreply.github.com TextPainter migration cleanup (flutter/flutter#132317) 2023-08-10 ian@hixie.ch An example of parentData usage. (flutter/flutter#131818) 2023-08-10 dumazy@gmail.com Add hasInteractedByUser getter in FormField (flutter/flutter#131539) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial work towards #132245.
I have to admit I don't totally understand what I've updated, or whether there are more integration points needed.