-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Update application id and bundle id of a11y assessment app #132334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
|
||
| /* Begin PBXBuildFile section */ | ||
| 1498D2341E8E89220040F4C2 /* GeneratedPluginRegistrant.m in Sources */ = {isa = PBXBuildFile; fileRef = 1498D2331E8E89220040F4C2 /* GeneratedPluginRegistrant.m */; }; | ||
| 331C808B294A63AB00263BE5 /* RunnerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 331C807B294A618700263BE5 /* RunnerTests.swift */; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change in this file is generated by Xcode when updating the bundle id
|
test-exempt: internal test app |
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
flutter/flutter@685141b...9b6945b 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 93e8901490e7 to 77dfeea40e10 (1 revision) (flutter/flutter#132389) 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4e532b957225 to 93e8901490e7 (1 revision) (flutter/flutter#132381) 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 25afdb9b696d to 4e532b957225 (4 revisions) (flutter/flutter#132376) 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from da23fb0d9a1d to 25afdb9b696d (1 revision) (flutter/flutter#132370) 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from acd1bc5536ef to da23fb0d9a1d (2 revisions) (flutter/flutter#132367) 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 578a8e8aabf6 to acd1bc5536ef (1 revision) (flutter/flutter#132365) 2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 18a71c031f5f to 578a8e8aabf6 (1 revision) (flutter/flutter#132364) 2023-08-11 matanlurey@users.noreply.github.com Update `dev/devicelab/**` to provide `--local-engine-host`. (flutter/flutter#132342) 2023-08-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from b019ac62f21f to 18a71c031f5f (2 revisions) (flutter/flutter#132347) 2023-08-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 16b01b98af20 to b019ac62f21f (1 revision) (flutter/flutter#132341) 2023-08-10 matanlurey@users.noreply.github.com Update `flutter_tools/bin/*.(dart|sh)` to provide, if set, --local-engine-host. (flutter/flutter#132336) 2023-08-10 47866232+chunhtai@users.noreply.github.com Update application id and bundle id of a11y assessment app (flutter/flutter#132334) 2023-08-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from a9be77e6f475 to 16b01b98af20 (6 revisions) (flutter/flutter#132332) 2023-08-10 ian@hixie.ch Remove the fast reassemble / single widget reload feature (flutter/flutter#132255) 2023-08-10 goderbauer@google.com Analyze code snippets in integration_test docs (flutter/flutter#132314) 2023-08-10 109253501+pdblasi-google@users.noreply.github.com Adds SemanticsNode Finders for searching the semantics tree (flutter/flutter#127137) 2023-08-10 rmolivares@renzo-olivares.dev TextField should correctly resolve provided style for material states (flutter/flutter#132330) 2023-08-10 ian@hixie.ch setState documentation (flutter/flutter#132090) 2023-08-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from ea7730c16301 to a9be77e6f475 (6 revisions) (flutter/flutter#132328) 2023-08-10 75845003+deldering-momo@users.noreply.github.com Fix: use --web-launch-url and --web-hostname arguments in flutter drive (flutter/flutter#131763) 2023-08-10 ian@hixie.ch GridView sample code (flutter/flutter#131900) 2023-08-10 polinach@google.com Upgrade flutter packages. (flutter/flutter#132326) 2023-08-10 31859944+LongCatIsLooong@users.noreply.github.com TextPainter migration cleanup (flutter/flutter#132317) 2023-08-10 ian@hixie.ch An example of parentData usage. (flutter/flutter#131818) 2023-08-10 dumazy@gmail.com Add hasInteractedByUser getter in FormField (flutter/flutter#131539) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

The skeleton id needed to be updated to be sent to app store or play store
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.