Remove Iterator from _History #132101
Merged
Remove Iterator from _History #132101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chunhtai
approved these changes
Aug 8, 2023
Contributor
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning this up
Contributor
|
test-exempt: code removal |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 9, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 9, 2023
flutter/flutter@436df69...f4c25bb 2023-08-09 zanderso@users.noreply.github.com Revert "Handle breaking changes in leak_tracker." (flutter/flutter#132223) 2023-08-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8ec575168d44 to 3d3fb4faed02 (3 revisions) (flutter/flutter#132193) 2023-08-09 31859944+LongCatIsLooong@users.noreply.github.com Use pattern matching to avoid strange type annotations (flutter/flutter#131964) 2023-08-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6839b88283b6 to 8ec575168d44 (1 revision) (flutter/flutter#132182) 2023-08-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 29b117aa4192 to 6839b88283b6 (1 revision) (flutter/flutter#132181) 2023-08-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 82292b8390cb to 29b117aa4192 (5 revisions) (flutter/flutter#132179) 2023-08-09 31859944+LongCatIsLooong@users.noreply.github.com Add more info to `OverlayState.insert` error messages (flutter/flutter#129363) 2023-08-08 36861262+QuncCccccc@users.noreply.github.com Add `textCapitalization` property for `SearchBar` and `SearchAnchor` (flutter/flutter#131459) 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 934ebb005d02 to 82292b8390cb (3 revisions) (flutter/flutter#132166) 2023-08-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.2 to 2.21.3 (flutter/flutter#132165) 2023-08-08 jesus_sguerrero@hotmail.com Revert of #120385 (flutter/flutter#132167) 2023-08-08 tessertaha@gmail.com Add `PopupMenuButton.iconColor`, `PopupMenuTheme.iconSize` and fix button icon using unexpected color propert (flutter/flutter#132054) 2023-08-08 ian@hixie.ch More PageStorage clarity in the documentation (flutter/flutter#131954) 2023-08-08 ian@hixie.ch Document that missed_frame_build_budget_count is misleading (flutter/flutter#132137) 2023-08-08 chingjun@google.com Locate the template directory using a TemplatePathProvider. (flutter/flutter#132156) 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd03fae51d38 to 934ebb005d02 (4 revisions) (flutter/flutter#132159) 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22bd35a19352 to dd03fae51d38 (3 revisions) (flutter/flutter#132149) 2023-08-08 tessertaha@gmail.com Fix `TabBarTheme.indicatorColor` not applied in Material 2 (flutter/flutter#132123) 2023-08-08 76067278+aakash-pamnani@users.noreply.github.com Paginated Data Table : Fixed Row number at footer in last page (flutter/flutter#130389) 2023-08-08 mdebbar@google.com [web] Use benchmark callback from `dart:ui_web` (flutter/flutter#132087) 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 99fdac88f3c6 to 22bd35a19352 (3 revisions) (flutter/flutter#132141) 2023-08-08 louisehsu@google.com [framework] Add Search Web to selection controls for iOS (flutter/flutter#131898) 2023-08-08 jmccandless@google.com Remove Iterator from _History (flutter/flutter#132101) 2023-08-08 ian@hixie.ch Update dartdoc driver to match current behaviour (flutter/flutter#132078) 2023-08-08 ian@hixie.ch More documentation about warm-up frames (flutter/flutter#132085) 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 146c4c9487fc to 99fdac88f3c6 (3 revisions) (flutter/flutter#132135) 2023-08-08 engine-flutter-autoroll@skia.org Roll Packages from d7ee75a to ac41376 (8 revisions) (flutter/flutter#132133) 2023-08-08 polinach@google.com Handle breaking changes in leak_tracker. (flutter/flutter#131998) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just code cleanup. As mentioned in #120385 (comment), Iterator isn't necessary in this private class.