Skip to content

Add textCapitalization property for SearchBar and SearchAnchor #131459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 7 commits into from
Aug 8, 2023
Merged

Add textCapitalization property for SearchBar and SearchAnchor #131459

auto-submit merged 7 commits into from
Aug 8, 2023

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Jul 28, 2023

This is to add textCapitalization property for SearchBar and SearchAnchor.
Fixes: #131260

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 28, 2023
@QuncCccccc QuncCccccc changed the title Add textCapitalization property forSearchBar and SearchAnchor Add textCapitalization property for SearchBar and SearchAnchor Jul 28, 2023
@QuncCccccc QuncCccccc marked this pull request as ready for review July 28, 2023 20:45
@QuncCccccc QuncCccccc requested a review from HansMuller July 28, 2023 20:45
@HansMuller
Copy link
Contributor

HansMuller commented Jul 28, 2023

Shouldn't this property also be exposed in the SearchBarTheme?

@QuncCccccc QuncCccccc force-pushed the add_text_capitalization branch from 2bded37 to 8132605 Compare August 3, 2023 19:15
@HansMuller
Copy link
Contributor

HansMuller commented Aug 3, 2023

It looks like the tests, e.g. 'SearchBar respects textCapitalization property' need to be extended a little to also verify that the theme parameter does the right thing.

@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented Aug 3, 2023

It looks like the tests, e.g. 'SearchBar respects textCapitalization property' need to be extended a little to also verify that the theme parameter does the right thing.

Ah I added this check in search_bar_theme_test.dart. The tests in this file are checking textCapitalization can be overridden by searchBar's textCapitalization, then SearchBarThemeData.textCapitalization, and then overall theme's searchBarTheme.textCapitalization.

HansMuller
HansMuller approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2023
@auto-submit auto-submit bot merged commit 0bc5a2b into flutter:master Aug 8, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 9, 2023
@engine-flutter-autoroll
0bc5a2b Add textCapitalization property for SearchBar and `Search…
5610304 
…Anchor` (flutter/flutter#131459)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 9, 2023
@engine-flutter-autoroll
0bc5a2b Add textCapitalization property for SearchBar and `Search…
5aa5574 
…Anchor` (flutter/flutter#131459)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 9, 2023
@engine-flutter-autoroll
Roll Flutter from 436df69 to f4c25bb (28 revisions) (#4666)
881c1f5 
flutter/flutter@436df69...f4c25bb

2023-08-09 zanderso@users.noreply.github.com Revert "Handle breaking changes in leak_tracker." (flutter/flutter#132223)
2023-08-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8ec575168d44 to 3d3fb4faed02 (3 revisions) (flutter/flutter#132193)
2023-08-09 31859944+LongCatIsLooong@users.noreply.github.com Use pattern matching to avoid strange type annotations (flutter/flutter#131964)
2023-08-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6839b88283b6 to 8ec575168d44 (1 revision) (flutter/flutter#132182)
2023-08-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 29b117aa4192 to 6839b88283b6 (1 revision) (flutter/flutter#132181)
2023-08-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 82292b8390cb to 29b117aa4192 (5 revisions) (flutter/flutter#132179)
2023-08-09 31859944+LongCatIsLooong@users.noreply.github.com Add more info to `OverlayState.insert` error messages (flutter/flutter#129363)
2023-08-08 36861262+QuncCccccc@users.noreply.github.com Add `textCapitalization` property for `SearchBar` and `SearchAnchor` (flutter/flutter#131459)
2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 934ebb005d02 to 82292b8390cb (3 revisions) (flutter/flutter#132166)
2023-08-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.2 to 2.21.3 (flutter/flutter#132165)
2023-08-08 jesus_sguerrero@hotmail.com Revert of #120385 (flutter/flutter#132167)
2023-08-08 tessertaha@gmail.com Add `PopupMenuButton.iconColor`, `PopupMenuTheme.iconSize` and fix button icon using unexpected color propert (flutter/flutter#132054)
2023-08-08 ian@hixie.ch More PageStorage clarity in the documentation (flutter/flutter#131954)
2023-08-08 ian@hixie.ch Document that missed_frame_build_budget_count is misleading (flutter/flutter#132137)
2023-08-08 chingjun@google.com Locate the template directory using a TemplatePathProvider. (flutter/flutter#132156)
2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd03fae51d38 to 934ebb005d02 (4 revisions) (flutter/flutter#132159)
2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22bd35a19352 to dd03fae51d38 (3 revisions) (flutter/flutter#132149)
2023-08-08 tessertaha@gmail.com Fix `TabBarTheme.indicatorColor` not applied in Material 2 (flutter/flutter#132123)
2023-08-08 76067278+aakash-pamnani@users.noreply.github.com Paginated Data Table : Fixed Row number at footer in last page  (flutter/flutter#130389)
2023-08-08 mdebbar@google.com [web] Use benchmark callback from `dart:ui_web` (flutter/flutter#132087)
2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 99fdac88f3c6 to 22bd35a19352 (3 revisions) (flutter/flutter#132141)
2023-08-08 louisehsu@google.com [framework] Add Search Web to selection controls for iOS (flutter/flutter#131898)
2023-08-08 jmccandless@google.com Remove Iterator from _History (flutter/flutter#132101)
2023-08-08 ian@hixie.ch Update dartdoc driver to match current behaviour (flutter/flutter#132078)
2023-08-08 ian@hixie.ch More documentation about warm-up frames (flutter/flutter#132085)
2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 146c4c9487fc to 99fdac88f3c6 (3 revisions) (flutter/flutter#132135)
2023-08-08 engine-flutter-autoroll@skia.org Roll Packages from d7ee75a to ac41376 (8 revisions) (flutter/flutter#132133)
2023-08-08 polinach@google.com Handle breaking changes in leak_tracker. (flutter/flutter#131998)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@dam-ease dam-ease mentioned this pull request Aug 10, 2023
Closed
2 tasks
@HansMuller HansMuller mentioned this pull request Aug 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
0bc5a2b Add textCapitalization property for SearchBar and `Search…
23337c1 
…Anchor` (flutter/flutter#131459)
@lukaszciastko
Copy link

lukaszciastko commented Dec 18, 2023

Hi, shouldn't the services.dart be an absolute reference? This is the pattern across the whole of Material. I just spotted this, because I have a script that relies on these dependencies while copying Material classes into a custom folder.

@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented Dec 19, 2023

Hi, shouldn't the services.dart be an absolute reference? This is the pattern across the whole of Material. I just spotted this, because I have a script that relies on these dependencies while copying Material classes into a custom folder.

Thanks for catching this! Created a fix PR(#140425)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

textCapitalization option for SearchBar

3 participants

@QuncCccccc @HansMuller @lukaszciastko