Skip to content

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Aug 1, 2023

Adds gem dependency to the tests

Fixes #131693

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz requested a review from keyonghan August 1, 2023 21:20
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz force-pushed the extension_test_deps_gem branch from b16f8c5 to edfe0fb Compare August 2, 2023 16:15
@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2023
@auto-submit auto-submit bot merged commit 12b8e0c into flutter:master Aug 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 3, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 3, 2023
flutter/flutter@b3f99ff...c00d241

2023-08-03 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 9304c0074d29 to 4c1157b9da54 (24 revisions) (flutter/flutter#131830)
2023-08-03 katelovett@google.com Assert against infinite values of control points in CatmullRomSpline (flutter/flutter#131820)
2023-08-02 polinach@google.com Update stack_frame.dart to parse unexpected error format to null. (flutter/flutter#131786)
2023-08-02 jmccandless@google.com Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus (flutter/flutter#130164)
2023-08-02 ian@hixie.ch Mention that the widget tree is not disposed on exit (flutter/flutter#131637)
2023-08-02 louisehsu@google.com [framework] Add Look Up to selection controls for iOS  (flutter/flutter#131798)
2023-08-02 34871572+gmackall@users.noreply.github.com Add documentation in flutter.groovy noting that we always use the latest available android version (flutter/flutter#131705)
2023-08-02 jonahwilliams@google.com [framework] lerp images in a save layer. (flutter/flutter#131703)
2023-08-02 engine-flutter-autoroll@skia.org Roll Packages from 3dc00c1 to 4e4961a (1 revision) (flutter/flutter#131788)
2023-08-02 ychris@google.com add gem dependency to the ios_app_with_extensions_test (flutter/flutter#131713)
2023-08-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from d6b962d0e36d to 9304c0074d29 (4 revisions) (flutter/flutter#131790)
2023-08-02 christopherfujino@gmail.com [flutter_tools] set terminal.singleCharMode to false after attach finishes (flutter/flutter#131723)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ios_app_with_extensions_test fails when moving to host only

2 participants