Skip to content

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented Aug 1, 2023

Last piece of/
Fixes #131425

Also added a period to a comment line that was missing one.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 1, 2023
@gmackall gmackall marked this pull request as ready for review August 1, 2023 21:18
@gmackall gmackall requested a review from reidbaker August 1, 2023 21:18
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 2, 2023

auto label is removed for flutter/flutter, pr: 131705, due to - The status or check suite Linux firebase_android_embedding_v2_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2023
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 2, 2023

auto label is removed for flutter/flutter, pr: 131705, due to - The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2023
@auto-submit auto-submit bot merged commit 00a8323 into flutter:master Aug 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 3, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 3, 2023
flutter/flutter@b3f99ff...c00d241

2023-08-03 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 9304c0074d29 to 4c1157b9da54 (24 revisions) (flutter/flutter#131830)
2023-08-03 katelovett@google.com Assert against infinite values of control points in CatmullRomSpline (flutter/flutter#131820)
2023-08-02 polinach@google.com Update stack_frame.dart to parse unexpected error format to null. (flutter/flutter#131786)
2023-08-02 jmccandless@google.com Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus (flutter/flutter#130164)
2023-08-02 ian@hixie.ch Mention that the widget tree is not disposed on exit (flutter/flutter#131637)
2023-08-02 louisehsu@google.com [framework] Add Look Up to selection controls for iOS  (flutter/flutter#131798)
2023-08-02 34871572+gmackall@users.noreply.github.com Add documentation in flutter.groovy noting that we always use the latest available android version (flutter/flutter#131705)
2023-08-02 jonahwilliams@google.com [framework] lerp images in a save layer. (flutter/flutter#131703)
2023-08-02 engine-flutter-autoroll@skia.org Roll Packages from 3dc00c1 to 4e4961a (1 revision) (flutter/flutter#131788)
2023-08-02 ychris@google.com add gem dependency to the ios_app_with_extensions_test (flutter/flutter#131713)
2023-08-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from d6b962d0e36d to 9304c0074d29 (4 revisions) (flutter/flutter#131790)
2023-08-02 christopherfujino@gmail.com [flutter_tools] set terminal.singleCharMode to false after attach finishes (flutter/flutter#131723)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump compileSdkVersions in benchmarks and tests to the latest sdk version

2 participants