-
Notifications
You must be signed in to change notification settings - Fork 29.8k
[flutter roll] Revert "Fix floating SnackBar throws when FAB is on the top" #131303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter roll] Revert "Fix floating SnackBar throws when FAB is on the top" #131303
Conversation
This reverts commit 97e0a05.
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@Piinks Do you have some information to share related to the error on the internal report? Maybe they get the error message we added: One guess could be that there is a custom |
flutter/flutter@9def8f6...bae1ac2 2023-07-26 ian@hixie.ch ImageDecoration.lerp (flutter/flutter#130533) 2023-07-26 ian@hixie.ch Document the Flow/Opacity/hit-test issues (flutter/flutter#131239) 2023-07-26 jacksongardner@google.com Run benchmarks with `--omit-type-checks` (flutter/flutter#131102) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from ba83c144f84e to faf1121d010c (2 revisions) (flutter/flutter#131339) 2023-07-26 engine-flutter-autoroll@skia.org Roll Packages from 406eac1 to a99fc87 (1 revision) (flutter/flutter#131336) 2023-07-26 xilaizhang@google.com [flutter roll] Revert "Fix floating SnackBar throws when FAB is on the top" (flutter/flutter#131303) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 89203002f455 to ba83c144f84e (1 revision) (flutter/flutter#131329) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3cd1c599abe to 89203002f455 (1 revision) (flutter/flutter#131323) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4bdceccff964 to b3cd1c599abe (1 revision) (flutter/flutter#131317) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from df12fff329a1 to 4bdceccff964 (2 revisions) (flutter/flutter#131316) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 43f727e4748a to df12fff329a1 (3 revisions) (flutter/flutter#131314) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f3b0d6b7250 to 43f727e4748a (1 revision) (flutter/flutter#131311) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from db711f14842b to 7f3b0d6b7250 (4 revisions) (flutter/flutter#131309) 2023-07-26 Caffeinix@users.noreply.github.com Reorders menu item button shortcuts on Mac-like platforms (flutter/flutter#129309) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e00c11eb519 to db711f14842b (3 revisions) (flutter/flutter#131307) 2023-07-26 srawlins@google.com Ignore unused parameters in snippet code (flutter/flutter#131068) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3fff7316dc8d to 9e00c11eb519 (1 revision) (flutter/flutter#131299) 2023-07-25 dnfield@google.com Add example for locking screen orientation in a letterboxing environment (flutter/flutter#131266) 2023-07-25 leroux_bruno@yahoo.fr Update BottomAppBar and BottomAppBarTheme tests for M3 (flutter/flutter#130983) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from f5fbfa859b63 to 3fff7316dc8d (4 revisions) (flutter/flutter#131286) 2023-07-25 61322712+sabin26@users.noreply.github.com Add Sabin Neupane to AUTHORS (flutter/flutter#131237) 2023-07-25 engine-flutter-autoroll@skia.org Roll Packages from 8028caf to 406eac1 (4 revisions) (flutter/flutter#131285) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0a5c6cdd5d02 to f5fbfa859b63 (8 revisions) (flutter/flutter#131283) 2023-07-25 github@alexv525.com 🚀 Expose `scrollControlDisabledMaxHeightRatio` to the modal bottom sheet (flutter/flutter#129688) 2023-07-25 737941+loic-sharma@users.noreply.github.com Revert "Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog." (flutter/flutter#131278) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 036c58f79307 to 0a5c6cdd5d02 (1 revision) (flutter/flutter#131256) 2023-07-25 tessertaha@gmail.com Fix `RawChip` doesn't use `ChipTheme.showCheckmark` value (flutter/flutter#131257) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
## Description This PR is a reland of #129274 with a fix and new test related to the revert (#131303). It updates how a floating snack bar is positionned when a `Scaffold` defines a FAB with `Scaffold.floatingActionButtonLocation` sets to one of the top locations. **Before this PR:** - When a FAB location is set to the top of the `Scaffold`, a floating `SnackBar` can't be displayed and an assert throws in debug mode. **After this PR:** - When a FAB location is set to the top of the `Scaffold`, a floating `SnackBar` will be displayed at the bottom of the screen, above a `NavigationBar` for instance (the top FAB is ignored when computing the floating snack bar position).  ## Motivation This is a edge case related to a discrepancy between the Material spec and the Flutter `Scaffold` customizability: - Material spec states that a floating `SnackBar` should be displayed above a FAB. But, in Material spec, FABs are expected to be on the bottom. - Since #51465, Flutter `Scaffold` makes it valid to show a FAB on the top of the `Scaffold`. ## Related Issue fixes #128150 ## Tests Adds 2 tests.
…e top" (flutter#131303) Reverts flutter#129274 temporarily putting up a revert in case a fix is difficult context: [b/293202068](http://b/293202068) youtube integration tests failed
…#131475) ## Description This PR is a reland of flutter#129274 with a fix and new test related to the revert (flutter#131303). It updates how a floating snack bar is positionned when a `Scaffold` defines a FAB with `Scaffold.floatingActionButtonLocation` sets to one of the top locations. **Before this PR:** - When a FAB location is set to the top of the `Scaffold`, a floating `SnackBar` can't be displayed and an assert throws in debug mode. **After this PR:** - When a FAB location is set to the top of the `Scaffold`, a floating `SnackBar` will be displayed at the bottom of the screen, above a `NavigationBar` for instance (the top FAB is ignored when computing the floating snack bar position).  ## Motivation This is a edge case related to a discrepancy between the Material spec and the Flutter `Scaffold` customizability: - Material spec states that a floating `SnackBar` should be displayed above a FAB. But, in Material spec, FABs are expected to be on the bottom. - Since flutter#51465, Flutter `Scaffold` makes it valid to show a FAB on the top of the `Scaffold`. ## Related Issue fixes flutter#128150 ## Tests Adds 2 tests.
…e top" (flutter#131303) Reverts flutter#129274 temporarily putting up a revert in case a fix is difficult context: [b/293202068](http://b/293202068) youtube integration tests failed
…#131475) ## Description This PR is a reland of flutter#129274 with a fix and new test related to the revert (flutter#131303). It updates how a floating snack bar is positionned when a `Scaffold` defines a FAB with `Scaffold.floatingActionButtonLocation` sets to one of the top locations. **Before this PR:** - When a FAB location is set to the top of the `Scaffold`, a floating `SnackBar` can't be displayed and an assert throws in debug mode. **After this PR:** - When a FAB location is set to the top of the `Scaffold`, a floating `SnackBar` will be displayed at the bottom of the screen, above a `NavigationBar` for instance (the top FAB is ignored when computing the floating snack bar position).  ## Motivation This is a edge case related to a discrepancy between the Material spec and the Flutter `Scaffold` customizability: - Material spec states that a floating `SnackBar` should be displayed above a FAB. But, in Material spec, FABs are expected to be on the bottom. - Since flutter#51465, Flutter `Scaffold` makes it valid to show a FAB on the top of the `Scaffold`. ## Related Issue fixes flutter#128150 ## Tests Adds 2 tests.
Reverts #129274
temporarily putting up a revert in case a fix is difficult
context: b/293202068 youtube integration tests failed