🚀 Expose `scrollControlDisabledMaxHeightRatio` to the modal bottom sheet #129688

AlexV525 · 2023-06-28T02:34:53Z

Adding the scrollControlDisabledMaxHeightRatio parameter for modal bottom sheet widgets, and using the default value 9.0 / 16.0 to avoid breaking.

Resolves #129690.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

Renzo-Olivares

LGTM with some small nits. Thank you for your contribution!

Renzo-Olivares · 2023-07-20T20:30:21Z

packages/flutter/lib/src/material/bottom_sheet.dart

Nice catch!

packages/flutter/lib/src/material/bottom_sheet.dart

AlexV525 · 2023-07-21T01:47:16Z

@Renzo-Olivares PTAL

flutter-dashboard · 2023-07-21T06:03:34Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Renzo-Olivares · 2023-07-21T19:47:05Z

@AlexV525 looks like some tests are failing, can you take a look?

AlexV525 · 2023-07-21T19:58:07Z

@AlexV525 looks like some tests are failing, can you take a look?

Yeah I'll figure them out as soon as I'm available.

AlexV525 · 2023-07-22T03:55:41Z

@Renzo-Olivares Should be good to go.

packages/flutter/lib/src/material/bottom_sheet.dart

…Ratio`

…ratio

AlexV525 · 2023-07-24T23:26:55Z

@Renzo-Olivares I've updated these names to scrollControlDisabledMaxHeightRatio series.

Renzo-Olivares

LGTM

…ottom sheet (flutter/flutter#129688)

flutter/flutter@9def8f6...bae1ac2 2023-07-26 ian@hixie.ch ImageDecoration.lerp (flutter/flutter#130533) 2023-07-26 ian@hixie.ch Document the Flow/Opacity/hit-test issues (flutter/flutter#131239) 2023-07-26 jacksongardner@google.com Run benchmarks with `--omit-type-checks` (flutter/flutter#131102) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from ba83c144f84e to faf1121d010c (2 revisions) (flutter/flutter#131339) 2023-07-26 engine-flutter-autoroll@skia.org Roll Packages from 406eac1 to a99fc87 (1 revision) (flutter/flutter#131336) 2023-07-26 xilaizhang@google.com [flutter roll] Revert "Fix floating SnackBar throws when FAB is on the top" (flutter/flutter#131303) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 89203002f455 to ba83c144f84e (1 revision) (flutter/flutter#131329) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3cd1c599abe to 89203002f455 (1 revision) (flutter/flutter#131323) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4bdceccff964 to b3cd1c599abe (1 revision) (flutter/flutter#131317) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from df12fff329a1 to 4bdceccff964 (2 revisions) (flutter/flutter#131316) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 43f727e4748a to df12fff329a1 (3 revisions) (flutter/flutter#131314) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f3b0d6b7250 to 43f727e4748a (1 revision) (flutter/flutter#131311) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from db711f14842b to 7f3b0d6b7250 (4 revisions) (flutter/flutter#131309) 2023-07-26 Caffeinix@users.noreply.github.com Reorders menu item button shortcuts on Mac-like platforms (flutter/flutter#129309) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9e00c11eb519 to db711f14842b (3 revisions) (flutter/flutter#131307) 2023-07-26 srawlins@google.com Ignore unused parameters in snippet code (flutter/flutter#131068) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3fff7316dc8d to 9e00c11eb519 (1 revision) (flutter/flutter#131299) 2023-07-25 dnfield@google.com Add example for locking screen orientation in a letterboxing environment (flutter/flutter#131266) 2023-07-25 leroux_bruno@yahoo.fr Update BottomAppBar and BottomAppBarTheme tests for M3 (flutter/flutter#130983) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from f5fbfa859b63 to 3fff7316dc8d (4 revisions) (flutter/flutter#131286) 2023-07-25 61322712+sabin26@users.noreply.github.com Add Sabin Neupane to AUTHORS (flutter/flutter#131237) 2023-07-25 engine-flutter-autoroll@skia.org Roll Packages from 8028caf to 406eac1 (4 revisions) (flutter/flutter#131285) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0a5c6cdd5d02 to f5fbfa859b63 (8 revisions) (flutter/flutter#131283) 2023-07-25 github@alexv525.com 🚀 Expose `scrollControlDisabledMaxHeightRatio` to the modal bottom sheet (flutter/flutter#129688) 2023-07-25 737941+loic-sharma@users.noreply.github.com Revert "Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog." (flutter/flutter#131278) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 036c58f79307 to 0a5c6cdd5d02 (1 revision) (flutter/flutter#131256) 2023-07-25 tessertaha@gmail.com Fix `RawChip` doesn't use `ChipTheme.showCheckmark` value (flutter/flutter#131257) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…eet (flutter#129688) Adding the `scrollControlDisabledMaxHeightRatio` parameter for modal bottom sheet widgets, and using the default value `9.0 / 16.0` to avoid breaking. Resolves flutter#129690.

AlexV525 marked this pull request as ready for review June 28, 2023 03:55

HansMuller requested a review from Renzo-Olivares June 28, 2023 18:15

HansMuller added P2 Important issues not at the top of the work list and removed P2 Important issues not at the top of the work list labels Jun 29, 2023

goderbauer added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 5, 2023

Renzo-Olivares approved these changes Jul 20, 2023

View reviewed changes

AlexV525 added 4 commits July 21, 2023 09:38

🚀 Expose scrollControlledMaxHeightRatio to the modal bottom sheet

1ec8e9e

✅ Add tests

ca3ece6

🐛 Fix listeners

6f6fb2b

🎨 Address review comments

6a2aa37

AlexV525 force-pushed the feat/expose-modal-bottom-sheet-max-height-ratio branch from e72120d to 6a2aa37 Compare July 21, 2023 01:46

AlexV525 marked this pull request as draft July 21, 2023 05:57

✅ Fix tests

804d3f0

AlexV525 marked this pull request as ready for review July 22, 2023 03:55

AlexV525 requested a review from Renzo-Olivares July 22, 2023 03:55

Renzo-Olivares reviewed Jul 24, 2023

View reviewed changes

packages/flutter/lib/src/material/bottom_sheet.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/bottom_sheet.dart Outdated Show resolved Hide resolved

AlexV525 added 2 commits July 25, 2023 06:38

🚚 scrollControlledMaxHeightRatio -> `scrollControlDisabledMaxHeight…

0adf487

…Ratio`

Merge branch 'master' into feat/expose-modal-bottom-sheet-max-height-…

ed4653d

…ratio

AlexV525 changed the title ~~🚀 Expose scrollControlledMaxHeightRatio to the modal bottom sheet~~ 🚀 Expose scrollControlDisabledMaxHeightRatio to the modal bottom sheet Jul 24, 2023

AlexV525 requested a review from Renzo-Olivares July 24, 2023 23:26

Renzo-Olivares approved these changes Jul 25, 2023

View reviewed changes

AlexV525 added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2023

auto-submit bot merged commit 9f374f1 into flutter:master Jul 25, 2023

jonahwilliams mentioned this pull request Jul 25, 2023

Autosubmit bot landed a commit while the tree was red. #131281

Closed

AlexV525 deleted the feat/expose-modal-bottom-sheet-max-height-ratio branch July 26, 2023 03:33

engine-flutter-autoroll mentioned this pull request Jul 26, 2023

Roll Flutter from 9def8f6bc56b to 9bd87ec984a6 (22 revisions) flutter/packages#4566

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2023

9f374f1 🚀 Expose scrollControlDisabledMaxHeightRatio to the modal b…

17ce358

…ottom sheet (flutter/flutter#129688)

engine-flutter-autoroll mentioned this pull request Jul 26, 2023

Roll Flutter from 9def8f6bc56b to 21d7eeeb5f47 (23 revisions) flutter/packages#4568

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2023

9f374f1 🚀 Expose scrollControlDisabledMaxHeightRatio to the modal b…

fcaa2b6

…ottom sheet (flutter/flutter#129688)

engine-flutter-autoroll mentioned this pull request Jul 26, 2023

Roll Flutter from 9def8f6bc56b to d4d57546fd9b (24 revisions) flutter/packages#4569

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2023

9f374f1 🚀 Expose scrollControlDisabledMaxHeightRatio to the modal b…

89bf77e

…ottom sheet (flutter/flutter#129688)

engine-flutter-autoroll mentioned this pull request Jul 26, 2023

Roll Flutter from 9def8f6bc56b to bae1ac2f6f35 (27 revisions) flutter/packages#4570

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2023

9f374f1 🚀 Expose scrollControlDisabledMaxHeightRatio to the modal b…

730919f

…ottom sheet (flutter/flutter#129688)

HansMuller mentioned this pull request Jul 28, 2023

Flutter Framework Team: Notable Commits #121415

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🚀 Expose `scrollControlDisabledMaxHeightRatio` to the modal bottom sheet #129688

🚀 Expose `scrollControlDisabledMaxHeightRatio` to the modal bottom sheet #129688

Uh oh!

AlexV525 commented Jun 28, 2023 •

edited

Loading

Uh oh!

Renzo-Olivares left a comment

Uh oh!

Renzo-Olivares Jul 20, 2023

Uh oh!

Uh oh!

Uh oh!

AlexV525 commented Jul 21, 2023

Uh oh!

flutter-dashboard bot commented Jul 21, 2023

Uh oh!

Renzo-Olivares commented Jul 21, 2023

Uh oh!

AlexV525 commented Jul 21, 2023

Uh oh!

AlexV525 commented Jul 22, 2023

Uh oh!

Uh oh!

Uh oh!

AlexV525 commented Jul 24, 2023

Uh oh!

Renzo-Olivares left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

🚀 Expose scrollControlDisabledMaxHeightRatio to the modal bottom sheet #129688

🚀 Expose scrollControlDisabledMaxHeightRatio to the modal bottom sheet #129688

Uh oh!

Conversation

AlexV525 commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jul 20, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AlexV525 commented Jul 21, 2023

Uh oh!

flutter-dashboard bot commented Jul 21, 2023

Uh oh!

Renzo-Olivares commented Jul 21, 2023

Uh oh!

AlexV525 commented Jul 21, 2023

Uh oh!

AlexV525 commented Jul 22, 2023

Uh oh!

Uh oh!

Uh oh!

AlexV525 commented Jul 24, 2023

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

🚀 Expose `scrollControlDisabledMaxHeightRatio` to the modal bottom sheet #129688

🚀 Expose `scrollControlDisabledMaxHeightRatio` to the modal bottom sheet #129688

AlexV525 commented Jun 28, 2023 •

edited

Loading