Reduce usage of testUsingContext #131078
Merged
Reduce usage of testUsingContext #131078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasyishak
reviewed
Jul 21, 2023
Comment on lines
-41
to
-43
| }, overrides: <Type, Generator>{ | ||
| FileSystem: () => fileSystem, | ||
| ProcessManager: () => processManager, |
Contributor
There was a problem hiding this comment.
Were these overrides just being provided because they were being copied from a previous test? I don't see anywhere in this PR where we are injecting the filesystem and process manager
Contributor
Author
There was a problem hiding this comment.
yeah, only a few of these tests actually hit the context
Contributor
Author
There was a problem hiding this comment.
As a side note, I'm exploring writing a script that will test what happens if we rename each testUsingContext test as testWithoutContext and see how many still pass.
eliasyishak
approved these changes
Jul 24, 2023
Contributor
eliasyishak
left a comment
There was a problem hiding this comment.
lgtm, lmk if you want to do another review if you get the script to replace testUsingContext calls
Contributor
Author
For clarity, that would be a new PR. For this change, I essentially manually did this for the test libraries I changed. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 25, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 25, 2023
flutter/flutter@d7ed5dc...9def8f6 2023-07-25 xxxx.xyzs.xxxx@gmail.com Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. (flutter/flutter#130484) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7a842ee9ccd to 036c58f79307 (1 revision) (flutter/flutter#131244) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3baca2fe55c8 to a7a842ee9ccd (1 revision) (flutter/flutter#131243) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9a0192d965e0 to 3baca2fe55c8 (1 revision) (flutter/flutter#131241) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from ceb2674e82b4 to 9a0192d965e0 (3 revisions) (flutter/flutter#131230) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4fded78e5a01 to ceb2674e82b4 (2 revisions) (flutter/flutter#131229) 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from ff02fa72acce to 4fded78e5a01 (2 revisions) (flutter/flutter#131225) 2023-07-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from a489c7496268 to ff02fa72acce (1 revision) (flutter/flutter#131221) 2023-07-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 815b97157dc7 to a489c7496268 (3 revisions) (flutter/flutter#131218) 2023-07-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2b8d83fa20e3 to 815b97157dc7 (5 revisions) (flutter/flutter#131214) 2023-07-24 ian@hixie.ch Use toStringAsFixed in DecorationImage.toString (flutter/flutter#131026) 2023-07-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from aa876f6bec69 to 2b8d83fa20e3 (3 revisions) (flutter/flutter#131207) 2023-07-24 tessertaha@gmail.com Fix M3 TimePicker dial background uses incorrect color (flutter/flutter#131045) 2023-07-24 leroux_bruno@yahoo.fr Fix floating SnackBar throws when FAB is on the top (flutter/flutter#129274) 2023-07-24 goderbauer@google.com Update link to unbounded constraints error (flutter/flutter#131205) 2023-07-24 thkim1011@users.noreply.github.com Optimize SliverMainAxisGroup/SliverCrossAxisGroup paint function (flutter/flutter#129310) 2023-07-24 61322712+sabin26@users.noreply.github.com [DropdownMenu] Close menu after editing is complete (flutter/flutter#130710) 2023-07-24 christopherfujino@gmail.com Reduce usage of testUsingContext (flutter/flutter#131078) 2023-07-24 engine-flutter-autoroll@skia.org Roll Packages from 2266a76 to 8028caf (13 revisions) (flutter/flutter#131196) 2023-07-24 Lexycon@users.noreply.github.com Fix material date picker behavior when changing year (flutter/flutter#130486) 2023-07-24 jason-simmons@users.noreply.github.com Update Gallery demo app themes for Material3 compatibility (flutter/flutter#131093) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #47161