Skip to content

Fix material date picker behavior when changing year #130486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 6 commits into from
Jul 24, 2023
Merged

Fix material date picker behavior when changing year #130486

auto-submit merged 6 commits into from
Jul 24, 2023

Conversation

@Lexycon
Copy link
Contributor

@Lexycon Lexycon commented Jul 13, 2023 •
edited by HansMuller
Loading

This PR changes the material date picker behavior when changing the year so that it matches the native picker and the material component guideline. (#81547)

See material component guideline for the date picker: Material component date-picker behavior
See also: Material components android discussion

When selecting another year in the native picker, the same day will be selected (by respecting the boundaries of the date picker). The current material date picker does not select any day when changing the year. This will lead to confusion if the user presses OK and the year does not get updated.

So here is my suggestion:
It will try to preselect the day like the native picker:

  • respecting the boundaries of the date picker (firstDate, lastDate)
  • changing from leapyear 29th february will set 28th february if not a leapyear is selected
  • only set the day if it is selectable (selectableDayPredicate)

The calendar shown in the recording was setup with this parameters:

firstDate: DateTime(2016, DateTime.june, 9),
initialDate: DateTime(2018, DateTime.may, 4),
lastDate: DateTime(2021, DateTime.january, 15),
Android-Date-Picker-changes.mov

Fixes #81547

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@dberchtenbreiter-beurer
Fix changing year does change the selected day if the day is selectab…
f5e52e3 
…le. Respects boundaries of firstDate and lastDate.
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 13, 2023
@Lexycon Lexycon changed the title Fix material date picker changing year behavior Fix material date picker behavior when changing year Jul 13, 2023
HansMuller
HansMuller approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good fix. @TahaTesser - please take a look

TahaTesser
TahaTesser requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

TahaTesser
TahaTesser approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2023
@auto-submit auto-submit bot merged commit 2a1f26c into flutter:master Jul 24, 2023
@Lexycon Lexycon deleted the fix81547 branch July 25, 2023 10:52
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2023
@engine-flutter-autoroll
2a1f26c Fix material date picker behavior when changing year (flutter…
c8f90cc 
…/flutter#130486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2023
@engine-flutter-autoroll
2a1f26c Fix material date picker behavior when changing year (flutter…
bbe124e 
…/flutter#130486)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 25, 2023
@engine-flutter-autoroll
Roll Flutter from d7ed5dc to 9def8f6 (21 revisions) (#4561)
406eac1 
flutter/flutter@d7ed5dc...9def8f6

2023-07-25 xxxx.xyzs.xxxx@gmail.com Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. (flutter/flutter#130484)
2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7a842ee9ccd to 036c58f79307 (1 revision) (flutter/flutter#131244)
2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3baca2fe55c8 to a7a842ee9ccd (1 revision) (flutter/flutter#131243)
2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9a0192d965e0 to 3baca2fe55c8 (1 revision) (flutter/flutter#131241)
2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from ceb2674e82b4 to 9a0192d965e0 (3 revisions) (flutter/flutter#131230)
2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4fded78e5a01 to ceb2674e82b4 (2 revisions) (flutter/flutter#131229)
2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from ff02fa72acce to 4fded78e5a01 (2 revisions) (flutter/flutter#131225)
2023-07-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from a489c7496268 to ff02fa72acce (1 revision) (flutter/flutter#131221)
2023-07-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 815b97157dc7 to a489c7496268 (3 revisions) (flutter/flutter#131218)
2023-07-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2b8d83fa20e3 to 815b97157dc7 (5 revisions) (flutter/flutter#131214)
2023-07-24 ian@hixie.ch Use toStringAsFixed in DecorationImage.toString (flutter/flutter#131026)
2023-07-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from aa876f6bec69 to 2b8d83fa20e3 (3 revisions) (flutter/flutter#131207)
2023-07-24 tessertaha@gmail.com Fix M3 TimePicker dial background uses incorrect color (flutter/flutter#131045)
2023-07-24 leroux_bruno@yahoo.fr Fix floating SnackBar throws when FAB is on the top (flutter/flutter#129274)
2023-07-24 goderbauer@google.com Update link to unbounded constraints error (flutter/flutter#131205)
2023-07-24 thkim1011@users.noreply.github.com Optimize SliverMainAxisGroup/SliverCrossAxisGroup paint function (flutter/flutter#129310)
2023-07-24 61322712+sabin26@users.noreply.github.com [DropdownMenu] Close menu after editing is complete (flutter/flutter#130710)
2023-07-24 christopherfujino@gmail.com Reduce usage of testUsingContext (flutter/flutter#131078)
2023-07-24 engine-flutter-autoroll@skia.org Roll Packages from 2266a76 to 8028caf (13 revisions) (flutter/flutter#131196)
2023-07-24 Lexycon@users.noreply.github.com Fix material date picker behavior when changing year (flutter/flutter#130486)
2023-07-24 jason-simmons@users.noreply.github.com Update Gallery demo app themes for Material3 compatibility (flutter/flutter#131093)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Jul 28, 2023
Closed
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@Lexycon @LouiseHsu
Fix material date picker behavior when changing year (flutter#130486)
2abd6c9 
This PR changes the material date picker behavior when changing the year so that it matches the native picker and the material component guideline. (flutter#81547)

See material component guideline for the date picker: [Material component date-picker behavior](https://m3.material.io/components/date-pickers/guidelines#1531a81f-4052-4a75-a20d-228c7e110156)
See also: [Material components android discussion](material-components/material-components-android#1723)

When selecting another year in the native picker, the same day will be selected (by respecting the boundaries of the date picker). The current material date picker does not select any day when changing the year. This will lead to confusion if the user presses OK and the year does not get updated.

So here is my suggestion:
It will try to preselect the day like the native picker:
 - respecting the boundaries of the date picker (firstDate, lastDate)
 - changing from leapyear 29th february will set 28th february if not a leapyear is selected
 - only set the day if it is selectable (selectableDayPredicate)

The calendar shown in the recording was setup with this parameters:
```
firstDate: DateTime(2016, DateTime.june, 9),
initialDate: DateTime(2018, DateTime.may, 4),
lastDate: DateTime(2021, DateTime.january, 15),
```
 
https://github.com/flutter/flutter/assets/13588771/3041c296-b9d0-4078-88cd-d1135fc343b3

Fixes flutter#81547
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
@Lexycon @vashworth
Fix material date picker behavior when changing year (flutter#130486)
2978ad3 
This PR changes the material date picker behavior when changing the year so that it matches the native picker and the material component guideline. (flutter#81547)

See material component guideline for the date picker: [Material component date-picker behavior](https://m3.material.io/components/date-pickers/guidelines#1531a81f-4052-4a75-a20d-228c7e110156)
See also: [Material components android discussion](material-components/material-components-android#1723)

When selecting another year in the native picker, the same day will be selected (by respecting the boundaries of the date picker). The current material date picker does not select any day when changing the year. This will lead to confusion if the user presses OK and the year does not get updated.

So here is my suggestion:
It will try to preselect the day like the native picker:
 - respecting the boundaries of the date picker (firstDate, lastDate)
 - changing from leapyear 29th february will set 28th february if not a leapyear is selected
 - only set the day if it is selectable (selectableDayPredicate)

The calendar shown in the recording was setup with this parameters:
```
firstDate: DateTime(2016, DateTime.june, 9),
initialDate: DateTime(2018, DateTime.may, 4),
lastDate: DateTime(2021, DateTime.january, 15),
```
 
https://github.com/flutter/flutter/assets/13588771/3041c296-b9d0-4078-88cd-d1135fc343b3

Fixes flutter#81547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unexpected showDatePicker behavior when changing year

4 participants

@Lexycon @HansMuller @TahaTesser @dberchtenbreiter-beurer