Skip to content

[tool] In flutter doctor -v, warn when Android Studio version could not be detected. #126395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 13 commits into from
Jun 1, 2023
Merged

[tool] In flutter doctor -v, warn when Android Studio version could not be detected. #126395

auto-submit merged 13 commits into from
Jun 1, 2023

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented May 10, 2023 •
edited
Loading

Fixes #122081.

When validating an Android Studio installation, add a warning validation message when we are unable to detect the version. This is because we have logic throughout the tool (JDK/JRE-searching) that is at higher risk of failing when we don't know the version.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 10, 2023
@andrewkolos andrewkolos force-pushed the warn-as-no-version branch from ad64bb2 to b22f061 Compare May 30, 2023 20:47
@github-actions github-actions bot removed the tool Affects the "flutter" command-line tool. See also t: labels. label May 30, 2023
@andrewkolos andrewkolos marked this pull request as ready for review May 30, 2023 20:55
@andrewkolos andrewkolos requested a review from eliasyishak May 30, 2023 20:56
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 30, 2023
@eliasyishak
Copy link
Contributor

eliasyishak commented May 31, 2023

Is this ready for review? I'm noticing two tests that are failing but they could be flakes?

@andrewkolos
Copy link
Contributor Author

andrewkolos commented May 31, 2023

Is this ready for review? I'm noticing two tests that are failing but they could be flakes?

Yup. These were devicelab issues

@andrewkolos @eliasyishak
Apply suggestions from code review
76f2fff 
Co-authored-by: Elias Yishak <42216813+eliasyishak@users.noreply.github.com>
@github-actions github-actions bot removed the tool Affects the "flutter" command-line tool. See also t: labels. label May 31, 2023
@andrewkolos andrewkolos requested a review from eliasyishak May 31, 2023 23:43
eliasyishak
eliasyishak approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@eliasyishak eliasyishak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 1, 2023
@auto-submit auto-submit bot merged commit 13db2e4 into flutter:master Jun 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2023
@engine-flutter-autoroll
13db2e4 [tool] In flutter doctor -v, warn when Android Studio versi…
f79ea3a 
…on could not be detected. (flutter/flutter#126395)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 5, 2023
@engine-flutter-autoroll
Roll Flutter from 3db9504 to 0b74153 (108 revisions) (#4135)
db4e5c2 
Roll Flutter from 3db9504 to 0b74153 (108 revisions)

flutter/flutter@3db9504...0b74153

2023-06-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 54293721816a to c838a1b05924 (2 revisions) (flutter/flutter#128161)
2023-06-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8769e9ce3a90 to 54293721816a (8 revisions) (flutter/flutter#128158)
2023-06-03 goderbauer@google.com Prefix for dart:ui multiview change (flutter/flutter#128152)
2023-06-02 aam@google.com Roll dds dependency to 2.8.3 for expression evaluation upcoming fixes. (flutter/flutter#128124)
2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3f6a020595d to 8769e9ce3a90 (3 revisions) (flutter/flutter#128149)
2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from b4250acbf3ca to f3f6a020595d (3 revisions) (flutter/flutter#128147)
2023-06-02 flar@google.com Reland "Remove obsolete drawShadow bounds workaround (#127052)" (flutter/flutter#127231)
2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from c6e9383f2143 to b4250acbf3ca (8 revisions) (flutter/flutter#128142)
2023-06-02 goderbauer@google.com Pre-migration for dart:ui multi view changes (flutter/flutter#128092)
2023-06-02 goderbauer@google.com Remove LiveTestRenderView (flutter/flutter#127882)
2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 02d6fbb68b69 to c6e9383f2143 (15 revisions) (flutter/flutter#128119)
2023-06-02 5236035+fzyzcjy@users.noreply.github.com Tiny remove unnecessary method in text_selection.dart (flutter/flutter#127480)
2023-06-02 vashworth@google.com Workaround for Dart VM timeout (flutter/flutter#127875)
2023-06-02 goderbauer@google.com Make --flutter-repo analyze whole repo (flutter/flutter#127990)
2023-06-02 engine-flutter-autoroll@skia.org Roll Packages from f0513ae to 75085ed (3 revisions) (flutter/flutter#128121)
2023-06-02 50433979+natsuk4ze@users.noreply.github.com [Refactor] fix quote style in template (flutter/flutter#127762)
2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3a453f2ccb77 to 02d6fbb68b69 (14 revisions) (flutter/flutter#128089)
2023-06-02 goderbauer@google.com Fix typos in labels (flutter/flutter#128093)
2023-06-02 zanderso@users.noreply.github.com Revert "Fix issue where DevTools would not be immediately available when using --start-paused" (flutter/flutter#128117)
2023-06-02 goderbauer@google.com Sync Lints (flutter/flutter#127976)
2023-06-02 hans.muller@gmail.com Updated TabBar and ToggleButtons examples (flutter/flutter#128088)
2023-06-02 36861262+QuncCccccc@users.noreply.github.com Text should still be centered when search bar height is less than 48 (flutter/flutter#128068)
2023-06-02 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#128053)
2023-06-01 tessertaha@gmail.com Add `FilterChip.elevated`, `ChoiceChip.elevated`, & `ActionChip.elevated` variants (flutter/flutter#128049)
2023-06-01 hans.muller@gmail.com Updated custom ListTile examples (flutter/flutter#128071)
2023-06-01 bkonyi@google.com Fix issue where DevTools would not be immediately available when using --start-paused (flutter/flutter#126698)
2023-06-01 katelovett@google.com Add error message when sliver overlap absorber is missing (flutter/flutter#128075)
2023-06-01 hans.muller@gmail.com Updated Menu examples (flutter/flutter#128080)
2023-06-01 5236035+fzyzcjy@users.noreply.github.com Add retry flag to flutter_test (flutter/flutter#125851)
2023-06-01 christopherfujino@gmail.com [flutter_tools] Use process matcher for multidex test (flutter/flutter#127996)
2023-06-01 hans.muller@gmail.com Updated InputDecoratorExamples for M3 (flutter/flutter#128065)
2023-06-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c0a639efd0a to 3a453f2ccb77 (1 revision) (flutter/flutter#128064)
2023-06-01 christopherfujino@gmail.com migrate the package_autoroller from querying by label to title (flutter/flutter#128066)
2023-06-01 hans.muller@gmail.com Revised Floating Action Button examples (flutter/flutter#128058)
2023-06-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from fdd39c421fb9 to 7c0a639efd0a (2 revisions) (flutter/flutter#128056)
2023-06-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from c8e1a8d6fb57 to fdd39c421fb9 (1 revision) (flutter/flutter#128050)
2023-06-01 chillers@google.com [labeler] Remove use of any (flutter/flutter#128011)
2023-06-01 jonahwilliams@google.com [framework] remove reference to closed issue. (flutter/flutter#128007)
2023-06-01 engine-flutter-autoroll@skia.org Roll Packages from 95bb793 to f0513ae (3 revisions) (flutter/flutter#128045)
2023-06-01 vasilich6107@users.noreply.github.com Add fallback font to IconData class (flutter/flutter#127269)
2023-06-01 mdebbar@google.com [web] Assert route names start with / if using PathUrlStrategy (flutter/flutter#127986)
2023-06-01 andrewrkolos@gmail.com [tool] In `flutter doctor -v`, warn when Android Studio version could not be detected. (flutter/flutter#126395)
2023-06-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8339c71a963c to c8e1a8d6fb57 (1 revision) (flutter/flutter#128035)
2023-06-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc81133892a6 to 8339c71a963c (1 revision) (flutter/flutter#128034)
2023-06-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from e235f47164fa to bc81133892a6 (1 revision) (flutter/flutter#128026)
2023-06-01 72562119+tgucio@users.noreply.github.com Fixes in Cupertino translations (flutter/flutter#127872)
...
@andrewkolos andrewkolos deleted the warn-as-no-version branch June 15, 2023 01:00
@andrewkolos andrewkolos mentioned this pull request Jun 20, 2023
Closed
3 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
13db2e4 [tool] In flutter doctor -v, warn when Android Studio versi…
b929cbc 
…on could not be detected. (flutter/flutter#126395)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
13db2e4 [tool] In flutter doctor -v, warn when Android Studio versi…
50ed8cb 
…on could not be detected. (flutter/flutter#126395)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
13db2e4 [tool] In flutter doctor -v, warn when Android Studio versi…
fdcc268 
…on could not be detected. (flutter/flutter#126395)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
13db2e4 [tool] In flutter doctor -v, warn when Android Studio versi…
dd6d308 
…on could not be detected. (flutter/flutter#126395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eliasyishak eliasyishak eliasyishak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flutter doctor should explicitly say when it can't find Android Studio version

2 participants

@andrewkolos @eliasyishak