-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Closed
Copy link
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listplatform-androidAndroid applications specificallyAndroid applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.
Description
When the tool isn't able to identify what version an Android Studio installation is, that can cause the build to fail because some logic depends on the Android Studio version. For example:
- Explicitly configured Android Studio is always treated as ancient version, breaking build #121468
- Tool can't parse version of Android Studio Preview on macOS #121925
So when someone's running flutter doctor -v because things have gone wrong, the fact that the Android Studio version couldn't be identified is potentially a quite important clue for resolving the problem.
Currently, though, the flutter doctor output just suppresses mention of the version when it doesn't know the answer:
// in [AndroidStudioValidator.validate]
final String? studioVersionText = _studio.version == Version.unknown
? null
: userMessages.androidStudioVersion(_studio.version.toString());The result is a line like
[!] Android Studio
instead of like
[✓] Android Studio (version 2022.3)
This is too subtle; e.g. in #121925 it wasn't noticed in the first few rounds of debugging. It should instead say something like:
[!] Android Studio (unknown version)
or perhaps somewhat louder than that.
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listplatform-androidAndroid applications specificallyAndroid applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.