tool-web: use ProcessUtil.run to invoke child processes #126109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All invocations are logged on verbose Better, more detailed exceptions are thrown on errors A lot less boilerplate
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
harryterkelsen
approved these changes
May 4, 2023
Contributor
harryterkelsen
left a comment
There was a problem hiding this comment.
LGTM with typo nit
| environment.logger.printWarning('Warning: dart2js did not produced expected deps list at ' | ||
| '${dart2jsDeps.path}'); | ||
| environment.logger.printWarning( | ||
| 'Warning: dart2js did not produced expected deps list at ' |
Contributor
There was a problem hiding this comment.
nit: produced -> produce
Contributor
Author
There was a problem hiding this comment.
Ha! Uh. Exercise for later. This is just code reflow and not any change I made
Contributor
There was a problem hiding this comment.
we should fix it now, it's trivial to fix and makes the product better :-)
Contributor
There was a problem hiding this comment.
looks like this wasn't fixed in the version that landed?
Contributor
|
test-exempt: code refactor with no semantic change |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2023
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
May 6, 2023
Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@0b65723...43ac23b 2023-05-05 kevmoo@users.noreply.github.com targets/web.dart - fix typo (flutter/flutter#126114) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175) 2023-05-05 44755140+werainkhatri@users.noreply.github.com add tests for dominant bottom sheet in scaffold (flutter/flutter#124472) 2023-05-05 98486346+lindsaypj@users.noreply.github.com Added CupertinoDatepicker monthYear mode (flutter#93508) (flutter/flutter#125603) 2023-05-05 36861262+QuncCccccc@users.noreply.github.com Add `Switch.trackOutlineWidth` property (flutter/flutter#125848) 2023-05-05 47866232+chunhtai@users.noreply.github.com Rename iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174) 2023-05-05 49291509+albertoazinar@users.noreply.github.com improvement : removed required kotlin dependency (flutter/flutter#125002) 2023-05-05 b7woreo@gmail.com Fix incorrect assert hint in flutter.groovy (flutter/flutter#125283) 2023-05-05 102626803+drewroengoogle@users.noreply.github.com Update .cirrus.yml (flutter/flutter#126166) 2023-05-05 kevmoo@users.noreply.github.com tool: replace top-level functions with enum properties (flutter/flutter#126167) 2023-05-05 jacksongardner@google.com Use direct dart API from `dart:ui_web` rather than JS shim. (flutter/flutter#123443) 2023-05-05 68919043+Istiak-Ahmed78@users.noreply.github.com Add sample code for SliverAppBar (flutter/flutter#125785) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163) 2023-05-05 leroux_bruno@yahoo.fr Add a ReorderableListView example with cards + cleanup existing tests (flutter/flutter#126155) 2023-05-05 engine-flutter-autoroll@skia.org Roll Packages from 6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161) 2023-05-05 102626803+drewroengoogle@users.noreply.github.com Bring back the failing build_test's (flutter/flutter#126014) 2023-05-05 mdebbar@google.com [web] Use plain platform views in benchmarks (flutter/flutter#126080) 2023-05-05 tessertaha@gmail.com Fix Material 3 tab indicator weight and position (flutter/flutter#125883) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129) 2023-05-05 pateltirth454@gmail.com [NavigationDrawer] adds padding property in NavigationDrawer Widget (flutter/flutter#123961) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115) 2023-05-05 ian@hixie.ch Minor fixes found while working on blankcanvas (flutter/flutter#125751) 2023-05-05 kevmoo@users.noreply.github.com tool-web: use ProcessUtil.run to invoke child processes (flutter/flutter#126109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...
2 tasks
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
) Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@0b65723...43ac23b 2023-05-05 kevmoo@users.noreply.github.com targets/web.dart - fix typo (flutter/flutter#126114) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175) 2023-05-05 44755140+werainkhatri@users.noreply.github.com add tests for dominant bottom sheet in scaffold (flutter/flutter#124472) 2023-05-05 98486346+lindsaypj@users.noreply.github.com Added CupertinoDatepicker monthYear mode (flutter#93508) (flutter/flutter#125603) 2023-05-05 36861262+QuncCccccc@users.noreply.github.com Add `Switch.trackOutlineWidth` property (flutter/flutter#125848) 2023-05-05 47866232+chunhtai@users.noreply.github.com Rename iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174) 2023-05-05 49291509+albertoazinar@users.noreply.github.com improvement : removed required kotlin dependency (flutter/flutter#125002) 2023-05-05 b7woreo@gmail.com Fix incorrect assert hint in flutter.groovy (flutter/flutter#125283) 2023-05-05 102626803+drewroengoogle@users.noreply.github.com Update .cirrus.yml (flutter/flutter#126166) 2023-05-05 kevmoo@users.noreply.github.com tool: replace top-level functions with enum properties (flutter/flutter#126167) 2023-05-05 jacksongardner@google.com Use direct dart API from `dart:ui_web` rather than JS shim. (flutter/flutter#123443) 2023-05-05 68919043+Istiak-Ahmed78@users.noreply.github.com Add sample code for SliverAppBar (flutter/flutter#125785) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163) 2023-05-05 leroux_bruno@yahoo.fr Add a ReorderableListView example with cards + cleanup existing tests (flutter/flutter#126155) 2023-05-05 engine-flutter-autoroll@skia.org Roll Packages from 6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161) 2023-05-05 102626803+drewroengoogle@users.noreply.github.com Bring back the failing build_test's (flutter/flutter#126014) 2023-05-05 mdebbar@google.com [web] Use plain platform views in benchmarks (flutter/flutter#126080) 2023-05-05 tessertaha@gmail.com Fix Material 3 tab indicator weight and position (flutter/flutter#125883) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129) 2023-05-05 pateltirth454@gmail.com [NavigationDrawer] adds padding property in NavigationDrawer Widget (flutter/flutter#123961) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115) 2023-05-05 ian@hixie.ch Minor fixes found while working on blankcanvas (flutter/flutter#125751) 2023-05-05 kevmoo@users.noreply.github.com tool-web: use ProcessUtil.run to invoke child processes (flutter/flutter#126109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All invocations are logged on verbose
Better, more detailed exceptions are thrown on errors
A lot less boilerplate