Fix Material 3 tab indicator weight and position #125883

TahaTesser · 2023-05-02T14:32:44Z

Description

Add proper M3 indicator height akaIndictorWeight from the M3 specs for the primary tab bar with label indicator size.

flutter/dev/tools/gen_defaults/data/navigation_tab_primary.json

Line 9 in db6074a

"md.comp.primary-navigation-tab.active-indicator.height": 3.0,

(this was held due to indicatorWeight having a hard-coded value)

and added a secondary tab bar indicator height.
2. Set a minimum value for the rounded indicator to maintain the indicator shape.
3. With proper indicator height, the rounded indicator position is also fixed.
4. Fix round indicator is shown for the primary tab bar with tab indicator size.
5. Above changes fix #123112.
6. Fix the startOffset const value from #125036 to match docs and move it to a variable.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-05-02T15:07:14Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #125883 at sha e6c8a1acc167eec2a568cbf44e2254cd0d2cc7c3

Piinks · 2023-05-02T16:55:39Z

packages/flutter/lib/src/material/tabs.dart

Why is it overridden for values < 3.0?

This preserves the rounded indicator shape and overrides the 2.0 indicator weight.

flutter/packages/flutter/lib/src/material/tabs.dart

Line 715 in 4d38f94

this.indicatorWeight = 2.0,

If the value is less than 3.0, this indicator shape cannot be maintained. This has rounded corners, unlike the tab indicator size indicator.

packages/flutter/lib/src/material/tabs.dart

flutter-dashboard · 2023-05-03T12:07:16Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #125883 at sha 1e0d21e8bef46a8695259f6f3f62bd192a6a2b6e

Piinks

LGTM!

Piinks · 2023-05-04T19:44:52Z

Goldens are approved. Thank you!

…tter#125883)

Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@0b65723...43ac23b 2023-05-05 kevmoo@users.noreply.github.com targets/web.dart - fix typo (flutter/flutter#126114) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175) 2023-05-05 44755140+werainkhatri@users.noreply.github.com add tests for dominant bottom sheet in scaffold (flutter/flutter#124472) 2023-05-05 98486346+lindsaypj@users.noreply.github.com Added CupertinoDatepicker monthYear mode (flutter#93508) (flutter/flutter#125603) 2023-05-05 36861262+QuncCccccc@users.noreply.github.com Add `Switch.trackOutlineWidth` property (flutter/flutter#125848) 2023-05-05 47866232+chunhtai@users.noreply.github.com Rename iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174) 2023-05-05 49291509+albertoazinar@users.noreply.github.com improvement : removed required kotlin dependency (flutter/flutter#125002) 2023-05-05 b7woreo@gmail.com Fix incorrect assert hint in flutter.groovy (flutter/flutter#125283) 2023-05-05 102626803+drewroengoogle@users.noreply.github.com Update .cirrus.yml (flutter/flutter#126166) 2023-05-05 kevmoo@users.noreply.github.com tool: replace top-level functions with enum properties (flutter/flutter#126167) 2023-05-05 jacksongardner@google.com Use direct dart API from `dart:ui_web` rather than JS shim. (flutter/flutter#123443) 2023-05-05 68919043+Istiak-Ahmed78@users.noreply.github.com Add sample code for SliverAppBar (flutter/flutter#125785) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163) 2023-05-05 leroux_bruno@yahoo.fr Add a ReorderableListView example with cards + cleanup existing tests (flutter/flutter#126155) 2023-05-05 engine-flutter-autoroll@skia.org Roll Packages from 6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161) 2023-05-05 102626803+drewroengoogle@users.noreply.github.com Bring back the failing build_test's (flutter/flutter#126014) 2023-05-05 mdebbar@google.com [web] Use plain platform views in benchmarks (flutter/flutter#126080) 2023-05-05 tessertaha@gmail.com Fix Material 3 tab indicator weight and position (flutter/flutter#125883) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129) 2023-05-05 pateltirth454@gmail.com [NavigationDrawer] adds padding property in NavigationDrawer Widget (flutter/flutter#123961) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115) 2023-05-05 ian@hixie.ch Minor fixes found while working on blankcanvas (flutter/flutter#125751) 2023-05-05 kevmoo@users.noreply.github.com tool-web: use ProcessUtil.run to invoke child processes (flutter/flutter#126109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

) Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@0b65723...43ac23b 2023-05-05 kevmoo@users.noreply.github.com targets/web.dart - fix typo (flutter/flutter#126114) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175) 2023-05-05 44755140+werainkhatri@users.noreply.github.com add tests for dominant bottom sheet in scaffold (flutter/flutter#124472) 2023-05-05 98486346+lindsaypj@users.noreply.github.com Added CupertinoDatepicker monthYear mode (flutter#93508) (flutter/flutter#125603) 2023-05-05 36861262+QuncCccccc@users.noreply.github.com Add `Switch.trackOutlineWidth` property (flutter/flutter#125848) 2023-05-05 47866232+chunhtai@users.noreply.github.com Rename iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174) 2023-05-05 49291509+albertoazinar@users.noreply.github.com improvement : removed required kotlin dependency (flutter/flutter#125002) 2023-05-05 b7woreo@gmail.com Fix incorrect assert hint in flutter.groovy (flutter/flutter#125283) 2023-05-05 102626803+drewroengoogle@users.noreply.github.com Update .cirrus.yml (flutter/flutter#126166) 2023-05-05 kevmoo@users.noreply.github.com tool: replace top-level functions with enum properties (flutter/flutter#126167) 2023-05-05 jacksongardner@google.com Use direct dart API from `dart:ui_web` rather than JS shim. (flutter/flutter#123443) 2023-05-05 68919043+Istiak-Ahmed78@users.noreply.github.com Add sample code for SliverAppBar (flutter/flutter#125785) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163) 2023-05-05 leroux_bruno@yahoo.fr Add a ReorderableListView example with cards + cleanup existing tests (flutter/flutter#126155) 2023-05-05 engine-flutter-autoroll@skia.org Roll Packages from 6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161) 2023-05-05 102626803+drewroengoogle@users.noreply.github.com Bring back the failing build_test's (flutter/flutter#126014) 2023-05-05 mdebbar@google.com [web] Use plain platform views in benchmarks (flutter/flutter#126080) 2023-05-05 tessertaha@gmail.com Fix Material 3 tab indicator weight and position (flutter/flutter#125883) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129) 2023-05-05 pateltirth454@gmail.com [NavigationDrawer] adds padding property in NavigationDrawer Widget (flutter/flutter#123961) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124) 2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115) 2023-05-05 ian@hixie.ch Minor fixes found while working on blankcanvas (flutter/flutter#125751) 2023-05-05 kevmoo@users.noreply.github.com tool-web: use ProcessUtil.run to invoke child processes (flutter/flutter#126109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

…tter#125883)

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 2, 2023

TahaTesser requested a review from Piinks May 2, 2023 14:32

flutter-dashboard bot added the will affect goldens Changes to golden files label May 2, 2023

Piinks added c: new feature Nothing broken; request for a new capability a: fidelity Matching the OEM platforms better a: quality A truly polished experience labels May 2, 2023

Piinks reviewed May 2, 2023

View reviewed changes

packages/flutter/lib/src/material/tabs.dart Outdated Show resolved Hide resolved

Piinks reviewed May 2, 2023

View reviewed changes

packages/flutter/lib/src/material/tabs.dart Outdated Show resolved Hide resolved

TahaTesser requested a review from Piinks May 3, 2023 12:30

TahaTesser mentioned this pull request May 3, 2023

Fix Material 3 Scrollable TabBar #125974

Merged

8 tasks

Piinks approved these changes May 4, 2023

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 4, 2023

TahaTesser added 2 commits May 5, 2023 15:17

Fix Material 3 tab indicator weight and position

a967f1d

Update indicatorWeight and docs

d3e644d

auto-submit bot merged commit ad009fb into flutter:master May 5, 2023

TahaTesser deleted the fix_indicator_weight_and_position branch May 5, 2023 14:20

engine-flutter-autoroll mentioned this pull request May 5, 2023

Roll Flutter from 0b657236cae4 to 28f30377582a (13 revisions) flutter/packages#3912

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023

ad009fb Fix Material 3 tab indicator weight and position (flutter/flu…

2bd211a

…tter#125883)

engine-flutter-autoroll mentioned this pull request May 5, 2023

Roll Flutter from 0b657236cae4 to 9de9a81b809e (14 revisions) flutter/packages#3913

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023

ad009fb Fix Material 3 tab indicator weight and position (flutter/flu…

c96456d

…tter#125883)

engine-flutter-autoroll mentioned this pull request May 5, 2023

Roll Flutter from 0b657236cae4 to e24de32760bc (15 revisions) flutter/packages#3914

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023

ad009fb Fix Material 3 tab indicator weight and position (flutter/flu…

a0d3690

…tter#125883)

engine-flutter-autoroll mentioned this pull request May 5, 2023

Roll Flutter from 0b657236cae4 to de2615462c02 (16 revisions) flutter/packages#3915

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023

ad009fb Fix Material 3 tab indicator weight and position (flutter/flu…

295f763

…tter#125883)

engine-flutter-autoroll mentioned this pull request May 5, 2023

Roll Flutter from 0b657236cae4 to f57d38f7f233 (17 revisions) flutter/packages#3917

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023

ad009fb Fix Material 3 tab indicator weight and position (flutter/flu…

402a333

…tter#125883)

engine-flutter-autoroll mentioned this pull request May 5, 2023

Roll Flutter from 0b657236cae4 to 042eaf6b90b3 (18 revisions) flutter/packages#3918

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023

ad009fb Fix Material 3 tab indicator weight and position (flutter/flu…

fd2edb0

…tter#125883)

HansMuller mentioned this pull request May 5, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll mentioned this pull request May 5, 2023

Roll Flutter from 0b657236cae4 to 201f7311f7c0 (19 revisions) flutter/packages#3919

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023

ad009fb Fix Material 3 tab indicator weight and position (flutter/flu…

85453b0

…tter#125883)

engine-flutter-autoroll mentioned this pull request May 5, 2023

Manual roll Flutter from 0b657236cae4 to 201f7311f7c0 (19 revisions) flutter/packages#3920

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023

ad009fb Fix Material 3 tab indicator weight and position (flutter/flu…

37dbdaf

…tter#125883)

engine-flutter-autoroll mentioned this pull request May 6, 2023

Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions) flutter/packages#3922

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2023

ad009fb Fix Material 3 tab indicator weight and position (flutter/flu…

5c34b57

…tter#125883)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

ad009fb Fix Material 3 tab indicator weight and position (flutter/flu…

faa7780

…tter#125883)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

ad009fb Fix Material 3 tab indicator weight and position (flutter/flu…

2c16eaa

…tter#125883)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

ad009fb Fix Material 3 tab indicator weight and position (flutter/flu…

368ae3f

…tter#125883)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

ad009fb Fix Material 3 tab indicator weight and position (flutter/flu…

c5b0472

…tter#125883)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Material 3 tab indicator weight and position #125883

Fix Material 3 tab indicator weight and position #125883

Uh oh!

TahaTesser commented May 2, 2023 •

edited

Loading

Uh oh!

flutter-dashboard bot commented May 2, 2023

Uh oh!

Piinks May 2, 2023

Uh oh!

TahaTesser May 3, 2023

Uh oh!

Uh oh!

Uh oh!

flutter-dashboard bot commented May 3, 2023

Uh oh!

Piinks left a comment

Uh oh!

Piinks commented May 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix Material 3 tab indicator weight and position #125883

Fix Material 3 tab indicator weight and position #125883

Uh oh!

Conversation

TahaTesser commented May 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented May 2, 2023

Uh oh!

Piinks May 2, 2023

Choose a reason for hiding this comment

Uh oh!

TahaTesser May 3, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

flutter-dashboard bot commented May 3, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented May 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TahaTesser commented May 2, 2023 •

edited

Loading