Skip to content

Match iOS Longpress behavior with native #123630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Mar 29, 2023
Merged

Match iOS Longpress behavior with native #123630

auto-submit merged 5 commits into from
Mar 29, 2023

Conversation

@Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Mar 28, 2023 •
edited
Loading

This change adds the ability to long press to select word-by-word when the long press starts on an unfocused TextField. Behavior when TextField is focused remains the same (moves the cursor).

Fixes #35010

RPReplay-Final1680030321.MP4

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 28, 2023
@Renzo-Olivares Renzo-Olivares changed the title Longpress ios Match iOS Longpress behavior with native Mar 28, 2023
@Renzo-Olivares Renzo-Olivares requested a review from justinmc March 28, 2023 19:13
justinmc
justinmc approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when the tests are green.

@Renzo-Olivares Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2023
@auto-submit auto-submit bot merged commit 142dd60 into flutter:master Mar 29, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
7e6732e 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
8f5105e 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
6e1f71b 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
98f666a 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
ad31e72 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
30818f8 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
f162331 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
8c0f001 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
d0a126f 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
9e24a3c 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
ba65aea 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
9d941c0 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
89f0785 
)
@HansMuller HansMuller mentioned this pull request Mar 31, 2023
Closed
@reidbaker reidbaker mentioned this pull request Apr 1, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
1bef3fd 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
29454bd 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
72f4ecc 
)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@Renzo-Olivares @exaby73
Match iOS Longpress behavior with native (flutter#123630)
1d9d49f 
Match iOS Longpress behavior with native
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
ac09175 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
142dd60 Match iOS Longpress behavior with native (flutter/flutter#123630
a1c737d 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[iOS 13] Long press and drag to select

2 participants

@Renzo-Olivares @justinmc