Skip to content

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Mar 7, 2023

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 7, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso zanderso added warning: land on red to fix tree breakage revert Autorevert PR (with "Reason for revert:" comment) and removed c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Mar 7, 2023
@zanderso
Copy link
Member Author

zanderso commented Mar 7, 2023

cc @micaelcid

@auto-submit auto-submit bot merged commit 5fbc578 into master Mar 7, 2023
@auto-submit auto-submit bot deleted the revert-109547-master branch March 7, 2023 16:28
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants