[integration_test] upgrade androidx test to 1.4.0 #109547

micaelcid · 2022-08-15T15:35:13Z

I just finished migrating a project to Android 13 that runs integration_test with Firebase Test Lab. In this PR, I am changing the exact dependencies I needed to change to make our application able to run integration tests targeting Android 13. (the project is currently depending on my fork).

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

flutter-dashboard · 2022-08-15T15:35:15Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

google-cla · 2022-08-15T15:35:17Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

flutter-dashboard · 2022-09-04T15:40:45Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

goderbauer · 2023-02-28T23:12:58Z

@reidbaker Can somebody from the Android team please check if this dependency bump makes sense? Thanks!

reidbaker · 2023-03-01T15:59:59Z

Version bump is ok with me adding @ricardoamador in case updates cause us to have to add something our CI.
Not marking "Approved" on the cl until the integration tests pass and the build is up to date with master.

ricardoamador

LGTM

ricardoamador

Can you update the branch and make sure all tests are passing?

micaelcid · 2023-03-01T17:20:04Z

Sure, @ricardoamador! I'll do as soon as I can. :) (Possibly today)

micaelcid · 2023-03-02T11:27:13Z

@ricardoamador taking a glimpse at the failed tests, does it look like something you'd know the cause? Otherwise, is there any available documentation I could use to debug the CI problems myself?

ricardoamador · 2023-03-02T16:25:33Z

@micaelcid If you look at the checks tab it will show you more details. Let me know if you are able to see the LUCI build information.
From taking a look at one of the windows tests it looks like there is a dependency failure:

Execution failed for task ':integration_test:generateDebugRFile'.
 [        ] > Could not resolve all files for configuration ':integration_test:debugCompileClasspath'.
 [        ]    > Did not resolve 'net.sf.kxml:kxml2:2.3.0' which is part of the dependency lock state
 [        ]    > Resolved 'androidx.test.services:storage:1.4.0' which is not part of the dependency lock state
 [        ]    > Could not resolve androidx.test:runner:1.4.0.
 [        ]      Required by:
 [        ]          project :integration_test
 [        ]          project :integration_test > androidx.test:rules:1.4.0
 [        ]          project :integration_test > androidx.test.espresso:espresso-core:3.4.0
 [        ]       > Cannot find a version of 'androidx.test:runner' that satisfies the version constraints:
 [        ]            Dependency path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test:runner:1.4.0'
 [        ]            Constraint path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test:runner:{strictly 1.2.0}' because of the following reason: dependency was locked to version '1.2.0'
 [        ]            Dependency path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test:rules:1.4.0' --> 'androidx.test:runner:1.4.0'
 [        ]            Dependency path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test.espresso:espresso-core:3.4.0' --> 'androidx.test:runner:1.4.0'
 [        ]    > Could not resolve androidx.test:rules:1.4.0.
 [        ]      Required by:
 [        ]          project :integration_test
 [        ]       > Cannot find a version of 'androidx.test:rules' that satisfies the version constraints:
 [        ]            Dependency path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test:rules:1.4.0'
 [        ]            Constraint path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test:rules:{strictly 1.2.0}' because of the following reason: dependency was locked to version '1.2.0'
 [        ]    > Could not resolve androidx.test.espresso:espresso-core:3.4.0.
 [        ]      Required by:
 [        ]          project :integration_test
 [        ]       > Cannot find a version of 'androidx.test.espresso:espresso-core' that satisfies the version constraints:
 [        ]            Dependency path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test.espresso:espresso-core:3.4.0'
 [        ]            Constraint path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test.espresso:espresso-core:{strictly 3.2.0}' because of the following reason: dependency was locked to version '3.2.0'
 [        ]    > Could not resolve androidx.test.espresso:espresso-core:{strictly 3.2.0}.
 [        ]      Required by:
 [        ]          project :integration_test
 [        ]       > Cannot find a version of 'androidx.test.espresso:espresso-core' that satisfies the version constraints:
 [        ]            Dependency path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test.espresso:espresso-core:3.4.0'
 [        ]            Constraint path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test.espresso:espresso-core:{strictly 3.2.0}' because of the following reason: dependency was locked to version '3.2.0'
 [        ]    > Could not resolve androidx.test:runner:{strictly 1.2.0}.
 [        ]      Required by:
 [        ]          project :integration_test
 [        ]       > Cannot find a version of 'androidx.test:runner' that satisfies the version constraints:
 [        ]            Dependency path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test:runner:1.4.0'
 [        ]            Constraint path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test:runner:{strictly 1.2.0}' because of the following reason: dependency was locked to version '1.2.0'
 [        ]            Dependency path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test:rules:1.4.0' --> 'androidx.test:runner:1.4.0'
 [        ]            Dependency path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test.espresso:espresso-core:3.4.0' --> 'androidx.test:runner:1.4.0'
 [        ]    > Could not resolve androidx.test:rules:{strictly 1.2.0}.
 [        ]      Required by:
 [        ]          project :integration_test
 [        ]       > Cannot find a version of 'androidx.test:rules' that satisfies the version constraints:
 [        ]            Dependency path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test:rules:1.4.0'
 [        ]            Constraint path 'com.example.integration_test:integration_test:1.0-SNAPSHOT' --> 'androidx.test:rules:{strictly 1.2.0}' because of the following reason: dependency was locked to version '1.2.0'
 [        ] * Try:

Are you able to see this link?
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8787738512540060369/+/u/run_test.dart_for_build_tests_shard_and_subshard_1_3/test_stdout

micaelcid · 2023-03-02T16:36:25Z

Thanks! I can @ricardoamador, except for Linux firebase_release_smoke_test step that returns only a one-line message:

ricardoamador · 2023-03-02T17:10:37Z

Ah okay. You need to follow the link at the botton of that screen. The one that says 'View more details on flutter-dashboard.' I know it kind of small and can easily be missed. That error is the same though. You can see it here:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8787738512559017217/+/u/test_execution/Build_appbundle/stdout

micaelcid · 2023-03-02T18:02:16Z

Thanks again, I'm totally newbie to open sourcing, but I'll work my way around :)

ricardoamador · 2023-03-02T18:06:00Z

Sure no problem!

auto-submit · 2023-03-06T20:43:03Z

auto label is removed for flutter/flutter, pr: 109547, due to - The status or check suite Mac module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

micaelcid · 2023-03-06T21:43:12Z

Hey, @reidbaker. Thanks for adding the label. It seems the pipeline step failed due to some flakiness. Could you try again, please?

This reverts commit 41fbf46.

…122106) Revert "[integration_test] upgrade androidx test to 1.4.0"

…utter#109547)

flutter-dashboard bot added the f: integration_test The flutter/packages/integration_test plugin label Aug 15, 2022

micaelcid force-pushed the master branch from 3f5501f to c2a0658 Compare October 3, 2022 12:01

[integration_test] upgrade androidx test to 1.4.0

b893b7f

micaelcid force-pushed the master branch from c2a0658 to b893b7f Compare November 22, 2022 14:42

jmagman added the framework flutter/packages/flutter repository. See also f: labels. label Feb 22, 2023

Merge branch 'master' into master

57142e0

goderbauer added the platform-android Android applications specifically label Feb 28, 2023

goderbauer requested a review from reidbaker February 28, 2023 23:13

reidbaker requested a review from ricardoamador March 1, 2023 15:58

ricardoamador approved these changes Mar 1, 2023

View reviewed changes

ricardoamador suggested changes Mar 1, 2023

View reviewed changes

micaelcid added 2 commits March 1, 2023 14:20

Merge branch 'master' into master

768ddef

Merge branch 'master' into master

75102d6

Merge branch 'master' into master

80ccf96

Merge branch 'master' into master

fdab7d8

micaelcid force-pushed the master branch 3 times, most recently from 03b241c to fdab7d8 Compare March 5, 2023 15:30

reidbaker approved these changes Mar 6, 2023

View reviewed changes

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2023

Merge branch 'master' into master

8e0bdd8

micaelcid added 4 commits March 6, 2023 18:54

Merge branch 'master' into master

55bf69a

Merge branch 'master' into master

8e66a59

Merge branch 'master' into master

589cef8

Merge branch 'master' into master

64c9c4a

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2023

auto-submit bot merged commit 41fbf46 into flutter:master Mar 7, 2023

zanderso mentioned this pull request Mar 7, 2023

Revert "[integration_test] upgrade androidx test to 1.4.0" #122106

Merged

zanderso added a commit that referenced this pull request Mar 7, 2023

Revert "[integration_test] upgrade androidx test to 1.4.0 (#109547)"

cb15645

This reverts commit 41fbf46.

auto-submit bot mentioned this pull request Mar 7, 2023

Review request for Revert PR flutter/flutter#122106 #122107

Closed

auto-submit bot pushed a commit that referenced this pull request Mar 7, 2023

Revert "[integration_test] upgrade androidx test to 1.4.0 (#109547)" (#…

5fbc578

…122106) Revert "[integration_test] upgrade androidx test to 1.4.0"

engine-flutter-autoroll mentioned this pull request Mar 8, 2023

Manual roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) flutter/packages#3410

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023

41fbf46 [integration_test] upgrade androidx test to 1.4.0 (flutter/fl…

38b1591

…utter#109547)

engine-flutter-autoroll mentioned this pull request Mar 8, 2023

Roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) flutter/packages#3416

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023

41fbf46 [integration_test] upgrade androidx test to 1.4.0 (flutter/fl…

ac83bad

…utter#109547)

engine-flutter-autoroll mentioned this pull request Mar 8, 2023

Roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) flutter/packages#3418

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023

41fbf46 [integration_test] upgrade androidx test to 1.4.0 (flutter/fl…

379d95a

…utter#109547)

cyanglaz mentioned this pull request Mar 8, 2023

Manual roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) + fixes flutter/packages#3420

Merged

engine-flutter-autoroll mentioned this pull request Mar 8, 2023

Roll Flutter from f2f80059ff87 to 0cf593e79261 (45 revisions) flutter/packages#3421

Closed

micaelcid mentioned this pull request Mar 10, 2023

[integration_test] upgrade androidx test to 1.4.0 #122437

Merged

8 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

41fbf46 [integration_test] upgrade androidx test to 1.4.0 (flutter/fl…

f5ca16b

…utter#109547)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

41fbf46 [integration_test] upgrade androidx test to 1.4.0 (flutter/fl…

33b6425

…utter#109547)

[integration_test] upgrade androidx test to 1.4.0 #109547

[integration_test] upgrade androidx test to 1.4.0 #109547

Uh oh!

Conversation

micaelcid commented Aug 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Aug 15, 2022

Uh oh!

google-cla bot commented Aug 15, 2022

Uh oh!

flutter-dashboard bot commented Sep 4, 2022

Uh oh!

goderbauer commented Feb 28, 2023

Uh oh!

reidbaker commented Mar 1, 2023

Uh oh!

ricardoamador left a comment

Choose a reason for hiding this comment

Uh oh!

ricardoamador left a comment

Choose a reason for hiding this comment

Uh oh!

micaelcid commented Mar 1, 2023

Uh oh!

micaelcid commented Mar 2, 2023

Uh oh!

ricardoamador commented Mar 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

micaelcid commented Mar 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ricardoamador commented Mar 2, 2023

Uh oh!

micaelcid commented Mar 2, 2023

Uh oh!

ricardoamador commented Mar 2, 2023

Uh oh!

auto-submit bot commented Mar 6, 2023

Uh oh!

micaelcid commented Mar 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

micaelcid commented Aug 15, 2022 •

edited

Loading

ricardoamador commented Mar 2, 2023 •

edited

Loading

micaelcid commented Mar 2, 2023 •

edited

Loading