Add PointerScaleEvent and use in InteractiveViewer #112172
Merged
+207
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2022
6b69fae to
5c5c09e
Compare
justinmc
reviewed
Sep 26, 2022
Contributor
justinmc
left a comment
There was a problem hiding this comment.
Thanks for all the InteractiveViewer improvements. This seems reasonable to me. I'll review the engine PR and then come back to this when it's merged. I want to try this on my machine locally once that's merged too.
Contributor
There was a problem hiding this comment.
Why are some of these parameters not used?
Contributor
There was a problem hiding this comment.
I guess PointerPanZoomUpdateEvent.copyWith is doing the same thing below.
Contributor
Author
There was a problem hiding this comment.
The signature has to match PointerEvent.copyWith, but most parameters are not relevant
5c5c09e to
553c4c7
Compare
This was referenced Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 6, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new type of
PointerSignal, and handle it withinInteractiveViewer. For use in trackpad pinch-to-zoom where full gesture information is unavailable (web).Part of #112103
Sequence
Pre-launch Checklist
///).