This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add discrete scale pointer signal #36342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2022
4949a98 to
d317a25
Compare
justinmc
reviewed
Sep 26, 2022
Contributor
justinmc
left a comment
There was a problem hiding this comment.
This looks fine to me, but is there a reasonable test that we can add here or do we need a test exemption?
CC @mdebbar It would be nice to have someone who knows more about the web engine review this as well if you have time!
Contributor
Author
I just added it to the already-existing tests of PointerSignalEvent, it's only a one line change so not obvious. But that will test that it can be properly handled by the event converter. |
mdebbar
approved these changes
Sep 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 27, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new discrete event type to represent a one-time zoom/scale, not as part of a wider gesture. Needed to support pinch-to-zoom on web as we cannot determine the start and end of a pinch, so it can't use
PointerPanZoomsystem.Part of flutter/flutter#112103
Sequence
Pre-launch Checklist
writing and running engine tests.
///).