Skip to content

Update InheritedWidget example parameter naming #112137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Sep 22, 2022
Merged

Update InheritedWidget example parameter naming #112137

auto-submit merged 1 commit into from
Sep 22, 2022

Conversation

@robiness
Copy link
Contributor

@robiness robiness commented Sep 22, 2022 •
edited
Loading

Fixes #112136

The actual implementation of updateShouldNotify uses oldWidget as a parameter not just old as in the example.
This does work but leads to a lint warning avoid_renaming_method_parameters.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 22, 2022
jonahwilliams
jonahwilliams approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 22, 2022

auto label is removed for flutter/flutter, pr: 112137, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 22, 2022

auto label is removed for flutter/flutter, pr: 112137, due to Validations Fail.

@robiness
Copy link
Contributor Author

robiness commented Sep 22, 2022

@Hixie Even though the example is from a long long time ago, this one takes 2 approves, would you mind looking over it briefly? Thanks!

justinmc
justinmc approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll jump in for secondary review! LGTM 👍

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2022
@auto-submit auto-submit bot merged commit c41a08f into flutter:master Sep 22, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
c41a08f Update InheritedWidget example parameter naming (flutter/fl…
f536006 
…utter#112137)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
c41a08f Update InheritedWidget example parameter naming (flutter/fl…
134d4f0 
…utter#112137)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
c41a08f Update InheritedWidget example parameter naming (flutter/fl…
4c64669 
…utter#112137)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 22, 2022
@engine-flutter-autoroll
c41a08f Update InheritedWidget example parameter naming (flutter/fl…
5cf0b54 
…utter#112137)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 23, 2022
@engine-flutter-autoroll
c41a08f Update InheritedWidget example parameter naming (flutter/fl…
3e1fca9 
…utter#112137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Copying InheritedWidget example leads to avoid_renaming_method_parameters

3 participants

@robiness @justinmc @jonahwilliams