Skip to content

Copying InheritedWidget example leads to avoid_renaming_method_parameters #112136

New issue
New issue
Closed
#112137
Closed
Copying InheritedWidget example leads to avoid_renaming_method_parameters#112136
#112137
Labels
f: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer version
@robiness

Description

@robiness
robiness
opened on Sep 22, 2022

Simply copying the InheritedWidget example leads to an avoid_renaming_method_parameters lint warning.

The implementation uses the name oldWIdget:

flutter/packages/flutter/lib/src/widgets/framework.dart

Line 1736 in 0cd3810

bool updateShouldNotify(covariant InheritedWidget oldWidget);

while the example still uses just old:

flutter/packages/flutter/lib/src/widgets/framework.dart

Line 1615 in 0cd3810

/// bool updateShouldNotify(FrogColor old) => color != old.color;

Metadata

Metadata

Assignees

No one assigned

    Labels

    f: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer version

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions