Reland isolate platform channels with conditional compilation #111712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1372248 to
1af8300
Compare
1af8300 to
9aef5cc
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
gaaclarke
commented
Sep 16, 2022
| // found in the LICENSE file. | ||
|
|
||
| import 'dart:async' show Completer; | ||
| import 'dart:isolate' show ReceivePort; |
Member
Author
There was a problem hiding this comment.
This is the important line, now isolate is only brought in through a conditional import.
|
|
||
| import 'dart:async'; | ||
| import 'dart:developer'; | ||
| import 'dart:isolate' show ReceivePort; |
Member
Author
There was a problem hiding this comment.
Note: the removed import.
| /// [RootIsolateToken] as its argument. The value `null` is returned when | ||
| /// executed from background isolates. | ||
| ui.RootIsolateToken? get rootIsolateToken => ui.RootIsolateToken.instance; | ||
| static ui.RootIsolateToken? get rootIsolateToken => ui.RootIsolateToken.instance; |
Member
Author
There was a problem hiding this comment.
I switched this to static since it doesn't make sense to have a ServiceBinding.instance to call it because we want to call it from background isolates where there will be no ServiceBinding.
dnfield
approved these changes
Sep 16, 2022
Contributor
|
auto label is removed for flutter/flutter, pr: 111712, due to - The status or check suite Windows framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This was referenced Sep 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 20, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #111702 with conditional compilation to remove
dart:isolatefrom the web target.issue: #13937
WARNING: the added integration test doesn't run in presubmit.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.