-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Revert isolate platform channels because of google integration tooling #111702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert isolate platform channels because of google integration tooling #111702
Conversation
…id (flutter#111279)" This reverts commit 71b4797.
…lutter#111320)" This reverts commit 1ad2757.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id' |
|
Looks like the revert bot can't handle PR's that revert multiple commits, fyi @godofredoc. |
@ricardoamador FYI |
Actually @gaaclarke was this created from the UI or manually created? |
|
This seemed off to me but I assumed a test would catch it if we were really doing it wrong. |
|
It would not handle this as a revert. This is a manual revert and not a revert initiated through the UI. When I update for phase 2 based on feedback this won't be an issue. |
|
@godofredoc @ricardoamador The revert was made by hand since the UI can't revert multiple PRs (that I know of). Is there any real requirement that the UI made it beyond a PR description that matches a format the bot can parse? |
|
The UI can revert multiple PRs. You just need to revert them individually which is probably preferable for tracking purposes rather than wrapping multiple commits from different PRs. |
|
There is doing to be some validation to the original PR you are reverting which is why it is looking for a link. If this was reverted through the UI everything would have been done automatically for you. |
|
But as I hinted at, you will be able to do what you just did shortly. Once I have our pipeline setup for this I will update it again to allow this type of revert. |
This has to be reverted because of integration problems with google's internal tooling.
see also:
import dart:isolate#111701Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.