Skip to content

Conversation

@gaaclarke
Copy link
Member

This has to be reverted because of integration problems with google's internal tooling.

see also:

  1. Add CI check for import dart:isolate #111701
  2. b/246785281

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 15, 2022
@gaaclarke gaaclarke added the revert Autorevert PR (with "Reason for revert:" comment) label Sep 15, 2022
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Sep 15, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 15, 2022

A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id'

@gaaclarke
Copy link
Member Author

Looks like the revert bot can't handle PR's that revert multiple commits, fyi @godofredoc.

@godofredoc
Copy link
Contributor

Looks like the revert bot can't handle PR's that revert multiple commits, fyi @godofredoc.

@ricardoamador FYI

@godofredoc
Copy link
Contributor

as to be reverted because of integration problems with google's internal tooling.

Actually @gaaclarke was this created from the UI or manually created?

@dnfield
Copy link
Contributor

dnfield commented Sep 15, 2022

This seemed off to me but I assumed a test would catch it if we were really doing it wrong.

@ricardoamador
Copy link
Contributor

ricardoamador commented Sep 15, 2022

It would not handle this as a revert. This is a manual revert and not a revert initiated through the UI. When I update for phase 2 based on feedback this won't be an issue.

@gaaclarke gaaclarke merged commit 12506ed into flutter:master Sep 15, 2022
@gaaclarke
Copy link
Member Author

@godofredoc @ricardoamador The revert was made by hand since the UI can't revert multiple PRs (that I know of). Is there any real requirement that the UI made it beyond a PR description that matches a format the bot can parse?

@ricardoamador
Copy link
Contributor

The UI can revert multiple PRs. You just need to revert them individually which is probably preferable for tracking purposes rather than wrapping multiple commits from different PRs.
https://github.com/flutter/flutter/wiki/Tree-hygiene#avoid-revert-revert-revert-revert-fix-foo-commit-messages

@ricardoamador
Copy link
Contributor

There is doing to be some validation to the original PR you are reverting which is why it is looking for a link. If this was reverted through the UI everything would have been done automatically for you.

@ricardoamador
Copy link
Contributor

But as I hinted at, you will be able to do what you just did shortly. Once I have our pipeline setup for this I will update it again to allow this type of revert.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants