Skip to content

Add CI check for import dart:isolate #111701

@gaaclarke

Description

@gaaclarke

#111320 passed all of our CI checks but failed when integrated with google's tooling because, for web, importing dart:isolate is a buildtime error there, but using dart:isolate is a runtime error in the open source tooling.

We've already established a practice of using conditional imports via a proxy file, see

if (dart.library.html) '_isolates_web.dart' as isolates;

We should have a CI step that enforces its usage to duplicate the behavior of the google tooling so we fail earlier.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: contributor-productivityTeam-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.team-frameworkOwned by Framework teamtriaged-frameworkTriaged by Framework team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions