Skip to content

Re-Land "Actually add example templates (#111531)" #111666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Sep 15, 2022
Merged

Re-Land "Actually add example templates (#111531)" #111666

auto-submit merged 2 commits into from
Sep 15, 2022

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Sep 15, 2022

Description

This re-lands #111531 with an updated WidgetsApp example that takes into account a new assert.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 15, 2022
HansMuller
HansMuller approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 15, 2022
@auto-submit auto-submit bot merged commit fb28a0d into flutter:master Sep 15, 2022
This was referenced Sep 16, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
fb28a0d Re-Land "Actually add example templates (#111531)" (flutter/f…
e8c600f 
…lutter#111666)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
fb28a0d Re-Land "Actually add example templates (#111531)" (flutter/f…
687699d 
…lutter#111666)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
fb28a0d Re-Land "Actually add example templates (#111531)" (flutter/f…
5092905 
…lutter#111666)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
fb28a0d Re-Land "Actually add example templates (#111531)" (flutter/f…
ed12d2a 
…lutter#111666)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
fb28a0d Re-Land "Actually add example templates (#111531)" (flutter/f…
c2501ff 
…lutter#111666)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
fb28a0d Re-Land "Actually add example templates (#111531)" (flutter/f…
1232707 
…lutter#111666)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
fb28a0d Re-Land "Actually add example templates (#111531)" (flutter/f…
06c3222 
…lutter#111666)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
fb28a0d Re-Land "Actually add example templates (#111531)" (flutter/f…
d1b1166 
…lutter#111666)
@gspencergoog gspencergoog deleted the example_examples branch October 7, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gspencergoog @HansMuller