Skip to content

Actually add example templates #111531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Sep 15, 2022
Merged

Actually add example templates #111531

auto-submit merged 2 commits into from
Sep 15, 2022

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Sep 14, 2022

Description

Whoops. In #111276, I meant to include these templates for starting a sample. The directory is linked from the README, but I forgot to add the files to the PR.

These are not meant to be linked from anywhere other than the README.md about creating samples.

Related Issues

Tests

  • added test templates too.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 14, 2022
@gspencergoog gspencergoog removed f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels Sep 14, 2022
HansMuller
HansMuller approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2022
@auto-submit auto-submit bot merged commit 7242ea2 into flutter:master Sep 15, 2022
zanderso added a commit that referenced this pull request Sep 15, 2022
@zanderso
Revert "Actually add example templates (#111531)"
8683784 
This reverts commit 7242ea2.
@zanderso zanderso mentioned this pull request Sep 15, 2022
Merged
zanderso added a commit that referenced this pull request Sep 15, 2022
@zanderso
Revert "Actually add example templates (#111531)" (#111632)
e2d3019 
This reverts commit 7242ea2.
This was referenced Sep 15, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2022
@engine-flutter-autoroll
7242ea2 Actually add example templates (flutter/flutter#111531)
a2286a0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 15, 2022
@engine-flutter-autoroll
7242ea2 Actually add example templates (flutter/flutter#111531)
d21d5e9
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Sep 15, 2022
@gspencergoog
Re-Land "Actually add example templates (flutter#111531)"
3be770c 
This reverts commit e2d3019 to re-land the above change.
@gspencergoog gspencergoog mentioned this pull request Sep 15, 2022
Merged
auto-submit bot pushed a commit that referenced this pull request Sep 15, 2022
@gspencergoog
Re-Land "Actually add example templates (#111531)" (#111666)
fb28a0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gspencergoog @HansMuller