Skip to content

Conversation

@godofredoc
Copy link
Contributor

CP: 20a78ed

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 15, 2022
@godofredoc godofredoc merged commit d4cf505 into flutter:flutter-3.4-candidate.23 Sep 15, 2022
godofredoc added a commit that referenced this pull request Sep 15, 2022
* Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240) (#111533)

Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>

* Revert Ballistic & Clamping simulation updates  (#111535)

* Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240)

* Revert Ballistic & Clamping simulation updates (#111201)

Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Co-authored-by: Kate Lovett <katelovett@google.com>

* Revert "Update MaterialBanner to support Material 3" (#111612)

* Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240)

* Revert Ballistic & Clamping simulation updates (#111201)

* Revert "Update `MaterialBanner` to support Material 3" (#111288)

Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: Casey Hillers <chillers@google.com>

* Revert "Use semantics label for backbutton and closebutton for Androi… (#111636)

* Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240)

* Revert Ballistic & Clamping simulation updates (#111201)

* Revert "Update `MaterialBanner` to support Material 3" (#111288)

* Revert "Use semantics label for backbutton and closebutton for Android" (#111305)

Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Xilai Zhang <xilaizhang@google.com>

* Revert "Single tap on the previous selection should toggle the toolbar on iOS…" (#111662)

Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Xilai Zhang <xilaizhang@google.com>
godofredoc added a commit that referenced this pull request Sep 16, 2022
* Revert "Update MaterialBanner to support Material 3" (#111612)

* Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240)

* Revert Ballistic & Clamping simulation updates (#111201)

* Revert "Update `MaterialBanner` to support Material 3" (#111288)

Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: Casey Hillers <chillers@google.com>

* Revert "Use semantics label for backbutton and closebutton for Androi… (#111636)

* Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240)

* Revert Ballistic & Clamping simulation updates (#111201)

* Revert "Update `MaterialBanner` to support Material 3" (#111288)

* Revert "Use semantics label for backbutton and closebutton for Android" (#111305)

Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Xilai Zhang <xilaizhang@google.com>

* Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240)

Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Xilai Zhang <xilaizhang@google.com>
@godofredoc godofredoc deleted the flutter-3.4-candidate.23 branch September 19, 2022 18:53
itsjustkevin added a commit that referenced this pull request Sep 22, 2022
* update engine version

* Prepare the framework for having RRect assert on negative radii (#111515)

* Remove no-longer-needed clamping of RRect radii (#111668)

* Revert "Use semantics label for backbutton and closebutton for Androi… (#111636)

* Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240)

* Revert Ballistic & Clamping simulation updates (#111201)

* Revert "Update `MaterialBanner` to support Material 3" (#111288)

* Revert "Use semantics label for backbutton and closebutton for Android" (#111305)

Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Xilai Zhang <xilaizhang@google.com>

Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-authored-by: godofredoc <godofredoc@google.com>
Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: Casey Hillers <chillers@google.com>
Co-authored-by: Xilai Zhang <xilaizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants