Revert "Use semantics label for backbutton and closebutton for Android" #111305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyHillers
approved these changes
Sep 12, 2022
Contributor
Author
|
cc @math1man |
This was referenced Sep 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 13, 2022
godofredoc
added a commit
that referenced
this pull request
Sep 15, 2022
#111636) * Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) * Revert "Use semantics label for backbutton and closebutton for Android" (#111305) Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Casey Hillers <chillers@google.com> Co-authored-by: Xilai Zhang <xilaizhang@google.com>
godofredoc
added a commit
that referenced
this pull request
Sep 15, 2022
* Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240) (#111533) Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> * Revert Ballistic & Clamping simulation updates (#111535) * Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Kate Lovett <katelovett@google.com> * Revert "Update MaterialBanner to support Material 3" (#111612) * Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Casey Hillers <chillers@google.com> * Revert "Use semantics label for backbutton and closebutton for Androi… (#111636) * Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) * Revert "Use semantics label for backbutton and closebutton for Android" (#111305) Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Casey Hillers <chillers@google.com> Co-authored-by: Xilai Zhang <xilaizhang@google.com> * Revert "Single tap on the previous selection should toggle the toolbar on iOS…" (#111662) Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Casey Hillers <chillers@google.com> Co-authored-by: Xilai Zhang <xilaizhang@google.com>
godofredoc
added a commit
that referenced
this pull request
Sep 16, 2022
* Revert "Update MaterialBanner to support Material 3" (#111612) * Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Casey Hillers <chillers@google.com> * Revert "Use semantics label for backbutton and closebutton for Androi… (#111636) * Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) * Revert "Use semantics label for backbutton and closebutton for Android" (#111305) Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Casey Hillers <chillers@google.com> Co-authored-by: Xilai Zhang <xilaizhang@google.com> * Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240) Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Casey Hillers <chillers@google.com> Co-authored-by: Xilai Zhang <xilaizhang@google.com>
itsjustkevin
added a commit
that referenced
this pull request
Sep 22, 2022
* update engine version * Prepare the framework for having RRect assert on negative radii (#111515) * Remove no-longer-needed clamping of RRect radii (#111668) * Revert "Use semantics label for backbutton and closebutton for Androi… (#111636) * Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) * Revert "Use semantics label for backbutton and closebutton for Android" (#111305) Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Casey Hillers <chillers@google.com> Co-authored-by: Xilai Zhang <xilaizhang@google.com> Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com> Co-authored-by: godofredoc <godofredoc@google.com> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Casey Hillers <chillers@google.com> Co-authored-by: Xilai Zhang <xilaizhang@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #110873. Will create a bug with more detail