Skip to content

[framework] work around to load self packages from packages/ (#111350) #111410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
itsjustkevin merged 1 commit into from
Sep 13, 2022
Merged

[framework] work around to load self packages from packages/ (#111350) #111410

itsjustkevin merged 1 commit into from
Sep 13, 2022

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 12, 2022 •
edited
Loading

Cherry pick for #111411

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 12, 2022

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-3.2-candidate.5. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-3.2-candidate.5 to master September 12, 2022 18:33
@flutter-dashboard flutter-dashboard bot added engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 12, 2022
@google-cla
Copy link

google-cla bot commented Sep 12, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jonahwilliams jonahwilliams changed the base branch from master to flutter-3.2-candidate.5 September 12, 2022 18:34
@jonahwilliams jonahwilliams mentioned this pull request Sep 12, 2022
Closed
@jonahwilliams jonahwilliams marked this pull request as ready for review September 12, 2022 22:32
@itsjustkevin itsjustkevin self-requested a review September 13, 2022 14:41
@itsjustkevin itsjustkevin merged commit 5870540 into flutter:flutter-3.2-candidate.5 Sep 13, 2022
@itsjustkevin itsjustkevin mentioned this pull request Sep 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 14, 2022
@engine-flutter-autoroll
5870540 [framework] work around to load self packages from packages/ …
58ded8a 
…(#111350) (flutter/flutter#111410)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 14, 2022
@engine-flutter-autoroll
58705405b [framework] work around to load self packages from packages…
c13bd4e 
…/ (#111350) (flutter/flutter#111410)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsjustkevin itsjustkevin itsjustkevin approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @itsjustkevin